linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm/vmscan: fix typos in comments
@ 2026-04-16  2:42 Xiang Gao
  2026-04-16  4:02 ` Donet Tom
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Xiang Gao @ 2026-04-16  2:42 UTC (permalink / raw)
  To: akpm, axelrasmussen, yuanchu, hannes
  Cc: weixugc, david, mhocko, zhengqi.arch, shakeel.butt, ljs,
	linux-mm, linux-kernel, Xiang Gao

From: Xiang Gao <gaoxiang17@xiaomi.com>

Fix three typos in comments:

- Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)

Signed-off-by: gaoxiang17 <gaoxiang17@xiaomi.com>
---
 mm/vmscan.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 0fc9373e8251..710fbe1ee151 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -109,7 +109,7 @@ struct scan_control {
 	/* zone_reclaim_mode */
 	unsigned int may_unmap:1;
 
-	/* zome_reclaim_mode, boost reclaim, cgroup restrictions */
+	/* zone_reclaim_mode, boost reclaim, cgroup restrictions */
 	unsigned int may_swap:1;
 
 	/* Not allow cache_trim_mode to be turned on as part of reclaim? */
@@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)
 	if (current_is_kswapd() || cgroup_reclaim(sc))
 		return;
 
-	/* Throttle if making no progress at high prioities. */
+	/* Throttle if making no progress at high priorities. */
 	if (sc->priority == 1 && !sc->nr_reclaimed)
 		reclaim_throttle(pgdat, VMSCAN_THROTTLE_NOPROGRESS);
 }
@@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)
 
 		/*
 		 * There should be no need to raise the scanning priority if
-		 * enough pages are already being scanned that that high
+		 * enough pages are already being scanned that the high
 		 * watermark would be met at 100% efficiency.
 		 */
 		if (kswapd_shrink_node(pgdat, &sc))
-- 
2.34.1



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] mm/vmscan: fix typos in comments
  2026-04-16  2:42 [PATCH] mm/vmscan: fix typos in comments Xiang Gao
@ 2026-04-16  4:02 ` Donet Tom
  2026-04-16  4:40 ` Donet Tom
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 10+ messages in thread
From: Donet Tom @ 2026-04-16  4:02 UTC (permalink / raw)
  To: Xiang Gao, akpm, axelrasmussen, yuanchu, hannes
  Cc: weixugc, david, mhocko, zhengqi.arch, shakeel.butt, ljs,
	linux-mm, linux-kernel, Xiang Gao

[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]

Hi

On 4/16/26 8:12 AM, Xiang Gao wrote:
> From: Xiang Gao<gaoxiang17@xiaomi.com>
>
> Fix three typos in comments:
>
> - Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
> - Line 6208: "prioities" -> "priorities"
> - Line 7067: "that that high" -> "that the high" (duplicated word)
>
> Signed-off-by: gaoxiang17<gaoxiang17@xiaomi.com>
> ---
>   mm/vmscan.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 0fc9373e8251..710fbe1ee151 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -109,7 +109,7 @@ struct scan_control {
>   	/* zone_reclaim_mode */
>   	unsigned int may_unmap:1;
>   
> -	/* zome_reclaim_mode, boost reclaim, cgroup restrictions */
> +	/* zone_reclaim_mode, boost reclaim, cgroup restrictions */
>   	unsigned int may_swap:1;
>   
>   	/* Not allow cache_trim_mode to be turned on as part of reclaim? */
> @@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)
>   	if (current_is_kswapd() || cgroup_reclaim(sc))
>   		return;
>   
> -	/* Throttle if making no progress at high prioities. */
> +	/* Throttle if making no progress at high priorities. */
>   	if (sc->priority == 1 && !sc->nr_reclaimed)
>   		reclaim_throttle(pgdat, VMSCAN_THROTTLE_NOPROGRESS);
>   }
> @@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)
>   
>   		/*
>   		 * There should be no need to raise the scanning priority if
> -		 * enough pages are already being scanned that that high
> +		 * enough pages are already being scanned that the high
>   		 * watermark would be met at 100% efficiency.
>   		 */
>   		if (kswapd_shrink_node(pgdat, &sc))


LGTM

Reviewed by: Donet Tom<donettom@linux.ibm.com>

-Donet


[-- Attachment #2: Type: text/html, Size: 2894 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] mm/vmscan: fix typos in comments
  2026-04-16  2:42 [PATCH] mm/vmscan: fix typos in comments Xiang Gao
  2026-04-16  4:02 ` Donet Tom
@ 2026-04-16  4:40 ` Donet Tom
  2026-04-16  5:18   ` 答复: [External Mail]Re: " 高翔
  2026-04-16  4:49 ` Barry Song
  2026-04-16  5:15 ` [PATCH v2] " Xiang Gao
  3 siblings, 1 reply; 10+ messages in thread
From: Donet Tom @ 2026-04-16  4:40 UTC (permalink / raw)
  To: Xiang Gao, akpm, axelrasmussen, yuanchu, hannes
  Cc: weixugc, david, mhocko, zhengqi.arch, shakeel.butt, ljs,
	linux-mm, linux-kernel, Xiang Gao

Hi

On 4/16/26 8:12 AM, Xiang Gao wrote:
> From: Xiang Gao <gaoxiang17@xiaomi.com>
>
> Fix three typos in comments:
>
> - Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
> - Line 6208: "prioities" -> "priorities"
> - Line 7067: "that that high" -> "that the high" (duplicated word)
>
> Signed-off-by: gaoxiang17 <gaoxiang17@xiaomi.com>


I am seeing below issue with checkpatch.pl

./scripts/checkpatch.pl --strict 0001-mm-vmscan-fix-typos-in-comments.patch
WARNING: From:/Signed-off-by: email name mismatch: 'From: Xiang Gao 
<gaoxiang17@xiaomi.com>' != 'Signed-off-by: gaoxiang17 
<gaoxiang17@xiaomi.com>'

total: 0 errors, 1 warnings, 0 checks, 24 lines checked

> ---
>   mm/vmscan.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 0fc9373e8251..710fbe1ee151 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -109,7 +109,7 @@ struct scan_control {
>   	/* zone_reclaim_mode */
>   	unsigned int may_unmap:1;
>   
> -	/* zome_reclaim_mode, boost reclaim, cgroup restrictions */
> +	/* zone_reclaim_mode, boost reclaim, cgroup restrictions */
>   	unsigned int may_swap:1;
>   
>   	/* Not allow cache_trim_mode to be turned on as part of reclaim? */
> @@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)
>   	if (current_is_kswapd() || cgroup_reclaim(sc))
>   		return;
>   
> -	/* Throttle if making no progress at high prioities. */
> +	/* Throttle if making no progress at high priorities. */
>   	if (sc->priority == 1 && !sc->nr_reclaimed)
>   		reclaim_throttle(pgdat, VMSCAN_THROTTLE_NOPROGRESS);
>   }
> @@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)
>   
>   		/*
>   		 * There should be no need to raise the scanning priority if
> -		 * enough pages are already being scanned that that high
> +		 * enough pages are already being scanned that the high
>   		 * watermark would be met at 100% efficiency.
>   		 */
>   		if (kswapd_shrink_node(pgdat, &sc))


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] mm/vmscan: fix typos in comments
  2026-04-16  2:42 [PATCH] mm/vmscan: fix typos in comments Xiang Gao
  2026-04-16  4:02 ` Donet Tom
  2026-04-16  4:40 ` Donet Tom
@ 2026-04-16  4:49 ` Barry Song
  2026-04-16  5:18   ` 答复: [External Mail]Re: " 高翔
  2026-04-16  5:15 ` [PATCH v2] " Xiang Gao
  3 siblings, 1 reply; 10+ messages in thread
From: Barry Song @ 2026-04-16  4:49 UTC (permalink / raw)
  To: Xiang Gao
  Cc: akpm, axelrasmussen, yuanchu, hannes, weixugc, david, mhocko,
	zhengqi.arch, shakeel.butt, ljs, linux-mm, linux-kernel,
	Xiang Gao

On Thu, Apr 16, 2026 at 10:43 AM Xiang Gao <gxxa03070307@gmail.com> wrote:
>
> From: Xiang Gao <gaoxiang17@xiaomi.com>
>
> Fix three typos in comments:
>
> - Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
> - Line 6208: "prioities" -> "priorities"
> - Line 7067: "that that high" -> "that the high" (duplicated word)
>
> Signed-off-by: gaoxiang17 <gaoxiang17@xiaomi.com>

Should be:
Signed-off-by: Xiang Gao <gaoxiang17@xiaomi.com>

Otherwise,

Reviewed-by: Barry Song <baohua@kernel.org>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2] mm/vmscan: fix typos in comments
  2026-04-16  2:42 [PATCH] mm/vmscan: fix typos in comments Xiang Gao
                   ` (2 preceding siblings ...)
  2026-04-16  4:49 ` Barry Song
@ 2026-04-16  5:15 ` Xiang Gao
  2026-04-16  5:47   ` Donet Tom
  3 siblings, 1 reply; 10+ messages in thread
From: Xiang Gao @ 2026-04-16  5:15 UTC (permalink / raw)
  To: akpm, axelrasmussen, yuanchu, hannes
  Cc: weixugc, david, mhocko, zhengqi.arch, shakeel.butt, ljs, baohua,
	linux-mm, linux-kernel, Xiang Gao

From: Xiang Gao <gaoxiang17@xiaomi.com>

Fix three typos in comments:

- Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)

Signed-off-by: Xiang Gao <gaoxiang17@xiaomi.com>
Reviewed-by: Barry Song <baohua@kernel.org>
---
 mm/vmscan.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 0fc9373e8251..710fbe1ee151 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -109,7 +109,7 @@ struct scan_control {
 	/* zone_reclaim_mode */
 	unsigned int may_unmap:1;
 
-	/* zome_reclaim_mode, boost reclaim, cgroup restrictions */
+	/* zone_reclaim_mode, boost reclaim, cgroup restrictions */
 	unsigned int may_swap:1;
 
 	/* Not allow cache_trim_mode to be turned on as part of reclaim? */
@@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)
 	if (current_is_kswapd() || cgroup_reclaim(sc))
 		return;
 
-	/* Throttle if making no progress at high prioities. */
+	/* Throttle if making no progress at high priorities. */
 	if (sc->priority == 1 && !sc->nr_reclaimed)
 		reclaim_throttle(pgdat, VMSCAN_THROTTLE_NOPROGRESS);
 }
@@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)
 
 		/*
 		 * There should be no need to raise the scanning priority if
-		 * enough pages are already being scanned that that high
+		 * enough pages are already being scanned that the high
 		 * watermark would be met at 100% efficiency.
 		 */
 		if (kswapd_shrink_node(pgdat, &sc))
-- 
2.34.1



^ permalink raw reply	[flat|nested] 10+ messages in thread

* 答复: [External Mail]Re: [PATCH] mm/vmscan: fix typos in comments
  2026-04-16  4:49 ` Barry Song
@ 2026-04-16  5:18   ` 高翔
  0 siblings, 0 replies; 10+ messages in thread
From: 高翔 @ 2026-04-16  5:18 UTC (permalink / raw)
  To: Barry Song, Xiang Gao
  Cc: akpm, axelrasmussen, yuanchu, hannes, weixugc, david, mhocko,
	zhengqi.arch, shakeel.butt, ljs, linux-mm, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]

Hi,

Thanks for catching this. I'll fix the Signed-off-by name mismatch and send a v2.

Best regards,Xiang Gao


________________________________
发件人: Barry Song <baohua@kernel.org>
发送时间: 2026年4月16日 12:49:46
收件人: Xiang Gao
抄送: akpm@linux-foundation.org; axelrasmussen@google.com; yuanchu@google.com; hannes@cmpxchg.org; weixugc@google.com; david@kernel.org; mhocko@kernel.org; zhengqi.arch@bytedance.com; shakeel.butt@linux.dev; ljs@kernel.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org; 高翔
主题: [External Mail]Re: [PATCH] mm/vmscan: fix typos in comments

[外部邮件] 此邮件来源于小米公司外部,请谨慎处理。若对邮件安全性存疑,请将邮件转发给misec@xiaomi.com进行反馈

On Thu, Apr 16, 2026 at 10:43 AM Xiang Gao <gxxa03070307@gmail.com> wrote:
>
> From: Xiang Gao <gaoxiang17@xiaomi.com>
>
> Fix three typos in comments:
>
> - Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
> - Line 6208: "prioities" -> "priorities"
> - Line 7067: "that that high" -> "that the high" (duplicated word)
>
> Signed-off-by: gaoxiang17 <gaoxiang17@xiaomi.com>

Should be:
Signed-off-by: Xiang Gao <gaoxiang17@xiaomi.com>

Otherwise,

Reviewed-by: Barry Song <baohua@kernel.org>

[-- Attachment #2: Type: text/html, Size: 2944 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* 答复: [External Mail]Re: [PATCH] mm/vmscan: fix typos in comments
  2026-04-16  4:40 ` Donet Tom
@ 2026-04-16  5:18   ` 高翔
  0 siblings, 0 replies; 10+ messages in thread
From: 高翔 @ 2026-04-16  5:18 UTC (permalink / raw)
  To: Donet Tom, Xiang Gao, akpm, axelrasmussen, yuanchu, hannes
  Cc: weixugc, david, mhocko, zhengqi.arch, shakeel.butt, ljs,
	linux-mm, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2923 bytes --]

Hi,

Thanks for catching this. I'll fix the Signed-off-by name mismatch and send a v2.

Best regards,Xiang Gao

________________________________
发件人: Donet Tom <donettom@linux.ibm.com>
发送时间: 2026年4月16日 12:40:12
收件人: Xiang Gao; akpm@linux-foundation.org; axelrasmussen@google.com; yuanchu@google.com; hannes@cmpxchg.org
抄送: weixugc@google.com; david@kernel.org; mhocko@kernel.org; zhengqi.arch@bytedance.com; shakeel.butt@linux.dev; ljs@kernel.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org; 高翔
主题: [External Mail]Re: [PATCH] mm/vmscan: fix typos in comments

[外部邮件] 此邮件来源于小米公司外部,请谨慎处理。若对邮件安全性存疑,请将邮件转发给misec@xiaomi.com进行反馈

Hi

On 4/16/26 8:12 AM, Xiang Gao wrote:
> From: Xiang Gao <gaoxiang17@xiaomi.com>
>
> Fix three typos in comments:
>
> - Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
> - Line 6208: "prioities" -> "priorities"
> - Line 7067: "that that high" -> "that the high" (duplicated word)
>
> Signed-off-by: gaoxiang17 <gaoxiang17@xiaomi.com>


I am seeing below issue with checkpatch.pl

./scripts/checkpatch.pl --strict 0001-mm-vmscan-fix-typos-in-comments.patch
WARNING: From:/Signed-off-by: email name mismatch: 'From: Xiang Gao
<gaoxiang17@xiaomi.com>' != 'Signed-off-by: gaoxiang17
<gaoxiang17@xiaomi.com>'

total: 0 errors, 1 warnings, 0 checks, 24 lines checked

> ---
>   mm/vmscan.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 0fc9373e8251..710fbe1ee151 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -109,7 +109,7 @@ struct scan_control {
>       /* zone_reclaim_mode */
>       unsigned int may_unmap:1;
>
> -     /* zome_reclaim_mode, boost reclaim, cgroup restrictions */
> +     /* zone_reclaim_mode, boost reclaim, cgroup restrictions */
>       unsigned int may_swap:1;
>
>       /* Not allow cache_trim_mode to be turned on as part of reclaim? */
> @@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)
>       if (current_is_kswapd() || cgroup_reclaim(sc))
>               return;
>
> -     /* Throttle if making no progress at high prioities. */
> +     /* Throttle if making no progress at high priorities. */
>       if (sc->priority == 1 && !sc->nr_reclaimed)
>               reclaim_throttle(pgdat, VMSCAN_THROTTLE_NOPROGRESS);
>   }
> @@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)
>
>               /*
>                * There should be no need to raise the scanning priority if
> -              * enough pages are already being scanned that that high
> +              * enough pages are already being scanned that the high
>                * watermark would be met at 100% efficiency.
>                */
>               if (kswapd_shrink_node(pgdat, &sc))

[-- Attachment #2: Type: text/html, Size: 10815 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] mm/vmscan: fix typos in comments
  2026-04-16  5:15 ` [PATCH v2] " Xiang Gao
@ 2026-04-16  5:47   ` Donet Tom
  2026-04-16  6:23     ` 答复: [External Mail]Re: " 高翔
  2026-04-16  6:25     ` 高翔
  0 siblings, 2 replies; 10+ messages in thread
From: Donet Tom @ 2026-04-16  5:47 UTC (permalink / raw)
  To: Xiang Gao, akpm, axelrasmussen, yuanchu, hannes
  Cc: weixugc, david, mhocko, zhengqi.arch, shakeel.butt, ljs, baohua,
	linux-mm, linux-kernel, Xiang Gao

[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]

Hi

On 4/16/26 10:45 AM, Xiang Gao wrote:
> From: Xiang Gao<gaoxiang17@xiaomi.com>
>
> Fix three typos in comments:
>
> - Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
> - Line 6208: "prioities" -> "priorities"
> - Line 7067: "that that high" -> "that the high" (duplicated word)
>
> Signed-off-by: Xiang Gao<gaoxiang17@xiaomi.com>
> Reviewed-by: Barry Song<baohua@kernel.org>
>
>

It might be better to send v2 as a new series next time —just a suggestion.

LGTM Reviewed by: Donet Tom <donettom@linux.ibm.com> -Donet


> ---
>   mm/vmscan.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 0fc9373e8251..710fbe1ee151 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -109,7 +109,7 @@ struct scan_control {
>   	/* zone_reclaim_mode */
>   	unsigned int may_unmap:1;
>   
> -	/* zome_reclaim_mode, boost reclaim, cgroup restrictions */
> +	/* zone_reclaim_mode, boost reclaim, cgroup restrictions */
>   	unsigned int may_swap:1;
>   
>   	/* Not allow cache_trim_mode to be turned on as part of reclaim? */
> @@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)
>   	if (current_is_kswapd() || cgroup_reclaim(sc))
>   		return;
>   
> -	/* Throttle if making no progress at high prioities. */
> +	/* Throttle if making no progress at high priorities. */
>   	if (sc->priority == 1 && !sc->nr_reclaimed)
>   		reclaim_throttle(pgdat, VMSCAN_THROTTLE_NOPROGRESS);
>   }
> @@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)
>   
>   		/*
>   		 * There should be no need to raise the scanning priority if
> -		 * enough pages are already being scanned that that high
> +		 * enough pages are already being scanned that the high
>   		 * watermark would be met at 100% efficiency.
>   		 */
>   		if (kswapd_shrink_node(pgdat, &sc))

[-- Attachment #2: Type: text/html, Size: 3389 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* 答复: [External Mail]Re: [PATCH v2] mm/vmscan: fix typos in comments
  2026-04-16  5:47   ` Donet Tom
@ 2026-04-16  6:23     ` 高翔
  2026-04-16  6:25     ` 高翔
  1 sibling, 0 replies; 10+ messages in thread
From: 高翔 @ 2026-04-16  6:23 UTC (permalink / raw)
  To: Donet Tom, Xiang Gao, akpm, axelrasmussen, yuanchu, hannes
  Cc: weixugc, david, mhocko, zhengqi.arch, shakeel.butt, ljs, baohua,
	linux-mm, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2781 bytes --]

ok, thanks.

________________________________
发件人: Donet Tom <donettom@linux.ibm.com>
发送时间: 2026年4月16日 13:47:29
收件人: Xiang Gao; akpm@linux-foundation.org; axelrasmussen@google.com; yuanchu@google.com; hannes@cmpxchg.org
抄送: weixugc@google.com; david@kernel.org; mhocko@kernel.org; zhengqi.arch@bytedance.com; shakeel.butt@linux.dev; ljs@kernel.org; baohua@kernel.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org; 高翔
主题: [External Mail]Re: [PATCH v2] mm/vmscan: fix typos in comments


[外部邮件] 此邮件来源于小米公司外部,请谨慎处理。若对邮件安全性存疑,请将邮件转发给misec@xiaomi.com进行反馈

Hi

On 4/16/26 10:45 AM, Xiang Gao wrote:

From: Xiang Gao <gaoxiang17@xiaomi.com><mailto:gaoxiang17@xiaomi.com>

Fix three typos in comments:

- Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)

Signed-off-by: Xiang Gao <gaoxiang17@xiaomi.com><mailto:gaoxiang17@xiaomi.com>
Reviewed-by: Barry Song <baohua@kernel.org><mailto:baohua@kernel.org>



It might be better to send v2 as a new series next time ―just a suggestion.


LGTM Reviewed by: Donet Tom <donettom@linux.ibm.com><mailto:donettom@linux.ibm.com> -Donet



---
 mm/vmscan.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 0fc9373e8251..710fbe1ee151 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -109,7 +109,7 @@ struct scan_control {
        /* zone_reclaim_mode */
        unsigned int may_unmap:1;

-       /* zome_reclaim_mode, boost reclaim, cgroup restrictions */
+       /* zone_reclaim_mode, boost reclaim, cgroup restrictions */
        unsigned int may_swap:1;

        /* Not allow cache_trim_mode to be turned on as part of reclaim? */
@@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)
        if (current_is_kswapd() || cgroup_reclaim(sc))
                return;

-       /* Throttle if making no progress at high prioities. */
+       /* Throttle if making no progress at high priorities. */
        if (sc->priority == 1 && !sc->nr_reclaimed)
                reclaim_throttle(pgdat, VMSCAN_THROTTLE_NOPROGRESS);
 }
@@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)

                /*
                 * There should be no need to raise the scanning priority if
-                * enough pages are already being scanned that that high
+                * enough pages are already being scanned that the high
                 * watermark would be met at 100% efficiency.
                 */
                if (kswapd_shrink_node(pgdat, &sc))


[-- Attachment #2: Type: text/html, Size: 4777 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* 答复: [External Mail]Re: [PATCH v2] mm/vmscan: fix typos in comments
  2026-04-16  5:47   ` Donet Tom
  2026-04-16  6:23     ` 答复: [External Mail]Re: " 高翔
@ 2026-04-16  6:25     ` 高翔
  1 sibling, 0 replies; 10+ messages in thread
From: 高翔 @ 2026-04-16  6:25 UTC (permalink / raw)
  To: Donet Tom, Xiang Gao, akpm, axelrasmussen, yuanchu, hannes
  Cc: weixugc, david, mhocko, zhengqi.arch, shakeel.butt, ljs, baohua,
	linux-mm, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2933 bytes --]

I've sent the updated patches as v3 with your Reviewed-by tag included. Thank you for the review and the suggestion ― I'll send v2/v3 as new series going forward.

________________________________
发件人: Donet Tom <donettom@linux.ibm.com>
发送时间: 2026年4月16日 13:47:29
收件人: Xiang Gao; akpm@linux-foundation.org; axelrasmussen@google.com; yuanchu@google.com; hannes@cmpxchg.org
抄送: weixugc@google.com; david@kernel.org; mhocko@kernel.org; zhengqi.arch@bytedance.com; shakeel.butt@linux.dev; ljs@kernel.org; baohua@kernel.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org; 高翔
主题: [External Mail]Re: [PATCH v2] mm/vmscan: fix typos in comments


[外部邮件] 此邮件来源于小米公司外部,请谨慎处理。若对邮件安全性存疑,请将邮件转发给misec@xiaomi.com进行反馈

Hi

On 4/16/26 10:45 AM, Xiang Gao wrote:

From: Xiang Gao <gaoxiang17@xiaomi.com><mailto:gaoxiang17@xiaomi.com>

Fix three typos in comments:

- Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)

Signed-off-by: Xiang Gao <gaoxiang17@xiaomi.com><mailto:gaoxiang17@xiaomi.com>
Reviewed-by: Barry Song <baohua@kernel.org><mailto:baohua@kernel.org>



It might be better to send v2 as a new series next time ―just a suggestion.


LGTM Reviewed by: Donet Tom <donettom@linux.ibm.com><mailto:donettom@linux.ibm.com> -Donet



---
 mm/vmscan.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 0fc9373e8251..710fbe1ee151 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -109,7 +109,7 @@ struct scan_control {
        /* zone_reclaim_mode */
        unsigned int may_unmap:1;

-       /* zome_reclaim_mode, boost reclaim, cgroup restrictions */
+       /* zone_reclaim_mode, boost reclaim, cgroup restrictions */
        unsigned int may_swap:1;

        /* Not allow cache_trim_mode to be turned on as part of reclaim? */
@@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)
        if (current_is_kswapd() || cgroup_reclaim(sc))
                return;

-       /* Throttle if making no progress at high prioities. */
+       /* Throttle if making no progress at high priorities. */
        if (sc->priority == 1 && !sc->nr_reclaimed)
                reclaim_throttle(pgdat, VMSCAN_THROTTLE_NOPROGRESS);
 }
@@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)

                /*
                 * There should be no need to raise the scanning priority if
-                * enough pages are already being scanned that that high
+                * enough pages are already being scanned that the high
                 * watermark would be met at 100% efficiency.
                 */
                if (kswapd_shrink_node(pgdat, &sc))


[-- Attachment #2: Type: text/html, Size: 4948 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-04-16  6:26 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-16  2:42 [PATCH] mm/vmscan: fix typos in comments Xiang Gao
2026-04-16  4:02 ` Donet Tom
2026-04-16  4:40 ` Donet Tom
2026-04-16  5:18   ` 答复: [External Mail]Re: " 高翔
2026-04-16  4:49 ` Barry Song
2026-04-16  5:18   ` 答复: [External Mail]Re: " 高翔
2026-04-16  5:15 ` [PATCH v2] " Xiang Gao
2026-04-16  5:47   ` Donet Tom
2026-04-16  6:23     ` 答复: [External Mail]Re: " 高翔
2026-04-16  6:25     ` 高翔

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox