From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Anatoly Stepanov <stepanov.anatoly@huawei.com>,
willy@infradead.org, akpm@linux-foundation.org, ljs@kernel.org,
Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, wangkefeng.wang@huawei.com,
yanquanmin1@huawei.com, zuoze1@huawei.com,
artem.kuzin@huawei.com, gutierrez.asier@huawei-partners.com
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] procfs: add contpte info into smaps
Date: Wed, 15 Apr 2026 14:52:38 +0200 [thread overview]
Message-ID: <e5fcb3ba-6494-4295-a8a7-191c3ea0aae4@kernel.org> (raw)
In-Reply-To: <20260415192853.3470423-2-stepanov.anatoly@huawei.com>
> +#ifndef pte_cont
> +#define pte_cont(pte) (false)
> +#endif
> +
> static void smaps_pte_entry(pte_t *pte, unsigned long addr,
> struct mm_walk *walk)
> {
> @@ -1023,12 +1030,14 @@ static void smaps_pte_entry(pte_t *pte, unsigned long addr,
> bool locked = !!(vma->vm_flags & VM_LOCKED);
> struct page *page = NULL;
> bool present = false, young = false, dirty = false;
> + bool cont = false;
> pte_t ptent = ptep_get(pte);
>
> if (pte_present(ptent)) {
> page = vm_normal_page(vma, addr, ptent);
> young = pte_young(ptent);
> dirty = pte_dirty(ptent);
> + cont = pte_cont(ptent);
No, none of this low-level pte_cont fiddling in common code.
We have folio_pte_batch() to batch over folio ptes. And we want some
better page table walkers to just do the batching for us:
https://lore.kernel.org/r/20260412174244.133715-1-osalvador@suse.de
--
Cheers,
David
next prev parent reply other threads:[~2026-04-15 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 19:28 [RFC PATCH 0/2] Use high-order folios in mmap sync RA Anatoly Stepanov
2026-04-15 13:18 ` Matthew Wilcox
2026-04-15 13:33 ` Stepanov Anatoly
2026-04-15 19:28 ` [RFC PATCH 1/2] procfs: add contpte info into smaps Anatoly Stepanov
2026-04-15 12:52 ` David Hildenbrand (Arm) [this message]
2026-04-15 19:28 ` [RFC PATCH 2/2] filemap: use high-order folios in filemap sync RA Anatoly Stepanov
2026-04-15 12:06 ` Pedro Falcato
2026-04-15 12:31 ` Stepanov Anatoly
2026-04-15 12:46 ` Stepanov Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5fcb3ba-6494-4295-a8a7-191c3ea0aae4@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=artem.kuzin@huawei.com \
--cc=gutierrez.asier@huawei-partners.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=stepanov.anatoly@huawei.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=yanquanmin1@huawei.com \
--cc=zuoze1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox