From: Stepanov Anatoly <stepanov.anatoly@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <akpm@linux-foundation.org>, <david@kernel.org>, <ljs@kernel.org>,
<Liam.Howlett@oracle.com>, <vbabka@kernel.org>, <rppt@kernel.org>,
<surenb@google.com>, <mhocko@suse.com>,
<wangkefeng.wang@huawei.com>, <yanquanmin1@huawei.com>,
<zuoze1@huawei.com>, <artem.kuzin@huawei.com>,
<gutierrez.asier@huawei-partners.com>,
<linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/2] Use high-order folios in mmap sync RA
Date: Wed, 15 Apr 2026 16:33:48 +0300 [thread overview]
Message-ID: <972b8365-60cf-4f29-ac4d-05e6c50f573c@huawei.com> (raw)
In-Reply-To: <ad-QQwctxvJVHW4U@casper.infradead.org>
On 4/15/2026 4:18 PM, Matthew Wilcox wrote:
> On Thu, Apr 16, 2026 at 03:28:51AM +0800, Anatoly Stepanov wrote:
>> When "fault around" is enabled, 0-order folios might significantly
>> slowdown filemap_map_pages().
>
> There's a lot of "might" in this patchset. I'd like to know that there
> is a real workload that benefits from this, and if so by how much.
>
Actually, no real workload at the moment.
The intention is to highlight the filemap_map_pages issue,
i found it during my experiments with the page cache.
> You raise an interesting point that faultaround may be slow, and maybe
> we should start out with 0 faultaround until we've determined (somehow)
> that faultaround would be beneficial for this particular mapping. Like
> we adjust the readahead window.
>
Sounds nice,
looks like, there should be kind of "virtual readahead" or smth like this.
BTW, for the benchmark i posted, if fault_around is disabled (4K)
then the throughput is even higher.
>> For example when async RA won't be able to start,
>> we might end up with a large mmap'ed file with 0-orders.
>
> That is a feature, not a bug. If access is random, then we don't want
> to do any async readahead because we don't know where the next access
> will be. We just end up occupying large chunks of memory with
> never-used data.
>
>
Yes, i understand the logic behind this, what i mean is that it can actually happen.
--
Anatoly Stepanov, Huawei
next prev parent reply other threads:[~2026-04-15 13:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 19:28 Anatoly Stepanov
2026-04-15 13:18 ` Matthew Wilcox
2026-04-15 13:33 ` Stepanov Anatoly [this message]
2026-04-15 19:28 ` [RFC PATCH 1/2] procfs: add contpte info into smaps Anatoly Stepanov
2026-04-15 12:52 ` David Hildenbrand (Arm)
2026-04-15 19:28 ` [RFC PATCH 2/2] filemap: use high-order folios in filemap sync RA Anatoly Stepanov
2026-04-15 12:06 ` Pedro Falcato
2026-04-15 12:31 ` Stepanov Anatoly
2026-04-15 12:46 ` Stepanov Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=972b8365-60cf-4f29-ac4d-05e6c50f573c@huawei.com \
--to=stepanov.anatoly@huawei.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=artem.kuzin@huawei.com \
--cc=david@kernel.org \
--cc=gutierrez.asier@huawei-partners.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=yanquanmin1@huawei.com \
--cc=zuoze1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox