linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: fix regex pattern in CORE MM category
@ 2026-04-22 12:37 Pedro Falcato
  2026-04-22 12:45 ` Lorenzo Stoakes
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Pedro Falcato @ 2026-04-22 12:37 UTC (permalink / raw)
  To: Andrew Morton
  Cc: linux-mm, Vlastimil Babka, David Hildenbrand, Lorenzo Stoakes,
	Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
	Liam R . Howlett, Pedro Falcato

The pattern "include/linux/page[-_]*" matches every file that starts with
"page", because it's a regex and not a glob (so it has the meaning of
include/linux/page + match [-_] 0+ times).

Fix it up into a more regex-correct expression. Doing so reduces CC's
drastically in patches that touch pagemap.h (which is maintained as part of
PAGE CACHE).

As a side-effect, move linux/pageblock-flags.h explicitly under PAGE
ALLOCATOR.

Link: https://lore.kernel.org/linux-mm/20260422005608.342028-1-fmayle@google.com/
Signed-off-by: Pedro Falcato <pfalcato@suse.de>
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index d25342ca8aa1..224c15299acc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16804,7 +16804,7 @@ F:	mm/sparse.c
 F:	mm/util.c
 F:	mm/vmpressure.c
 F:	mm/vmstat.c
-N:	include/linux/page[-_]*
+N:	include\/linux\/page[-_][a-zA-Z]*
 
 MEMORY MANAGEMENT - EXECMEM
 M:	Andrew Morton <akpm@linux-foundation.org>
@@ -16961,6 +16961,7 @@ S:	Maintained
 F:	include/linux/compaction.h
 F:	include/linux/gfp.h
 F:	include/linux/page-isolation.h
+F:	include/linux/pageblock-flags.h
 F:	mm/compaction.c
 F:	mm/debug_page_alloc.c
 F:	mm/debug_page_ref.c
-- 
2.53.0



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: fix regex pattern in CORE MM category
  2026-04-22 12:37 [PATCH] MAINTAINERS: fix regex pattern in CORE MM category Pedro Falcato
@ 2026-04-22 12:45 ` Lorenzo Stoakes
  2026-04-22 15:43 ` David Hildenbrand (Arm)
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Lorenzo Stoakes @ 2026-04-22 12:45 UTC (permalink / raw)
  To: Pedro Falcato
  Cc: Andrew Morton, linux-mm, Vlastimil Babka, David Hildenbrand,
	Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
	Liam R . Howlett

On Wed, Apr 22, 2026 at 01:37:26PM +0100, Pedro Falcato wrote:
> The pattern "include/linux/page[-_]*" matches every file that starts with
> "page", because it's a regex and not a glob (so it has the meaning of
> include/linux/page + match [-_] 0+ times).
>
> Fix it up into a more regex-correct expression. Doing so reduces CC's
> drastically in patches that touch pagemap.h (which is maintained as part of
> PAGE CACHE).
>
> As a side-effect, move linux/pageblock-flags.h explicitly under PAGE
> ALLOCATOR.
>
> Link: https://lore.kernel.org/linux-mm/20260422005608.342028-1-fmayle@google.com/
> Signed-off-by: Pedro Falcato <pfalcato@suse.de>

LGTM, so:

Reviewed-by: Lorenzo Stoakes <ljs@kernel.org>

> ---
>  MAINTAINERS | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d25342ca8aa1..224c15299acc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16804,7 +16804,7 @@ F:	mm/sparse.c
>  F:	mm/util.c
>  F:	mm/vmpressure.c
>  F:	mm/vmstat.c
> -N:	include/linux/page[-_]*
> +N:	include\/linux\/page[-_][a-zA-Z]*
>
>  MEMORY MANAGEMENT - EXECMEM
>  M:	Andrew Morton <akpm@linux-foundation.org>
> @@ -16961,6 +16961,7 @@ S:	Maintained
>  F:	include/linux/compaction.h
>  F:	include/linux/gfp.h
>  F:	include/linux/page-isolation.h
> +F:	include/linux/pageblock-flags.h
>  F:	mm/compaction.c
>  F:	mm/debug_page_alloc.c
>  F:	mm/debug_page_ref.c
> --
> 2.53.0
>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: fix regex pattern in CORE MM category
  2026-04-22 12:37 [PATCH] MAINTAINERS: fix regex pattern in CORE MM category Pedro Falcato
  2026-04-22 12:45 ` Lorenzo Stoakes
@ 2026-04-22 15:43 ` David Hildenbrand (Arm)
  2026-04-22 16:40 ` Vlastimil Babka (SUSE)
  2026-04-23  0:32 ` SeongJae Park
  3 siblings, 0 replies; 7+ messages in thread
From: David Hildenbrand (Arm) @ 2026-04-22 15:43 UTC (permalink / raw)
  To: Pedro Falcato, Andrew Morton
  Cc: linux-mm, Vlastimil Babka, Lorenzo Stoakes, Mike Rapoport,
	Suren Baghdasaryan, Michal Hocko, Liam R . Howlett

On 4/22/26 14:37, Pedro Falcato wrote:
> The pattern "include/linux/page[-_]*" matches every file that starts with
> "page", because it's a regex and not a glob (so it has the meaning of
> include/linux/page + match [-_] 0+ times).
> 
> Fix it up into a more regex-correct expression. Doing so reduces CC's
> drastically in patches that touch pagemap.h (which is maintained as part of
> PAGE CACHE).

Nice

Acked-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: fix regex pattern in CORE MM category
  2026-04-22 12:37 [PATCH] MAINTAINERS: fix regex pattern in CORE MM category Pedro Falcato
  2026-04-22 12:45 ` Lorenzo Stoakes
  2026-04-22 15:43 ` David Hildenbrand (Arm)
@ 2026-04-22 16:40 ` Vlastimil Babka (SUSE)
  2026-04-23  0:32 ` SeongJae Park
  3 siblings, 0 replies; 7+ messages in thread
From: Vlastimil Babka (SUSE) @ 2026-04-22 16:40 UTC (permalink / raw)
  To: Pedro Falcato, Andrew Morton
  Cc: linux-mm, David Hildenbrand, Lorenzo Stoakes, Mike Rapoport,
	Suren Baghdasaryan, Michal Hocko, Liam R . Howlett

On 4/22/26 14:37, Pedro Falcato wrote:
> The pattern "include/linux/page[-_]*" matches every file that starts with
> "page", because it's a regex and not a glob (so it has the meaning of
> include/linux/page + match [-_] 0+ times).
> 
> Fix it up into a more regex-correct expression. Doing so reduces CC's
> drastically in patches that touch pagemap.h (which is maintained as part of
> PAGE CACHE).
> 
> As a side-effect, move linux/pageblock-flags.h explicitly under PAGE
> ALLOCATOR.
> 
> Link: https://lore.kernel.org/linux-mm/20260422005608.342028-1-fmayle@google.com/
> Signed-off-by: Pedro Falcato <pfalcato@suse.de>

Acked-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>

> ---
>  MAINTAINERS | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d25342ca8aa1..224c15299acc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16804,7 +16804,7 @@ F:	mm/sparse.c
>  F:	mm/util.c
>  F:	mm/vmpressure.c
>  F:	mm/vmstat.c
> -N:	include/linux/page[-_]*
> +N:	include\/linux\/page[-_][a-zA-Z]*
>  
>  MEMORY MANAGEMENT - EXECMEM
>  M:	Andrew Morton <akpm@linux-foundation.org>
> @@ -16961,6 +16961,7 @@ S:	Maintained
>  F:	include/linux/compaction.h
>  F:	include/linux/gfp.h
>  F:	include/linux/page-isolation.h
> +F:	include/linux/pageblock-flags.h
>  F:	mm/compaction.c
>  F:	mm/debug_page_alloc.c
>  F:	mm/debug_page_ref.c



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: fix regex pattern in CORE MM category
  2026-04-22 12:37 [PATCH] MAINTAINERS: fix regex pattern in CORE MM category Pedro Falcato
                   ` (2 preceding siblings ...)
  2026-04-22 16:40 ` Vlastimil Babka (SUSE)
@ 2026-04-23  0:32 ` SeongJae Park
  2026-04-23  9:39   ` Pedro Falcato
  3 siblings, 1 reply; 7+ messages in thread
From: SeongJae Park @ 2026-04-23  0:32 UTC (permalink / raw)
  To: Pedro Falcato
  Cc: SeongJae Park, Andrew Morton, linux-mm, Vlastimil Babka,
	David Hildenbrand, Lorenzo Stoakes, Mike Rapoport,
	Suren Baghdasaryan, Michal Hocko, Liam R . Howlett

On Wed, 22 Apr 2026 13:37:26 +0100 Pedro Falcato <pfalcato@suse.de> wrote:

> The pattern "include/linux/page[-_]*" matches every file that starts with
> "page", because it's a regex and not a glob (so it has the meaning of
> include/linux/page + match [-_] 0+ times).
> 
> Fix it up into a more regex-correct expression. Doing so reduces CC's
> drastically in patches that touch pagemap.h (which is maintained as part of
> PAGE CACHE).
> 
> As a side-effect, move linux/pageblock-flags.h explicitly under PAGE
> ALLOCATOR.
> 
> Link: https://lore.kernel.org/linux-mm/20260422005608.342028-1-fmayle@google.com/

Just thinking loud.  I was initially wondering the purpose of this link.  Seems
this was added to show the example of pagemap.h touching patch that can
dmonstrate how many CC can be reduced.  I once thought about suggesting to add
the number or the context on the description, but realize it is too trivial.
So just thinking loud.

$ # Without this patch
$ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
13
$ # With this patch
$ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
6

> Signed-off-by: Pedro Falcato <pfalcato@suse.de>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: fix regex pattern in CORE MM category
  2026-04-23  0:32 ` SeongJae Park
@ 2026-04-23  9:39   ` Pedro Falcato
  2026-04-23 10:12     ` Lorenzo Stoakes
  0 siblings, 1 reply; 7+ messages in thread
From: Pedro Falcato @ 2026-04-23  9:39 UTC (permalink / raw)
  To: SeongJae Park
  Cc: Andrew Morton, linux-mm, Vlastimil Babka, David Hildenbrand,
	Lorenzo Stoakes, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
	Liam R . Howlett

On Wed, Apr 22, 2026 at 05:32:26PM -0700, SeongJae Park wrote:
> On Wed, 22 Apr 2026 13:37:26 +0100 Pedro Falcato <pfalcato@suse.de> wrote:
> 
> > The pattern "include/linux/page[-_]*" matches every file that starts with
> > "page", because it's a regex and not a glob (so it has the meaning of
> > include/linux/page + match [-_] 0+ times).
> > 
> > Fix it up into a more regex-correct expression. Doing so reduces CC's
> > drastically in patches that touch pagemap.h (which is maintained as part of
> > PAGE CACHE).
> > 
> > As a side-effect, move linux/pageblock-flags.h explicitly under PAGE
> > ALLOCATOR.
> > 
> > Link: https://lore.kernel.org/linux-mm/20260422005608.342028-1-fmayle@google.com/
> 
> Just thinking loud.  I was initially wondering the purpose of this link.  Seems
> this was added to show the example of pagemap.h touching patch that can
> dmonstrate how many CC can be reduced.  I once thought about suggesting to add
> the number or the context on the description, but realize it is too trivial.
> So just thinking loud.

Right, I probably chucked that link in there without explaining it well
enough. I was having my leasurely read through linux-mm when I noticed that
particular patch had _way_ too many CC's. I had a quick look and, yeah, found
the issue.

For what it's worth there are many such CC's out there. A group of 6-8 MM people
get CC'd on pretty much everything that happens in the kernel. Not super wieldy.

One thing at a time, I guess.

> 
> $ # Without this patch
> $ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
> 13
> $ # With this patch
> $ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
> 6
> 
> > Signed-off-by: Pedro Falcato <pfalcato@suse.de>
> 
> Reviewed-by: SeongJae Park <sj@kernel.org>

Thanks!

-- 
Pedro


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: fix regex pattern in CORE MM category
  2026-04-23  9:39   ` Pedro Falcato
@ 2026-04-23 10:12     ` Lorenzo Stoakes
  0 siblings, 0 replies; 7+ messages in thread
From: Lorenzo Stoakes @ 2026-04-23 10:12 UTC (permalink / raw)
  To: Pedro Falcato
  Cc: SeongJae Park, Andrew Morton, linux-mm, Vlastimil Babka,
	David Hildenbrand, Mike Rapoport, Suren Baghdasaryan,
	Michal Hocko, Liam R . Howlett

On Thu, Apr 23, 2026 at 10:39:59AM +0100, Pedro Falcato wrote:
> On Wed, Apr 22, 2026 at 05:32:26PM -0700, SeongJae Park wrote:
> > On Wed, 22 Apr 2026 13:37:26 +0100 Pedro Falcato <pfalcato@suse.de> wrote:
> >
> > > The pattern "include/linux/page[-_]*" matches every file that starts with
> > > "page", because it's a regex and not a glob (so it has the meaning of
> > > include/linux/page + match [-_] 0+ times).
> > >
> > > Fix it up into a more regex-correct expression. Doing so reduces CC's
> > > drastically in patches that touch pagemap.h (which is maintained as part of
> > > PAGE CACHE).
> > >
> > > As a side-effect, move linux/pageblock-flags.h explicitly under PAGE
> > > ALLOCATOR.
> > >
> > > Link: https://lore.kernel.org/linux-mm/20260422005608.342028-1-fmayle@google.com/
> >
> > Just thinking loud.  I was initially wondering the purpose of this link.  Seems
> > this was added to show the example of pagemap.h touching patch that can
> > dmonstrate how many CC can be reduced.  I once thought about suggesting to add
> > the number or the context on the description, but realize it is too trivial.
> > So just thinking loud.
>
> Right, I probably chucked that link in there without explaining it well
> enough. I was having my leasurely read through linux-mm when I noticed that
> particular patch had _way_ too many CC's. I had a quick look and, yeah, found
> the issue.
>
> For what it's worth there are many such CC's out there. A group of 6-8 MM people
> get CC'd on pretty much everything that happens in the kernel. Not super wieldy.
>
> One thing at a time, I guess.

Yup this is a useful addition, the link is fine one thing at a time indeed :)

>
> >
> > $ # Without this patch
> > $ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
> > 13
> > $ # With this patch
> > $ ./scripts/get_maintainer.pl ./0001-mm-limit-filemap-fault-readahead-to-vma-boundaries.patch | wc -l
> > 6
> >
> > > Signed-off-by: Pedro Falcato <pfalcato@suse.de>
> >
> > Reviewed-by: SeongJae Park <sj@kernel.org>
>
> Thanks!
>
> --
> Pedro

Cheers, Lorenzo


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-04-23 10:12 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-22 12:37 [PATCH] MAINTAINERS: fix regex pattern in CORE MM category Pedro Falcato
2026-04-22 12:45 ` Lorenzo Stoakes
2026-04-22 15:43 ` David Hildenbrand (Arm)
2026-04-22 16:40 ` Vlastimil Babka (SUSE)
2026-04-23  0:32 ` SeongJae Park
2026-04-23  9:39   ` Pedro Falcato
2026-04-23 10:12     ` Lorenzo Stoakes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox