linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Mike Rapoport <rppt@kernel.org>
Cc: "David Hildenbrand (Arm)" <david@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
	Aishwarya TCV <aishwarya.tcv@arm.com>,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/mm: Specify requirement for PROC_MEM_ALWAYS_FORCE=y
Date: Fri, 17 Apr 2026 13:37:46 +0100	[thread overview]
Message-ID: <ad3c60a8-8346-44cb-927f-367dd0c39b1a@sirena.org.uk> (raw)
In-Reply-To: <aeIonE2r89VdTJZt@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

On Fri, Apr 17, 2026 at 03:33:32PM +0300, Mike Rapoport wrote:
> On Fri, Apr 17, 2026 at 12:24:25PM +0100, Mark Brown wrote:

> > >  {
> > > -	mem_fd = open("/proc/self/mem", O_RDWR);
> > > -	if (mem_fd < 0)
> > > -		ksft_exit_fail_msg("opening /proc/self/mem failed\n");

> > Yes, this is a preexisting bug in the test which I see there are more
> > instances of :(

> Do you mean that ksft_exit_fail_msg() should also print the test name and
> the actual failure message should be ksft_perror() before?

Oh, I hadn't read that closely enough - if bombing out of the entire
program it's not an issue.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-04-17 12:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16 18:40 Mark Brown
2026-04-16 18:56 ` Mike Rapoport
2026-04-16 19:05 ` David Hildenbrand (Arm)
2026-04-16 19:10   ` Mark Brown
2026-04-16 19:28     ` Mike Rapoport
2026-04-17  2:56       ` Anshuman Khandual
2026-04-17 12:41         ` Mike Rapoport
2026-04-17 13:10           ` Mark Brown
2026-04-17  4:36       ` Dev Jain
2026-04-17 11:24       ` Mark Brown
2026-04-17 12:33         ` Mike Rapoport
2026-04-17 12:37           ` Mark Brown [this message]
2026-04-17  2:57 ` Anshuman Khandual
2026-04-17  4:37 ` Dev Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad3c60a8-8346-44cb-927f-367dd0c39b1a@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=aishwarya.tcv@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox