From: "David Hildenbrand (Arm)" <david@kernel.org>
To: David Laight <david.laight.linux@gmail.com>, Dev Jain <dev.jain@arm.com>
Cc: akpm@linux-foundation.org, shuah@kernel.org, ljs@kernel.org,
Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
ryan.roberts@arm.com, anshuman.khandual@arm.com,
Sarthak Sharma <sarthak.sharma@arm.com>
Subject: Re: [PATCH v2] selftests/mm: Simplify byte pattern checking in mremap_test
Date: Wed, 15 Apr 2026 11:21:40 +0200 [thread overview]
Message-ID: <6339e1fe-bdd0-4ae1-bab8-5a2ead0e6a84@kernel.org> (raw)
In-Reply-To: <20260415101623.33004858@pumpkin>
On 4/15/26 11:16, David Laight wrote:
> On Wed, 15 Apr 2026 14:05:01 +0530
> Dev Jain <dev.jain@arm.com> wrote:
>
> ...
>>>
>>> c) Remove any randomization from the test. There is no need for random
>>> patterns, just fill pages with increasing numbers.
>>
>> Agreed.
>
> I'd start from (say) 0x123456789abcdef0 rather than zero to avoid lots
> of zero bytes.
I'd just initialize the first page with (unsigned int) 0's, the second
page with (unsigned int) 1's etc.
mremap only moved full pages, so it would even be sufficient to only
check the first (unsigned int) in a page. But obviously, just comparing
full pages might be easier.
--
Cheers,
David
prev parent reply other threads:[~2026-04-15 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 4:45 Dev Jain
2026-04-15 6:00 ` Mike Rapoport
2026-04-15 7:48 ` David Hildenbrand (Arm)
2026-04-15 8:35 ` Dev Jain
2026-04-15 8:50 ` David Hildenbrand (Arm)
2026-04-15 9:16 ` David Laight
2026-04-15 9:21 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6339e1fe-bdd0-4ae1-bab8-5a2ead0e6a84@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david.laight.linux@gmail.com \
--cc=dev.jain@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=sarthak.sharma@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox