From: David Laight <david.laight.linux@gmail.com>
To: Dev Jain <dev.jain@arm.com>
Cc: "David Hildenbrand (Arm)" <david@kernel.org>,
akpm@linux-foundation.org, shuah@kernel.org, ljs@kernel.org,
Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
ryan.roberts@arm.com, anshuman.khandual@arm.com,
Sarthak Sharma <sarthak.sharma@arm.com>
Subject: Re: [PATCH v2] selftests/mm: Simplify byte pattern checking in mremap_test
Date: Wed, 15 Apr 2026 10:16:23 +0100 [thread overview]
Message-ID: <20260415101623.33004858@pumpkin> (raw)
In-Reply-To: <57b5d0f9-3e56-4f96-9e3a-2f475a78a8eb@arm.com>
On Wed, 15 Apr 2026 14:05:01 +0530
Dev Jain <dev.jain@arm.com> wrote:
...
> >
> > c) Remove any randomization from the test. There is no need for random
> > patterns, just fill pages with increasing numbers.
>
> Agreed.
I'd start from (say) 0x123456789abcdef0 rather than zero to avoid lots
of zero bytes.
> > d) Just always verify the whole regions. Without the rand() magic this
> > will probably be just ... fairly fast?
>
> Yeah we are doing a simple memcmp() so it is fine.
You don't need a copy of the buffer, just compare against the pattern
that filled it.
David
>
> I'll implement these changes.
>
> >
>
>
next prev parent reply other threads:[~2026-04-15 9:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 4:45 Dev Jain
2026-04-15 6:00 ` Mike Rapoport
2026-04-15 7:48 ` David Hildenbrand (Arm)
2026-04-15 8:35 ` Dev Jain
2026-04-15 8:50 ` David Hildenbrand (Arm)
2026-04-15 9:16 ` David Laight [this message]
2026-04-15 9:21 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260415101623.33004858@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=sarthak.sharma@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox