From: Pratyush Yadav <pratyush@kernel.org>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, dmatlack@google.com,
pratyush@kernel.org, skhawaja@google.com
Subject: Re: [PATCH v4 11/11] liveupdate: fix return value on session allocation failure
Date: Tue, 14 Apr 2026 09:35:45 +0000 [thread overview]
Message-ID: <2vxzmrz5995a.fsf@kernel.org> (raw)
In-Reply-To: <20260413185127.128180-12-pasha.tatashin@soleen.com> (Pasha Tatashin's message of "Mon, 13 Apr 2026 18:51:27 +0000")
On Mon, Apr 13 2026, Pasha Tatashin wrote:
> When session allocation fails during deserialization, the global 'err'
> variable was not updated before returning. This caused subsequent calls
> to luo_session_deserialize() to incorrectly report success.
>
> Ensure 'err' is set to the error code from PTR_ERR(session). This
> ensures that an error is correctly returned to userspace when it
> attempts to open /dev/liveupdate in the new kernel if deserialization
> failed.
>
> Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Reviewed-by: Pratyush Yadav (Google) <pratyush@kernel.org>
[...]
--
Regards,
Pratyush Yadav
prev parent reply other threads:[~2026-04-14 9:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 18:51 [PATCH v4 00/11] liveupdate: Fix module unloading and unregister API Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 01/11] liveupdate: Safely print untrusted strings Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 02/11] liveupdate: Synchronize lazy initialization of FLB private state Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 03/11] liveupdate: Protect file handler list with rwsem Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 04/11] liveupdate: Protect FLB lists with luo_register_rwlock Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 05/11] liveupdate: Defer FLB module refcounting to active sessions Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 06/11] liveupdate: Remove luo_session_quiesce() Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 07/11] liveupdate: Auto unregister FLBs on file handler unregistration Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 08/11] liveupdate: Remove liveupdate_test_unregister() Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 09/11] liveupdate: Make unregister functions return void Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 10/11] liveupdate: Defer file handler module refcounting to active sessions Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 11/11] liveupdate: fix return value on session allocation failure Pasha Tatashin
2026-04-14 9:35 ` Pratyush Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2vxzmrz5995a.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dmatlack@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
--cc=skhawaja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox