From: Pasha Tatashin <pasha.tatashin@soleen.com>
To: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, pasha.tatashin@soleen.com,
dmatlack@google.com, pratyush@kernel.org, skhawaja@google.com
Subject: [PATCH v4 08/11] liveupdate: Remove liveupdate_test_unregister()
Date: Mon, 13 Apr 2026 18:51:24 +0000 [thread overview]
Message-ID: <20260413185127.128180-9-pasha.tatashin@soleen.com> (raw)
In-Reply-To: <20260413185127.128180-1-pasha.tatashin@soleen.com>
Now that file handler unregistration automatically unregisters all
associated file handlers (FLBs), the liveupdate_test_unregister()
function is no longer needed. Remove it along with its usages
and declarations.
Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Reviewed-by: Pratyush Yadav (Google) <pratyush@kernel.org>
---
kernel/liveupdate/luo_file.c | 2 --
kernel/liveupdate/luo_internal.h | 2 --
lib/tests/liveupdate.c | 18 ------------------
3 files changed, 22 deletions(-)
diff --git a/kernel/liveupdate/luo_file.c b/kernel/liveupdate/luo_file.c
index b37bd79974ce..f3b7bb698d3b 100644
--- a/kernel/liveupdate/luo_file.c
+++ b/kernel/liveupdate/luo_file.c
@@ -929,8 +929,6 @@ int liveupdate_unregister_file_handler(struct liveupdate_file_handler *fh)
if (!liveupdate_enabled())
return -EOPNOTSUPP;
- liveupdate_test_unregister(fh);
-
guard(rwsem_write)(&luo_register_rwlock);
luo_flb_unregister_all(fh);
list_del(&ACCESS_PRIVATE(fh, list));
diff --git a/kernel/liveupdate/luo_internal.h b/kernel/liveupdate/luo_internal.h
index 22f6901f89ed..875844d7a41d 100644
--- a/kernel/liveupdate/luo_internal.h
+++ b/kernel/liveupdate/luo_internal.h
@@ -110,10 +110,8 @@ void luo_flb_serialize(void);
#ifdef CONFIG_LIVEUPDATE_TEST
void liveupdate_test_register(struct liveupdate_file_handler *fh);
-void liveupdate_test_unregister(struct liveupdate_file_handler *fh);
#else
static inline void liveupdate_test_register(struct liveupdate_file_handler *fh) { }
-static inline void liveupdate_test_unregister(struct liveupdate_file_handler *fh) { }
#endif
#endif /* _LINUX_LUO_INTERNAL_H */
diff --git a/lib/tests/liveupdate.c b/lib/tests/liveupdate.c
index 496d6ef91a30..e4b0ecbee32f 100644
--- a/lib/tests/liveupdate.c
+++ b/lib/tests/liveupdate.c
@@ -135,24 +135,6 @@ void liveupdate_test_register(struct liveupdate_file_handler *fh)
TEST_NFLBS, fh->compatible);
}
-void liveupdate_test_unregister(struct liveupdate_file_handler *fh)
-{
- int err, i;
-
- for (i = 0; i < TEST_NFLBS; i++) {
- struct liveupdate_flb *flb = &test_flbs[i];
-
- err = liveupdate_unregister_flb(fh, flb);
- if (err) {
- pr_err("Failed to unregister %s %pe\n",
- flb->compatible, ERR_PTR(err));
- }
- }
-
- pr_info("Unregistered %d FLBs from file handler: [%s]\n",
- TEST_NFLBS, fh->compatible);
-}
-
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Pasha Tatashin <pasha.tatashin@soleen.com>");
MODULE_DESCRIPTION("In-kernel test for LUO mechanism");
--
2.43.0
next prev parent reply other threads:[~2026-04-13 18:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 18:51 [PATCH v4 00/11] liveupdate: Fix module unloading and unregister API Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 01/11] liveupdate: Safely print untrusted strings Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 02/11] liveupdate: Synchronize lazy initialization of FLB private state Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 03/11] liveupdate: Protect file handler list with rwsem Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 04/11] liveupdate: Protect FLB lists with luo_register_rwlock Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 05/11] liveupdate: Defer FLB module refcounting to active sessions Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 06/11] liveupdate: Remove luo_session_quiesce() Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 07/11] liveupdate: Auto unregister FLBs on file handler unregistration Pasha Tatashin
2026-04-13 18:51 ` Pasha Tatashin [this message]
2026-04-13 18:51 ` [PATCH v4 09/11] liveupdate: Make unregister functions return void Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 10/11] liveupdate: Defer file handler module refcounting to active sessions Pasha Tatashin
2026-04-13 18:51 ` [PATCH v4 11/11] liveupdate: fix return value on session allocation failure Pasha Tatashin
2026-04-14 9:35 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260413185127.128180-9-pasha.tatashin@soleen.com \
--to=pasha.tatashin@soleen.com \
--cc=akpm@linux-foundation.org \
--cc=dmatlack@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
--cc=skhawaja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox