* [PATCH v3] mm/page_alloc: fix spaces used for indentation instead of tabs
@ 2026-04-16 6:20 Xiang Gao
0 siblings, 0 replies; only message in thread
From: Xiang Gao @ 2026-04-16 6:20 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, linux-kernel, Donet Tom, Xiang Gao
From: Xiang Gao <gaoxiang17@xiaomi.com>
checkpatch.pl reports two indentation errors in page_alloc.c where
spaces are used instead of tabs:
ERROR: code indent should use tabs where possible
#887: FILE: mm/page_alloc.c:887:
+ VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype,$
ERROR: code indent should use tabs where possible
#6626: FILE: mm/page_alloc.c:6626:
+ sysctl_min_unmapped_ratio) / 100;$
In __del_page_from_free_list(), the VM_WARN_ONCE at line 887 uses 8
spaces for indentation instead of a tab. The identical VM_WARN_ONCE
calls in __add_to_free_list() and move_to_free_list() both correctly
use a tab.
In setup_min_unmapped_ratio(), the continuation line at 6626 uses 6
tabs + 9 spaces for alignment. Replace the excess spaces with 6 tabs
+ 1 space to correctly align with the opening parenthesis on the
previous line.
Signed-off-by: Xiang Gao <gaoxiang17@xiaomi.com>
Reviewed-by: Donet Tom <donettom@linux.ibm.com>
---
mm/page_alloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2d4b6f1a554e..752673a9b43c 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -884,7 +884,7 @@ static inline void __del_page_from_free_list(struct page *page, struct zone *zon
{
int nr_pages = 1 << order;
- VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype,
+ VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype,
"page type is %d, passed migratetype is %d (nr=%d)\n",
get_pageblock_migratetype(page), migratetype, nr_pages);
@@ -6623,7 +6623,7 @@ static void setup_min_unmapped_ratio(void)
for_each_zone(zone)
zone->zone_pgdat->min_unmapped_pages += (zone_managed_pages(zone) *
- sysctl_min_unmapped_ratio) / 100;
+ sysctl_min_unmapped_ratio) / 100;
}
--
2.34.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-04-16 6:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-16 6:20 [PATCH v3] mm/page_alloc: fix spaces used for indentation instead of tabs Xiang Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox