From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 433733D69 for ; Tue, 11 Feb 2025 15:09:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739286578; cv=none; b=Q1nE7vLohuC38/+SJltNe1pdo6Z0mUL3jSkpo3y0t8vqumqbrNOt1VMcU8IvRdyG09j/VrggfG2fH5rmmQ6Q1leLjlvCo5vmv9DSKo4mUCf3vOE/Bg2YeDTbGUd4bh94X01eKpoIWgfq6XriOMEnz/5eXu/AAmcbcIMa7GaMqiI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739286578; c=relaxed/simple; bh=XeoOR9mWR3QI2DUTtx8o/Mb95udO0qya1ua0UzUV/KE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FpfQOKcNcYU2NT4bBAu5mKMqsSb0IvDS8PdmgI1NfLNLOAHfrU8uME5QVSNaPSNOVFPpB+kUunoT7Nuq662qlYx0W7zRvFQWET2F2wBtWcOOaFkBXqz8thCCgXm8RqijWAAR1shcqbPCPS7q9Kp6CSlqmeXv7kwzmwZt0h0cOsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=vB0Omp/B; arc=none smtp.client-ip=209.85.128.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="vB0Omp/B" Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-4361e89b6daso39685135e9.3 for ; Tue, 11 Feb 2025 07:09:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739286574; x=1739891374; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9/pIQ6Ih8jIe4aCDENSWzfq7X2UaTCBit5cGbc+Hn7Q=; b=vB0Omp/BMmAreQD5wXEluyIJMdJvohs5tc2+PmHSW6vgT6jAreSwZm5VY/Y/7sCCrG GvY1GN1ym4dJpy3urW+W8bg7oqz/sWt+bg66s9a+V0s+recEy1k5uZG1SgAziTvgg8JE oZjGrk3iU7FRCLUMiWGTY/nOZnl4ASQjmzZaAKx9RHWfCvSdrj2Qz7Ci+UImZBDZwZ/P RqRxe1L/SXssn1F5IOXuaMU8u3ZPUhhLE4aNXZ8vG3mj9VwSCRyaWFf4qUiC5DhJpouA +GI9jpTBmSEjlZ5/2pQhymR7uTgSLNrpbvWjV04srW2Gl7C5Lj6taP/n0RHJvL1PNTFV SAYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739286574; x=1739891374; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9/pIQ6Ih8jIe4aCDENSWzfq7X2UaTCBit5cGbc+Hn7Q=; b=JWYQ/KMm4NtZ+JjqhxbK0MOU/RwGBfgB7R/R+LHWpLu7EK1XXr1k9mJahfuHCwj/79 a/X22vyrFRJ72ww9NRFVPVyRRkWWDSDpckeo5vKdcqeoFaiPcHOvYGLKtkqTC+gBNsQ6 KHh3la0MzGH0VdfXECvGR1omGuS6bqhjrUnH3A7j1+iBVza6HB2yzqDmziyZvKH/YHnk 3Pk6wW3xq6iPhJQdtiBu+afqDvpTkZrawWWxAKjk4Lwcoa7rWFunje0S3abknyoh3t5t cyHJr/uL45F/x625AWPBiVHAGJ1rItGpYOmqaNQs2YzYYE94LIWKDtv6HrtDDiV7Yozg kkUQ== X-Forwarded-Encrypted: i=1; AJvYcCW2cjPT2u1YN/YFeCi2m/fjU/fqkDNFYVgHYmvQVmlv9HvEWbblFbpXZRovVvHn9ArRzF4rl4s0HlQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzsNql0lJepeCxd9GsB01JxAVoQL/1cBRtAuG8RgBT8oz6v04o0 DdBIyBsPRYASnl4AdaxbqcfBCgkyOMxBRenu1sQ9syk6ZIP6/FTA1ydvMfvfz7M= X-Gm-Gg: ASbGncvBXQjmbrOLzhN2SMXNd/DAwwDQ67dZtDb1g3Xj57+93OL43OVLRJxJ6/HZXSG v8DL17mpSovhujISZqcYvO94cD0+S8kgjJ47fZbFVMLVFKLMqzqwluuILd6+kbHJ8URy+a5c3Hb OAPcEuZVSDea0p/pSIxvwwZSZG717zcjeNdUTZb1YxIJgqlUpYEQTGhCgyVn3uSIfbpnBv2OuTv Xk3Bq/HjdKopQhKCWzz+DmPoIRQr8cZpDFd74PLVbhkIFRjF//pj5FBPlgC8a4Np9dc8FCJ9EtR E2EYgx3eQfxqcVUowA16klsrRrgHBG0ShjBMhmfJOrLzH6STwAusXpG5hA== X-Google-Smtp-Source: AGHT+IFJ3xtCWgpPSZFz6Y/4+XS35mXvCCpo86PNaZ13YSALHhPxK4DFSsAULBbzYHjHwZkRoP4kFw== X-Received: by 2002:a05:600c:5124:b0:439:4db6:43ad with SMTP id 5b1f17b1804b1-4394db64797mr23522605e9.21.1739286574345; Tue, 11 Feb 2025 07:09:34 -0800 (PST) Received: from localhost (p200300f65f018b0400000000000001b9.dip0.t-ipconnect.de. [2003:f6:5f01:8b04::1b9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dd4c8ca52sm9363080f8f.89.2025.02.11.07.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 07:09:33 -0800 (PST) Date: Tue, 11 Feb 2025 16:09:32 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Geert Uytterhoeven Cc: Vlastimil Babka , Joe Perches , Andrew Morton , workflows@vger.kernel.org, Theodore Ts'o , Bryan O'Donoghue , Thorsten Leemhuis , Kees Cook , linux-kernel@vger.kernel.org, regressions@lists.linux.dev Subject: Re: [PATCH v2 1/2] get_maintainer: add --substatus for reporting subsystem status Message-ID: References: <20250203-b4-get_maintainer-v2-0-83ba008b491f@suse.cz> <20250203-b4-get_maintainer-v2-1-83ba008b491f@suse.cz> <7aodxv46lj6rthjo4i5zhhx2lybrhb4uknpej2dyz3e7im5w3w@w23bz6fx3jnn> Precedence: bulk X-Mailing-List: workflows@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6nqdwb73tx4ragth" Content-Disposition: inline In-Reply-To: --6nqdwb73tx4ragth Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 1/2] get_maintainer: add --substatus for reporting subsystem status MIME-Version: 1.0 Hello Geert, On Tue, Feb 11, 2025 at 11:48:13AM +0100, Geert Uytterhoeven wrote: > On Tue, 11 Feb 2025 at 11:32, Uwe Kleine-K=F6nig > wrote: > > On Mon, Feb 03, 2025 at 12:13:16PM +0100, Vlastimil Babka wrote: > > > The subsystem status is currently reported with --role(stats) by > > > adjusting the maintainer role for any status different from Maintaine= d. > > > This has two downsides: > > > > > > - if a subsystem has only reviewers or mailing lists and no maintaine= rs, > > > the status is not reported (i.e. typically, Orphan subsystems have = no > > > maintainers) > > > > > > - the Supported status means that someone is paid for maintaining, but > > > it is reported as "supporter" for all the maintainers, which can be > > > incorrect. People have been also confused about what "supporter" > > > means. > > > > > > This patch introduces a new --substatus option and functionality aimed > > > to report the subsystem status separately, without adjusting the > > > reported maintainer role. After the e-mails are output, the status of > > > subsystems will follow, for example: > > > > > > ... > > > linux-kernel@vger.kernel.org (open list:LIBRARY CODE) > > > LIBRARY CODE status: Supported > > > > > > In order to allow replacing the role rewriting seamlessly, the new > > > option works as follows: > > > > > > - it is automatically enabled when --email and --role are enabled > > > (the defaults include --email and --rolestats which implies --role) > > > > > > - usages with --norolestats e.g. for git's --cc-cmd will thus need no > > > adjustments > > > > > > - the most common Maintained status is not reported at all, to reduce > > > unnecessary noise > > > > > > - THE REST catch-all section (contains lkml) status is not reported > > > > > > - the existing --subsystem and --status options are unaffected so the= ir > > > users will need no adjustments > > > > > > Signed-off-by: Vlastimil Babka > > > > This patch is in next as c1565b6f7b53ea1ea3e757538832e12d7d13d949. It > > breaks one of my scripts that I use to semi-automatically determine > > recipents for patch series. > > > > It works as follows: > > > > $ batch-add-recipents audin-patch-v1/0001-ASoC-meson-HACK-let-A= IU-export-its-clocks-through-cl.patch > > #!/bin/sh > > > > addrecipent \ > > -t "Rob Herring " $(: maintainer:OPEN FIRMWARE= AND FLATTENED DEVICE TREE BINDINGS) \ > > -t "Krzysztof Kozlowski " $(: maintainer:OP= EN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) \ > > -t "Conor Dooley " $(: maintainer:OPEN FIR= MWARE AND FLATTENED DEVICE TREE BINDINGS) \ > > -t "Neil Armstrong " $(: maintainer:= ARM/Amlogic Meson SoC support) \ > > -t "Kevin Hilman " $(: maintainer:ARM/Aml= ogic Meson SoC support) \ > > -c "Jerome Brunet " $(: reviewer:ARM/Amlo= gic Meson SoC support) \ > > -c "Martin Blumenstingl " $= (: reviewer:ARM/Amlogic Meson SoC support) \ > > -t "Liam Girdwood " $(: supporter:SOUND - = SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...) \ > > -t "Mark Brown " $(: supporter:SOUND - SOC = LAYER / DYNAMIC AUDIO POWER MANAGEM...) \ > > -t "Jaroslav Kysela " $(: maintainer:SOUND) \ > > -t "Takashi Iwai " $(: maintainer:SOUND) \ > > -c "devicetree@vger.kernel.org" $(: open list:OPEN FIRMWARE AND= FLATTENED DEVICE TREE BINDINGS) \ > > -c "linux-arm-kernel@lists.infradead.org" $(: moderated list:AR= M/Amlogic Meson SoC support) \ > > -c "linux-amlogic@lists.infradead.org" $(: open list:ARM/Amlogi= c Meson SoC support) \ > > -c "linux-kernel@vger.kernel.org" $(: open list) \ > > -c "linux-sound@vger.kernel.org" $(: open list:SOUND - SOC LAYE= R / DYNAMIC AUDIO POWER MANAGEM...) \ > > audin-patch-v1/0001-ASoC-meson-HACK-let-AIU-export-its-clocks-t= hrough-cl.patch >=20 > Hey, that looks familiar ;-) >=20 > > the output is usually redirected to a file that I edit before running > > it. The additional line in the output of > > > > scripts/get_maintainer.pl audin-patch-v1/0001-ASoC-meson-HACK-l= et-AIU-export-its-clocks-through-cl.patch > > > > with your change breaks that script. >=20 > You forgot to list the additional output? >=20 > I gave it a try with my script, and with one of my own patches. > Example additional output is: >=20 > --cc "ARM/Microchip" $(: AT91] SoC support status: Supported \ > --cc "QAT DRIVER status: Supported \ > --cc "ARM/ASPEED MACHINE SUPPORT status: Supported \ > --cc "MELEXIS MLX90614 DRIVER status: Supported \ > --cc "ARM/NUVOTON MA35 ARCHITECTURE status: Supported \ > --cc "ARM/RISC-V/RENESAS ARCHITECTURE status: Supported \ Is that really your output? No closing ) in the first line and no closing " in the 5 last? For me it's worse(?), I get: $ batch-add-recipents audin-patch-v1/0001-ASoC-meson-HACK-let-AIU-export-i= ts-clocks-through-cl.patch #!/bin/sh addrecipent \ -t "Rob Herring " $(: maintainer:OPEN FIRMWARE AND FLATTE= NED DEVICE TREE BINDINGS) \ -t "Krzysztof Kozlowski " $(: maintainer:OPEN FIRMWARE= AND FLATTENED DEVICE TREE BINDINGS) \ -t "Conor Dooley " $(: maintainer:OPEN FIRMWARE AND F= LATTENED DEVICE TREE BINDINGS) \ -t "Neil Armstrong " $(: maintainer:ARM/Amlogic= Meson SoC support) \ -t "Kevin Hilman " $(: maintainer:ARM/Amlogic Meson = SoC support) \ -c "Jerome Brunet " $(: reviewer:ARM/Amlogic Meson S= oC support) \ -c "Martin Blumenstingl " $(: reviewer= :ARM/Amlogic Meson SoC support) \ -t "Liam Girdwood " $(: maintainer:SOUND - SOC LAYER = / DYNAMIC AUDIO POWER MANAGEM...) \ -t "Mark Brown " $(: maintainer:SOUND - SOC LAYER / DY= NAMIC AUDIO POWER MANAGEM...) \ -t "Jaroslav Kysela " $(: maintainer:SOUND) \ -t "Takashi Iwai " $(: maintainer:SOUND) \ -c "devicetree@vger.kernel.org" $(: open list:OPEN FIRMWARE AND FLATTENED = DEVICE TREE BINDINGS) \ -c "linux-arm-kernel@lists.infradead.org" $(: moderated list:ARM/Amlogic M= eson SoC support) \ -c "linux-amlogic@lists.infradead.org" $(: open list:ARM/Amlogic Meson SoC= support) \ -c "linux-kernel@vger.kernel.org" $(: open list) \ -c "linux-sound@vger.kernel.org" $(: open list:SOUND - SOC LAYER / DYNAMIC= AUDIO POWER MANAGEM...) \ Failed to parse "SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEMENT (ASoC)= status: Supported " at -e line 6, <> line 17. =2E To fix I added next if /^[^@]*status:/; to the perl script that parses get_maintainer.pl's output. =20 > Iff this extra output is good to have, why not include it in the comment > next to the existing entries with the email addresses, so it will be > handled automatically by all scripting on top? That would be great. Best regards Uwe --6nqdwb73tx4ragth Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmeraCoACgkQj4D7WH0S /k7AUAgAqfBMD3p93otDOThtJBmS6zrITLlOU1WFi+kiP7yKBcgVvsHcqS8428l2 fFQt2ewQrZKIxRVuUi95yaWxqre++TXL/y1JtFeaYssAITt+rLuVuHwzlG06/d7/ AO5AG+FHuVgi0kNI3qxK7g5yfWeYSpDHmo/2eXHSsO973X+dcTi7PdY8IYIUk48i vrorh9fBdLS1TzlMnUqzYr8IV832dGDFBYYFMxogPDKLnF8G0J1V3eY7Swhamhia bsMxlkHP8WtzxwAwZl7GS6l5/F0u4gOQ33JbLDoZRDkXYCtv7mOskyIHSpbL6iGe 2vpGPPYW1pxD5kIexkQgzaixa1KDyA== =/YBW -----END PGP SIGNATURE----- --6nqdwb73tx4ragth--