From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Konstantin Ryabitsev" <konstantin@linuxfoundation.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Emily Shaffer" <emilyshaffer@google.com>,
git@vger.kernel.org, jrnieder@gmail.com,
jonathantanmy@google.com, steadmon@google.com,
chooglen@google.com, calvinwan@google.com,
workflows@vger.kernel.org
Subject: Why GitGitGadget does not use Sender:, was Re: Review process improvements
Date: Mon, 10 Jan 2022 14:03:01 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2201101401530.339@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqh7b0juk5.fsf@gitster.g>
Hi Junio,
On Wed, 22 Dec 2021, Junio C Hamano wrote:
> Konstantin Ryabitsev <konstantin@linuxfoundation.org> writes:
>
> > This would require pretending that we're authorized to send mail from the
> > domain name of the commit author, so this unfortunately won't work (and hence
> > the reason why GGG does it this way). E.g. say you have:
> >
> > From: foo@redhat.com
> > Subject: [PATCH] Fix foo
>
> Would it help to use "Sender:"?
You had suggested that before, and I explained why it does not work in
https://lore.kernel.org/git/nycvar.QRO.7.76.6.2008241445200.56@tvgsbejvaqbjf.bet/.
The gist is: GMail interferes with your cunning plan.
> When GGG or any other automation are trying to send e-mail on behalf of
> the person shown on "From:", I thought that it is the mechanism for them
> to use to identify themselves.
Ciao,
Dscho
next prev parent reply other threads:[~2022-01-10 13:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YbvBvch8JcHED+A9@google.com>
2021-12-17 18:39 ` Konstantin Ryabitsev
2021-12-20 10:48 ` Christian Couder
2021-12-20 12:29 ` Mark Brown
2021-12-22 3:26 ` Ævar Arnfjörð Bjarmason
2021-12-22 13:07 ` Fabian Stelzer
2021-12-22 15:45 ` Konstantin Ryabitsev
2021-12-22 19:42 ` Junio C Hamano
2021-12-22 21:32 ` Konstantin Ryabitsev
2022-01-10 13:03 ` Johannes Schindelin [this message]
2022-01-10 17:13 ` Why GitGitGadget does not use Sender:, was " Junio C Hamano
2021-12-23 13:50 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2201101401530.339@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=calvinwan@google.com \
--cc=chooglen@google.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=konstantin@linuxfoundation.org \
--cc=steadmon@google.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox