From: Mark Brown <broonie@kernel.org>
To: Barry Song <21cnbao@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
corbet@lwn.net, workflows@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Barry Song <v-songbaohua@oppo.com>,
Chris Zankel <chris@zankel.net>,
Huacai Chen <chenhuacai@loongson.cn>,
Herbert Xu <herbert@gondor.apana.org.au>,
Guenter Roeck <linux@roeck-us.net>,
Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH] Documentation: coding-style: ask function-like macros to evaluate parameters
Date: Thu, 21 Mar 2024 11:15:18 +0000 [thread overview]
Message-ID: <fb744859-ba2a-41c9-bcfa-4ea1cb8c036a@sirena.org.uk> (raw)
In-Reply-To: <CAGsJ_4y+1HovQ52HPis8NBDqp4-fiGRwehX+NH0New0HoEU5GQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
On Thu, Mar 21, 2024 at 07:48:36AM +1300, Barry Song wrote:
> On Thu, Mar 21, 2024 at 4:49 AM Andrew Morton <akpm@linux-foundation.org> wrote:
> > Stronger than that please. Just tell people not to use macros in such
> > situations. Always code it in C.
> While I appreciate the consistency of always using "static inline"
> instead of macros,
> I've noticed numerous instances of (void) macros throughout the kernel.
...
> I'm uncertain whether people would find it disconcerting if they completely
> deviate from the current approach.
> If you believe it won't pose an issue, I can proceed with v3 to eliminate
> the first option, casting to (void).
It might be worth adding a note somewhere in the file that talks about
how the coding style document is convering the current state of the art
but some files might older and not following the current style. This
isn't going to be the only thing where there'll be issues like this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-21 11:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 0:16 Barry Song
2024-03-20 1:42 ` Stephen Rothwell
2024-03-20 3:24 ` Barry Song
2024-03-20 3:45 ` Stephen Rothwell
2024-03-20 15:49 ` Andrew Morton
2024-03-20 18:48 ` Barry Song
2024-03-21 11:15 ` Mark Brown [this message]
2024-03-21 20:29 ` Barry Song
2024-03-21 17:44 ` Andrew Morton
2024-03-20 23:37 ` Meiyong Yu
2024-03-21 0:11 ` Barry Song
2024-03-21 4:38 ` Meiyong Yu
2024-03-21 7:42 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb744859-ba2a-41c9-bcfa-4ea1cb8c036a@sirena.org.uk \
--to=broonie@kernel.org \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chenhuacai@loongson.cn \
--cc=chris@zankel.net \
--cc=corbet@lwn.net \
--cc=herbert@gondor.apana.org.au \
--cc=jcmvbkbc@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sfr@canb.auug.org.au \
--cc=v-songbaohua@oppo.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox