workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Brian Norris <briannorris@chromium.org>,
	Dwaipayan Ray <dwaipayanray1@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Joe Perches <joe@perches.com>,
	workflows@vger.kernel.org
Subject: Re: [PATCH v2 2/2] docs: checkpatch: Drop networking comment style
Date: Fri, 17 Oct 2025 14:16:26 -0700	[thread overview]
Message-ID: <e4eaf960-b21b-475e-955c-b40f0adbfbf5@infradead.org> (raw)
In-Reply-To: <20251017203719.1554224-2-briannorris@chromium.org>



On 10/17/25 1:37 PM, Brian Norris wrote:
> Networking no longer has their own comment style, and checkpatch no
> longer checks for this.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Suggested-by: Randy Dunlap <rdunlap@infradead.org>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

and for reference:

commit 82b8000c28b5
Author: Johannes Berg <johannes.berg@intel.com>
Date:   Mon Aug 19 11:09:43 2024 +0200
    net: drop special comment style


Thanks.

> ---
> 
> Changes in v2:
>  * new in v2
> 
>  Documentation/dev-tools/checkpatch.rst | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-tools/checkpatch.rst
> index d7fe023b3080..dfaad0a279ff 100644
> --- a/Documentation/dev-tools/checkpatch.rst
> +++ b/Documentation/dev-tools/checkpatch.rst
> @@ -465,13 +465,6 @@ Comments
>         * for multi line comments.
>         */
>  
> -    The networking comment style is a bit different, with the first line
> -    not empty like the former::
> -
> -      /* This is the preferred comment style
> -       * for files in net/ and drivers/net/
> -       */
> -
>      See: https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting
>  
>    **C99_COMMENTS**

-- 
~Randy

  reply	other threads:[~2025-10-17 21:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-17 20:37 [PATCH v2 1/2] docs: checkpatch: Align block " Brian Norris
2025-10-17 20:37 ` [PATCH v2 2/2] docs: checkpatch: Drop networking " Brian Norris
2025-10-17 21:16   ` Randy Dunlap [this message]
2025-10-18  1:31 ` [PATCH v2 1/2] docs: checkpatch: Align block " Joe Perches
2025-10-21 20:42 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4eaf960-b21b-475e-955c-b40f0adbfbf5@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=briannorris@chromium.org \
    --cc=corbet@lwn.net \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox