workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Dmitry Antipov <dmantipov@yandex.ru>,
	Andy Shevchenko <andriy.shevchenko@intel.com>,
	Jonathan Corbet <corbet@lwn.net>
Cc: workflows@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2] doc: development-process: add notice on testing
Date: Thu, 22 Jan 2026 23:19:48 -0800	[thread overview]
Message-ID: <d9147abf-0b08-40e2-aa49-821c953f5fc7@infradead.org> (raw)
In-Reply-To: <20260123071523.1392729-1-dmantipov@yandex.ru>



On 1/22/26 11:15 PM, Dmitry Antipov wrote:
> Add testing notice to "Before creating patches" section.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Andy also Acked it. I think you could/should include
his Ack here as well.

Thanks.

> ---
> v2: adjust spelling and wording according to Randy
> ---
>  Documentation/process/5.Posting.rst | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/process/5.Posting.rst b/Documentation/process/5.Posting.rst
> index 9999bcbdccc9..07d7dbed13ec 100644
> --- a/Documentation/process/5.Posting.rst
> +++ b/Documentation/process/5.Posting.rst
> @@ -40,7 +40,12 @@ sending patches to the development community.  These include:
>   - Test the code to the extent that you can.  Make use of the kernel's
>     debugging tools, ensure that the kernel will build with all reasonable
>     combinations of configuration options, use cross-compilers to build for
> -   different architectures, etc.
> +   different architectures, etc. Add tests, likely using an existing
> +   testing framework like KUnit, and include them as a separate member
> +   of your series (see the next section for more about patch series).
> +   Note that this may be mandatory when affecting some subsystems. For
> +   example, library functions (resides under lib/) are extensively used
> +   almost everywhere and expected to be tested appropriately.
>  
>   - Make sure your code is compliant with the kernel coding style
>     guidelines.

-- 
~Randy

  reply	other threads:[~2026-01-23  7:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22 11:15 [PATCH] " Dmitry Antipov
2026-01-22 11:56 ` Andy Shevchenko
2026-01-22 18:28 ` Randy Dunlap
2026-01-23  7:15   ` [PATCH v2] " Dmitry Antipov
2026-01-23  7:19     ` Randy Dunlap [this message]
2026-01-23 10:50       ` Andy Shevchenko
2026-02-02 17:02     ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9147abf-0b08-40e2-aa49-821c953f5fc7@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=corbet@lwn.net \
    --cc=dmantipov@yandex.ru \
    --cc=linux-doc@vger.kernel.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox