* [PATCH v1 1/1] docs: Update documentation to avoid mentioning of kernel.h
@ 2025-11-26 20:59 Andy Shevchenko
2025-11-26 21:18 ` Randy Dunlap
0 siblings, 1 reply; 12+ messages in thread
From: Andy Shevchenko @ 2025-11-26 20:59 UTC (permalink / raw)
To: Andy Shevchenko, Dr. David Alan Gilbert, linux-doc, linux-kernel,
workflows, linux-remoteproc
Cc: Greg Kroah-Hartman, Rafael J. Wysocki, Danilo Krummrich,
Jonathan Corbet, Dwaipayan Ray, Lukas Bulwahn, Joe Perches,
Bjorn Andersson, Mathieu Poirier
For several years, and still ongoing, the kernel.h is being split
to smaller and narrow headers to avoid "including everything" approach
which is bad in many ways. Since that, documentation missed a few
required updates to align with that work. Do it here.
Note, language translations are left untouched and if anybody willing
to help, please provide path(es) based on the updated English variant.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Documentation/core-api/kobject.rst | 2 +-
Documentation/dev-tools/checkpatch.rst | 2 +-
Documentation/driver-api/basics.rst | 17 ++++++++++++++++-
.../driver-api/driver-model/design-patterns.rst | 2 +-
Documentation/process/coding-style.rst | 10 +++++++---
Documentation/staging/rpmsg.rst | 7 +++++--
6 files changed, 31 insertions(+), 9 deletions(-)
diff --git a/Documentation/core-api/kobject.rst b/Documentation/core-api/kobject.rst
index 7310247310a0..5f6c61bc03bf 100644
--- a/Documentation/core-api/kobject.rst
+++ b/Documentation/core-api/kobject.rst
@@ -78,7 +78,7 @@ just a matter of using the kobj member. Code that works with kobjects will
often have the opposite problem, however: given a struct kobject pointer,
what is the pointer to the containing structure? You must avoid tricks
(such as assuming that the kobject is at the beginning of the structure)
-and, instead, use the container_of() macro, found in ``<linux/kernel.h>``::
+and, instead, use the container_of() macro, found in ``<linux/container_of.h>``::
container_of(ptr, type, member)
diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-tools/checkpatch.rst
index fa2988dd4657..c1dff8e6bccb 100644
--- a/Documentation/dev-tools/checkpatch.rst
+++ b/Documentation/dev-tools/checkpatch.rst
@@ -753,7 +753,7 @@ Macros, Attributes and Symbols
sizeof(foo)/sizeof(foo[0]) for finding number of elements in an
array.
- The macro is defined in include/linux/kernel.h::
+ The macro is defined in include/linux/array_size.h::
#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
diff --git a/Documentation/driver-api/basics.rst b/Documentation/driver-api/basics.rst
index 5e9f7aee71a7..8b6a5888cb11 100644
--- a/Documentation/driver-api/basics.rst
+++ b/Documentation/driver-api/basics.rst
@@ -114,10 +114,25 @@ Kernel objects manipulation
Kernel utility functions
------------------------
-.. kernel-doc:: include/linux/kernel.h
+.. kernel-doc:: include/linux/array_size.h
+ :internal:
+
+.. kernel-doc:: include/linux/container_of.h
+ :internal:
+
+.. kernel-doc:: include/linux/kstrtox.h
:internal:
:no-identifiers: kstrtol kstrtoul
+.. kernel-doc:: include/linux/stddef.h
+ :internal:
+
+.. kernel-doc:: include/linux/util_macros.h
+ :internal:
+
+.. kernel-doc:: include/linux/wordpart.h
+ :internal:
+
.. kernel-doc:: kernel/printk/printk.c
:export:
:no-identifiers: printk
diff --git a/Documentation/driver-api/driver-model/design-patterns.rst b/Documentation/driver-api/driver-model/design-patterns.rst
index 41eb8f41f7dd..965b2b93be6f 100644
--- a/Documentation/driver-api/driver-model/design-patterns.rst
+++ b/Documentation/driver-api/driver-model/design-patterns.rst
@@ -103,7 +103,7 @@ The design pattern is the same for an hrtimer or something similar that will
return a single argument which is a pointer to a struct member in the
callback.
-container_of() is a macro defined in <linux/kernel.h>
+container_of() is a macro defined in <linux/container_of.h>
What container_of() does is to obtain a pointer to the containing struct from
a pointer to a member by a simple subtraction using the offsetof() macro from
diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
index 2969ca378dbb..d63ea0bffdfe 100644
--- a/Documentation/process/coding-style.rst
+++ b/Documentation/process/coding-style.rst
@@ -1070,7 +1070,7 @@ readability.
18) Don't re-invent the kernel macros
-------------------------------------
-The header file include/linux/kernel.h contains a number of macros that
+There many header files in include/linux/ that contain a number of macros that
you should use, rather than explicitly coding some variant of them yourself.
For example, if you need to calculate the length of an array, take advantage
of the macro
@@ -1079,14 +1079,18 @@ of the macro
#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
+which is defined in array_size.h.
+
Similarly, if you need to calculate the size of some structure member, use
.. code-block:: c
#define sizeof_field(t, f) (sizeof(((t*)0)->f))
-There are also min() and max() macros that do strict type checking if you
-need them. Feel free to peruse that header file to see what else is already
+which is defined in stddef.h.
+
+There are also min() and max() macros defined in minmax.h that do strict type checking if you
+need them. Feel free to peruse the header files to see what else is already
defined that you shouldn't reproduce in your code.
diff --git a/Documentation/staging/rpmsg.rst b/Documentation/staging/rpmsg.rst
index 40282cca86ca..42bac1149d9d 100644
--- a/Documentation/staging/rpmsg.rst
+++ b/Documentation/staging/rpmsg.rst
@@ -224,9 +224,12 @@ content to the console.
::
- #include <linux/kernel.h>
+ #include <linux/dev_printk.h>
+ #include <linux/mod_devicetable.h>
#include <linux/module.h>
+ #include <linux/printk.h>
#include <linux/rpmsg.h>
+ #include <linux/types.h>
static void rpmsg_sample_cb(struct rpmsg_channel *rpdev, void *data, int len,
void *priv, u32 src)
@@ -244,7 +247,7 @@ content to the console.
/* send a message on our channel */
err = rpmsg_send(rpdev->ept, "hello!", 6);
if (err) {
- pr_err("rpmsg_send failed: %d\n", err);
+ dev_err(&rpdev->dev, "rpmsg_send failed: %d\n", err);
return err;
}
--
2.50.1
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v1 1/1] docs: Update documentation to avoid mentioning of kernel.h
2025-11-26 20:59 [PATCH v1 1/1] docs: Update documentation to avoid mentioning of kernel.h Andy Shevchenko
@ 2025-11-26 21:18 ` Randy Dunlap
2025-11-26 21:24 ` Andy Shevchenko
0 siblings, 1 reply; 12+ messages in thread
From: Randy Dunlap @ 2025-11-26 21:18 UTC (permalink / raw)
To: Andy Shevchenko, Dr. David Alan Gilbert, linux-doc, linux-kernel,
workflows, linux-remoteproc
Cc: Greg Kroah-Hartman, Rafael J. Wysocki, Danilo Krummrich,
Jonathan Corbet, Dwaipayan Ray, Lukas Bulwahn, Joe Perches,
Bjorn Andersson, Mathieu Poirier
On 11/26/25 12:59 PM, Andy Shevchenko wrote:
> For several years, and still ongoing, the kernel.h is being split
> to smaller and narrow headers to avoid "including everything" approach
> which is bad in many ways. Since that, documentation missed a few
> required updates to align with that work. Do it here.
>
> Note, language translations are left untouched and if anybody willing
> to help, please provide path(es) based on the updated English variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> Documentation/core-api/kobject.rst | 2 +-
> Documentation/dev-tools/checkpatch.rst | 2 +-
> Documentation/driver-api/basics.rst | 17 ++++++++++++++++-
> .../driver-api/driver-model/design-patterns.rst | 2 +-
> Documentation/process/coding-style.rst | 10 +++++++---
> Documentation/staging/rpmsg.rst | 7 +++++--
> 6 files changed, 31 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
> index 2969ca378dbb..d63ea0bffdfe 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -1070,7 +1070,7 @@ readability.
> 18) Don't re-invent the kernel macros
> -------------------------------------
>
> -The header file include/linux/kernel.h contains a number of macros that
> +There many header files in include/linux/ that contain a number of macros that
There are many
> you should use, rather than explicitly coding some variant of them yourself.
> For example, if you need to calculate the length of an array, take advantage
> of the macro
Otherwise LGTM. Thanks.
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/1] docs: Update documentation to avoid mentioning of kernel.h
2025-11-26 21:18 ` Randy Dunlap
@ 2025-11-26 21:24 ` Andy Shevchenko
2025-11-26 21:33 ` Randy Dunlap
0 siblings, 1 reply; 12+ messages in thread
From: Andy Shevchenko @ 2025-11-26 21:24 UTC (permalink / raw)
To: Randy Dunlap
Cc: Dr. David Alan Gilbert, linux-doc, linux-kernel, workflows,
linux-remoteproc, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich, Jonathan Corbet, Dwaipayan Ray, Lukas Bulwahn,
Joe Perches, Bjorn Andersson, Mathieu Poirier
On Wed, Nov 26, 2025 at 01:18:29PM -0800, Randy Dunlap wrote:
> On 11/26/25 12:59 PM, Andy Shevchenko wrote:
...
> > -The header file include/linux/kernel.h contains a number of macros that
> > +There many header files in include/linux/ that contain a number of macros that
>
> There are many
>
> > you should use, rather than explicitly coding some variant of them yourself.
> > For example, if you need to calculate the length of an array, take advantage
> > of the macro
>
> Otherwise LGTM. Thanks.
>
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks!
Can you also test it? I hope it will be not so broken (as some of the files
seems never were before in the generated docs).
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/1] docs: Update documentation to avoid mentioning of kernel.h
2025-11-26 21:24 ` Andy Shevchenko
@ 2025-11-26 21:33 ` Randy Dunlap
2025-11-26 21:36 ` Randy Dunlap
2025-11-26 21:37 ` Andy Shevchenko
0 siblings, 2 replies; 12+ messages in thread
From: Randy Dunlap @ 2025-11-26 21:33 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Dr. David Alan Gilbert, linux-doc, linux-kernel, workflows,
linux-remoteproc, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich, Jonathan Corbet, Dwaipayan Ray, Lukas Bulwahn,
Joe Perches, Bjorn Andersson, Mathieu Poirier
On 11/26/25 1:24 PM, Andy Shevchenko wrote:
> On Wed, Nov 26, 2025 at 01:18:29PM -0800, Randy Dunlap wrote:
>> On 11/26/25 12:59 PM, Andy Shevchenko wrote:
>
> ...
>
>>> -The header file include/linux/kernel.h contains a number of macros that
>>> +There many header files in include/linux/ that contain a number of macros that
>>
>> There are many
>>
>>> you should use, rather than explicitly coding some variant of them yourself.
>>> For example, if you need to calculate the length of an array, take advantage
>>> of the macro
>>
>> Otherwise LGTM. Thanks.
>>
>> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks!
>
> Can you also test it? I hope it will be not so broken (as some of the files
> seems never were before in the generated docs).
It's not completely happy:
linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:125: ERROR: Unexpected indentation. [docutils]
linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:123: WARNING: Inline emphasis start-string without end-string. [docutils]
linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:126: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:130: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils]
--
~Randy
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/1] docs: Update documentation to avoid mentioning of kernel.h
2025-11-26 21:33 ` Randy Dunlap
@ 2025-11-26 21:36 ` Randy Dunlap
2025-11-26 21:42 ` Andy Shevchenko
2025-11-26 21:37 ` Andy Shevchenko
1 sibling, 1 reply; 12+ messages in thread
From: Randy Dunlap @ 2025-11-26 21:36 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Dr. David Alan Gilbert, linux-doc, linux-kernel, workflows,
linux-remoteproc, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich, Jonathan Corbet, Dwaipayan Ray, Lukas Bulwahn,
Joe Perches, Bjorn Andersson, Mathieu Poirier
On 11/26/25 1:33 PM, Randy Dunlap wrote:
>
>
> On 11/26/25 1:24 PM, Andy Shevchenko wrote:
>> On Wed, Nov 26, 2025 at 01:18:29PM -0800, Randy Dunlap wrote:
>>> On 11/26/25 12:59 PM, Andy Shevchenko wrote:
>>
>> ...
>>
>>>> -The header file include/linux/kernel.h contains a number of macros that
>>>> +There many header files in include/linux/ that contain a number of macros that
>>>
>>> There are many
>>>
>>>> you should use, rather than explicitly coding some variant of them yourself.
>>>> For example, if you need to calculate the length of an array, take advantage
>>>> of the macro
>>>
>>> Otherwise LGTM. Thanks.
>>>
>>> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
>>
>> Thanks!
>>
>> Can you also test it? I hope it will be not so broken (as some of the files
>> seems never were before in the generated docs).
>
> It's not completely happy:
>
> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:125: ERROR: Unexpected indentation. [docutils]
> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:123: WARNING: Inline emphasis start-string without end-string. [docutils]
> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:126: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:130: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils]
>
>
This little change fixes it for me. Just include it in your patch, please.
---
include/linux/util_macros.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20251126.orig/include/linux/util_macros.h
+++ linux-next-20251126/include/linux/util_macros.h
@@ -119,7 +119,7 @@
* a fuss about it. This makes the programmer responsible for tagging
* the functions that can be garbage-collected.
*
- * With the macro it is possible to write the following:
+ * With the macro it is possible to write the following::
*
* static int foo_suspend(struct device *dev)
* {
--
~Randy
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v1 1/1] docs: Update documentation to avoid mentioning of kernel.h
2025-11-26 21:36 ` Randy Dunlap
@ 2025-11-26 21:42 ` Andy Shevchenko
2025-11-26 21:46 ` Randy Dunlap
0 siblings, 1 reply; 12+ messages in thread
From: Andy Shevchenko @ 2025-11-26 21:42 UTC (permalink / raw)
To: Randy Dunlap
Cc: Dr. David Alan Gilbert, linux-doc, linux-kernel, workflows,
linux-remoteproc, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich, Jonathan Corbet, Dwaipayan Ray, Lukas Bulwahn,
Joe Perches, Bjorn Andersson, Mathieu Poirier
On Wed, Nov 26, 2025 at 01:36:44PM -0800, Randy Dunlap wrote:
> On 11/26/25 1:33 PM, Randy Dunlap wrote:
> > On 11/26/25 1:24 PM, Andy Shevchenko wrote:
> >> On Wed, Nov 26, 2025 at 01:18:29PM -0800, Randy Dunlap wrote:
> >>> On 11/26/25 12:59 PM, Andy Shevchenko wrote:
...
> >>>> -The header file include/linux/kernel.h contains a number of macros that
> >>>> +There many header files in include/linux/ that contain a number of macros that
> >>>
> >>> There are many
> >>>
> >>>> you should use, rather than explicitly coding some variant of them yourself.
> >>>> For example, if you need to calculate the length of an array, take advantage
> >>>> of the macro
> >>>
> >>> Otherwise LGTM. Thanks.
> >>>
> >>> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> >>
> >> Thanks!
> >>
> >> Can you also test it? I hope it will be not so broken (as some of the files
> >> seems never were before in the generated docs).
> >
> > It's not completely happy:
> >
> > linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:125: ERROR: Unexpected indentation. [docutils]
> > linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:123: WARNING: Inline emphasis start-string without end-string. [docutils]
> > linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:126: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
> > linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:130: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils]
> >
>
> This little change fixes it for me. Just include it in your patch, please.
Thanks, just 15 sec before your message I guessed the same fix.
> ---
> include/linux/util_macros.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20251126.orig/include/linux/util_macros.h
> +++ linux-next-20251126/include/linux/util_macros.h
> @@ -119,7 +119,7 @@
> * a fuss about it. This makes the programmer responsible for tagging
> * the functions that can be garbage-collected.
> *
> - * With the macro it is possible to write the following:
> + * With the macro it is possible to write the following::
> *
> * static int foo_suspend(struct device *dev)
> * {
Since it's like this, I just fix both places you pointed out and issue a v2.
May I have ypour Tested-by ten?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v1 1/1] docs: Update documentation to avoid mentioning of kernel.h
2025-11-26 21:42 ` Andy Shevchenko
@ 2025-11-26 21:46 ` Randy Dunlap
2025-11-26 21:49 ` Andy Shevchenko
0 siblings, 1 reply; 12+ messages in thread
From: Randy Dunlap @ 2025-11-26 21:46 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Dr. David Alan Gilbert, linux-doc, linux-kernel, workflows,
linux-remoteproc, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich, Jonathan Corbet, Dwaipayan Ray, Lukas Bulwahn,
Joe Perches, Bjorn Andersson, Mathieu Poirier
On 11/26/25 1:42 PM, Andy Shevchenko wrote:
> On Wed, Nov 26, 2025 at 01:36:44PM -0800, Randy Dunlap wrote:
>> On 11/26/25 1:33 PM, Randy Dunlap wrote:
>>> On 11/26/25 1:24 PM, Andy Shevchenko wrote:
>>>> On Wed, Nov 26, 2025 at 01:18:29PM -0800, Randy Dunlap wrote:
>>>>> On 11/26/25 12:59 PM, Andy Shevchenko wrote:
>
> ...
>
>>>>>> -The header file include/linux/kernel.h contains a number of macros that
>>>>>> +There many header files in include/linux/ that contain a number of macros that
>>>>>
>>>>> There are many
>>>>>
>>>>>> you should use, rather than explicitly coding some variant of them yourself.
>>>>>> For example, if you need to calculate the length of an array, take advantage
>>>>>> of the macro
>>>>>
>>>>> Otherwise LGTM. Thanks.
>>>>>
>>>>> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
>>>>
>>>> Thanks!
>>>>
>>>> Can you also test it? I hope it will be not so broken (as some of the files
>>>> seems never were before in the generated docs).
>>>
>>> It's not completely happy:
>>>
>>> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:125: ERROR: Unexpected indentation. [docutils]
>>> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:123: WARNING: Inline emphasis start-string without end-string. [docutils]
>>> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:126: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
>>> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:130: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils]
>>>
>>
>> This little change fixes it for me. Just include it in your patch, please.
>
> Thanks, just 15 sec before your message I guessed the same fix.
>
>> ---
>> include/linux/util_macros.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20251126.orig/include/linux/util_macros.h
>> +++ linux-next-20251126/include/linux/util_macros.h
>> @@ -119,7 +119,7 @@
>> * a fuss about it. This makes the programmer responsible for tagging
>> * the functions that can be garbage-collected.
>> *
>> - * With the macro it is possible to write the following:
>> + * With the macro it is possible to write the following::
>> *
>> * static int foo_suspend(struct device *dev)
>> * {
>
> Since it's like this, I just fix both places you pointed out and issue a v2.
> May I have ypour Tested-by ten?
Yes.
Tested-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v1 1/1] docs: Update documentation to avoid mentioning of kernel.h
2025-11-26 21:46 ` Randy Dunlap
@ 2025-11-26 21:49 ` Andy Shevchenko
0 siblings, 0 replies; 12+ messages in thread
From: Andy Shevchenko @ 2025-11-26 21:49 UTC (permalink / raw)
To: Randy Dunlap
Cc: Dr. David Alan Gilbert, linux-doc, linux-kernel, workflows,
linux-remoteproc, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich, Jonathan Corbet, Dwaipayan Ray, Lukas Bulwahn,
Joe Perches, Bjorn Andersson, Mathieu Poirier
On Wed, Nov 26, 2025 at 01:46:05PM -0800, Randy Dunlap wrote:
> On 11/26/25 1:42 PM, Andy Shevchenko wrote:
...
> > Since it's like this, I just fix both places you pointed out and issue a v2.
> > May I have ypour Tested-by ten?
>
> Yes.
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks, but I have just sent it out, please reply there.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/1] docs: Update documentation to avoid mentioning of kernel.h
2025-11-26 21:33 ` Randy Dunlap
2025-11-26 21:36 ` Randy Dunlap
@ 2025-11-26 21:37 ` Andy Shevchenko
2025-11-26 21:39 ` Randy Dunlap
2025-11-26 21:39 ` Andy Shevchenko
1 sibling, 2 replies; 12+ messages in thread
From: Andy Shevchenko @ 2025-11-26 21:37 UTC (permalink / raw)
To: Randy Dunlap
Cc: Dr. David Alan Gilbert, linux-doc, linux-kernel, workflows,
linux-remoteproc, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich, Jonathan Corbet, Dwaipayan Ray, Lukas Bulwahn,
Joe Perches, Bjorn Andersson, Mathieu Poirier
On Wed, Nov 26, 2025 at 01:33:13PM -0800, Randy Dunlap wrote:
> On 11/26/25 1:24 PM, Andy Shevchenko wrote:
> > On Wed, Nov 26, 2025 at 01:18:29PM -0800, Randy Dunlap wrote:
> >> On 11/26/25 12:59 PM, Andy Shevchenko wrote:
...
> >>> -The header file include/linux/kernel.h contains a number of macros that
> >>> +There many header files in include/linux/ that contain a number of macros that
> >>
> >> There are many
> >>
> >>> you should use, rather than explicitly coding some variant of them yourself.
> >>> For example, if you need to calculate the length of an array, take advantage
> >>> of the macro
> >>
> >> Otherwise LGTM. Thanks.
> >>
> >> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> >
> > Thanks!
> >
> > Can you also test it? I hope it will be not so broken (as some of the files
> > seems never were before in the generated docs).
>
> It's not completely happy:
A-ha, thanks for trying!
> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:125: ERROR: Unexpected indentation. [docutils]
> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:123: WARNING: Inline emphasis start-string without end-string. [docutils]
> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:126: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:130: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils]
I will look at it tomorrow, but can you remove this (or even fix) and check the
rest meanwhile?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/1] docs: Update documentation to avoid mentioning of kernel.h
2025-11-26 21:37 ` Andy Shevchenko
@ 2025-11-26 21:39 ` Randy Dunlap
2025-11-26 21:39 ` Andy Shevchenko
1 sibling, 0 replies; 12+ messages in thread
From: Randy Dunlap @ 2025-11-26 21:39 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Dr. David Alan Gilbert, linux-doc, linux-kernel, workflows,
linux-remoteproc, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich, Jonathan Corbet, Dwaipayan Ray, Lukas Bulwahn,
Joe Perches, Bjorn Andersson, Mathieu Poirier
On 11/26/25 1:37 PM, Andy Shevchenko wrote:
> On Wed, Nov 26, 2025 at 01:33:13PM -0800, Randy Dunlap wrote:
>> On 11/26/25 1:24 PM, Andy Shevchenko wrote:
>>> On Wed, Nov 26, 2025 at 01:18:29PM -0800, Randy Dunlap wrote:
>>>> On 11/26/25 12:59 PM, Andy Shevchenko wrote:
>
> ...
>
>>>>> -The header file include/linux/kernel.h contains a number of macros that
>>>>> +There many header files in include/linux/ that contain a number of macros that
>>>>
>>>> There are many
>>>>
>>>>> you should use, rather than explicitly coding some variant of them yourself.
>>>>> For example, if you need to calculate the length of an array, take advantage
>>>>> of the macro
>>>>
>>>> Otherwise LGTM. Thanks.
>>>>
>>>> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
>>>
>>> Thanks!
>>>
>>> Can you also test it? I hope it will be not so broken (as some of the files
>>> seems never were before in the generated docs).
>>
>> It's not completely happy:
>
> A-ha, thanks for trying!
>
>> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:125: ERROR: Unexpected indentation. [docutils]
>> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:123: WARNING: Inline emphasis start-string without end-string. [docutils]
>> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:126: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
>> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:130: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils]
>
>
> I will look at it tomorrow, but can you remove this (or even fix) and check the
> rest meanwhile?
That was the only docs warnings caused by your patch (at least in my testing).
and now easily fixed.
--
~Randy
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/1] docs: Update documentation to avoid mentioning of kernel.h
2025-11-26 21:37 ` Andy Shevchenko
2025-11-26 21:39 ` Randy Dunlap
@ 2025-11-26 21:39 ` Andy Shevchenko
2025-11-26 21:40 ` Randy Dunlap
1 sibling, 1 reply; 12+ messages in thread
From: Andy Shevchenko @ 2025-11-26 21:39 UTC (permalink / raw)
To: Randy Dunlap
Cc: Dr. David Alan Gilbert, linux-doc, linux-kernel, workflows,
linux-remoteproc, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich, Jonathan Corbet, Dwaipayan Ray, Lukas Bulwahn,
Joe Perches, Bjorn Andersson, Mathieu Poirier
On Wed, Nov 26, 2025 at 11:37:40PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 26, 2025 at 01:33:13PM -0800, Randy Dunlap wrote:
> > On 11/26/25 1:24 PM, Andy Shevchenko wrote:
> > > On Wed, Nov 26, 2025 at 01:18:29PM -0800, Randy Dunlap wrote:
> > >> On 11/26/25 12:59 PM, Andy Shevchenko wrote:
...
> > >>> -The header file include/linux/kernel.h contains a number of macros that
> > >>> +There many header files in include/linux/ that contain a number of macros that
> > >>
> > >> There are many
> > >>
> > >>> you should use, rather than explicitly coding some variant of them yourself.
> > >>> For example, if you need to calculate the length of an array, take advantage
> > >>> of the macro
> > >>
> > >> Otherwise LGTM. Thanks.
> > >>
> > >> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> > >
> > > Thanks!
> > >
> > > Can you also test it? I hope it will be not so broken (as some of the files
> > > seems never were before in the generated docs).
> >
> > It's not completely happy:
>
> A-ha, thanks for trying!
>
> > linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:125: ERROR: Unexpected indentation. [docutils]
> > linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:123: WARNING: Inline emphasis start-string without end-string. [docutils]
> > linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:126: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
> > linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:130: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils]
>
>
> I will look at it tomorrow, but can you remove this (or even fix) and check the
> rest meanwhile?
At glance seems like colon is missing, should be :: instead of : in near lines.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/1] docs: Update documentation to avoid mentioning of kernel.h
2025-11-26 21:39 ` Andy Shevchenko
@ 2025-11-26 21:40 ` Randy Dunlap
0 siblings, 0 replies; 12+ messages in thread
From: Randy Dunlap @ 2025-11-26 21:40 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Dr. David Alan Gilbert, linux-doc, linux-kernel, workflows,
linux-remoteproc, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich, Jonathan Corbet, Dwaipayan Ray, Lukas Bulwahn,
Joe Perches, Bjorn Andersson, Mathieu Poirier
On 11/26/25 1:39 PM, Andy Shevchenko wrote:
> On Wed, Nov 26, 2025 at 11:37:40PM +0200, Andy Shevchenko wrote:
>> On Wed, Nov 26, 2025 at 01:33:13PM -0800, Randy Dunlap wrote:
>>> On 11/26/25 1:24 PM, Andy Shevchenko wrote:
>>>> On Wed, Nov 26, 2025 at 01:18:29PM -0800, Randy Dunlap wrote:
>>>>> On 11/26/25 12:59 PM, Andy Shevchenko wrote:
>
> ...
>
>>>>>> -The header file include/linux/kernel.h contains a number of macros that
>>>>>> +There many header files in include/linux/ that contain a number of macros that
>>>>>
>>>>> There are many
>>>>>
>>>>>> you should use, rather than explicitly coding some variant of them yourself.
>>>>>> For example, if you need to calculate the length of an array, take advantage
>>>>>> of the macro
>>>>>
>>>>> Otherwise LGTM. Thanks.
>>>>>
>>>>> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
>>>>
>>>> Thanks!
>>>>
>>>> Can you also test it? I hope it will be not so broken (as some of the files
>>>> seems never were before in the generated docs).
>>>
>>> It's not completely happy:
>>
>> A-ha, thanks for trying!
>>
>>> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:125: ERROR: Unexpected indentation. [docutils]
>>> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:123: WARNING: Inline emphasis start-string without end-string. [docutils]
>>> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:126: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
>>> linux-next-20251126/Documentation/driver-api/basics:130: ../include/linux/util_macros.h:130: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils]
>>
>>
>> I will look at it tomorrow, but can you remove this (or even fix) and check the
>> rest meanwhile?
>
> At glance seems like colon is missing, should be :: instead of : in near lines.
>
Yes, that's what I sent earlier :)
--
~Randy
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2025-11-26 21:49 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-26 20:59 [PATCH v1 1/1] docs: Update documentation to avoid mentioning of kernel.h Andy Shevchenko
2025-11-26 21:18 ` Randy Dunlap
2025-11-26 21:24 ` Andy Shevchenko
2025-11-26 21:33 ` Randy Dunlap
2025-11-26 21:36 ` Randy Dunlap
2025-11-26 21:42 ` Andy Shevchenko
2025-11-26 21:46 ` Randy Dunlap
2025-11-26 21:49 ` Andy Shevchenko
2025-11-26 21:37 ` Andy Shevchenko
2025-11-26 21:39 ` Randy Dunlap
2025-11-26 21:39 ` Andy Shevchenko
2025-11-26 21:40 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox