workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Leonardo Brás" <leobras.c@gmail.com>
To: Nicolas Dufresne <nicolas.dufresne@collabora.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Vignesh Raman <vignesh.raman@collabora.com>,
	kernelci@lists.linux.dev,  linuxtv-ci@linuxtv.org,
	dave.pigott@collabora.com, mripard@kernel.org,
	 linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 linux-kselftest@vger.kernel.org, pawiecz@collabora.com,
	 tales.aparecida@gmail.com, workflows@vger.kernel.org,
	kunit-dev@googlegroups.com, 	nfraprado@collabora.com,
	davidgow@google.com, cocci@inria.fr, 	Julia.Lawall@inria.fr,
	kernel@collabora.com, torvalds@linuxfoundation.org,
		gregkh@linuxfoundation.org, daniels@collabora.com,
	shreeya.patel@collabora.com, 	denys.f@collabora.com,
	louis.chauvet@bootlin.com, hamohammed.sa@gmail.com,
		melissa.srw@gmail.com, simona@ffwll.ch, airlied@gmail.com,
	Tim.Bird@sony.com, 	broonie@kernel.org, groeck@google.com,
	rdunlap@infradead.org, geert@linux-m68k.org,
	 michel.daenzer@mailbox.org, sakari.ailus@iki.fi,
	jarkko@kernel.org
Subject: Re: [PATCH v2 0/5] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing
Date: Fri, 24 Jan 2025 18:12:24 -0300	[thread overview]
Message-ID: <bd37528d1c704951cb86a751a5c81e4c76962f51.camel@gmail.com> (raw)
In-Reply-To: <f1c73327073c98ade56dfeabf629e2f9cd7d1663.camel@collabora.com>

On Fri, 2025-01-24 at 10:45 -0500, Nicolas Dufresne wrote:
> Le vendredi 24 janvier 2025 à 15:00 +0200, Laurent Pinchart a écrit :
> > On Fri, Jan 24, 2025 at 01:52:03PM +0100, Mauro Carvalho Chehab wrote:
> > > Em Fri, 24 Jan 2025 10:12:50 +0200 Laurent Pinchart escreveu:
> > > 
> > > > > It's been a few years since I first thought on finding a good way of helping
> > > > > kernel developers testing their patches, while making use of the free runner
> > > > > minutes Gitlab offers. It can greatly simplify the testing for people who are
> > > > > new to kernel development, or students trying to understand it better.
> > > > > 
> > > > > And this patchset allows that to happen :)
> > > > > 
> > > > > Actually, I spoke to Helen last year, and to enable it to run on the free
> > > > > Gitlab-CI runners, there is a small extra patch which is needed:
> > > > > 
> > > > > https://lore.kernel.org/all/20240327013055.139494-2-leobras@redhat.com/  
> > > 
> > > Sounds interesting!
> > > 
> > > > Gitlab as an open-source software project (the community edition) is one
> > > > thing, but can we please avoid advertising specific proprietary services
> > > > in the kernel documentation ?
> > > 
> > > Every time Gitlab is mentioned, the brand of the company that
> > > developed it and has been providing proprietary services is also
> > > advertised. If you're not happy with that, you should move to use
> > > a git forge developed by some open source community.
> > 
> > I'm fine mentioning the gitlab community edition, I'm not fine
> > advertising gitlab.com SaaS in the kernel source tree.

Hello Laurent,

I see your point, and I see no issue on removing the two last lines of CI_TAGS
documentation.

I just added this information on documentation because the default runner used
for the Free Tier of Gitlab does not work for this CI, as it needs more
resources to run. This information can be added on some other place, but at the
time I thought it would be ok to let it be there. 
This other runner I mentioned in the patch is also available on the Free Tier
(free as in beer).

I would like to make it clear that I have no connection/affiliation to Gitlab,
other than a free account in their system, which I use for some CI. I have no
interest on advertising anything from them.

My only objective is to make it easier to hobbyists/beginners to use those
available free minutes to test some change before sending the patch, if they
think that's valuable.

> 
> I've just looked attentively, the intention is just to explain you may need to
> set gitlab variable in your project fork in order to select correctly sized
> sized runners in your own instance.

That's correct

>  Its is not strictly about commercial gitlab.com instance. 

Exactly, the change is about being able to choose the runner you want.

> The default only works with the original project used
> instance (which is not gitlab.com as far as I know), but the comment refer to
> companies that will choose gitlab.com internally to reduce their IT cost.

Correct.
Companies can benefit on that, but my focus was on hobbyist (or begginers) who
may want to test their patches on free CI before sending them to the ML.

> 
> Its quite a stretch to call this "advertisement", that makes it looks very
> dramatic. I personally believe its quite ahead of most other gitlab CI to take
> into consideration running these pipelines on foreign (to the project)
> instances.
> 
> Nicolas

Thank you!
Leo

> 
> > 
> > > The way I see, the best would be if the CI integration could work
> > > with more than one type of forge and being able to use any
> > > free Git??b-CI runners that would be available for developers to
> > > use, as this would allow testing more subsystems with CI, thus
> > > increasing code quality.
> > 
> 


  reply	other threads:[~2025-01-24 21:12 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 13:53 Vignesh Raman
2025-01-23 13:53 ` [PATCH v2 1/5] " Vignesh Raman
2025-01-23 13:53 ` [PATCH v2 2/5] MAINTAINERS: Add an entry for ci automated testing Vignesh Raman
2025-01-23 13:53 ` [PATCH v2 3/5] kci-gitlab: Add drm scenario Vignesh Raman
2025-01-23 20:06   ` Simona Vetter
2025-01-24 12:37     ` Helen Mae Koike Fornazier
2025-01-24 15:31       ` Simona Vetter
2025-01-27  4:07         ` Vignesh Raman
2025-01-23 13:53 ` [PATCH v2 4/5] kci-gitlab: Add documentation Vignesh Raman
2025-01-23 13:53 ` [PATCH v2 5/5] kci-gitlab: docs: Add images Vignesh Raman
2025-01-23 15:46   ` Linus Torvalds
2025-01-23 18:04     ` Nicolas Dufresne
2025-01-27  3:56     ` Vignesh Raman
2025-01-23 21:30 ` [PATCH v2 0/5] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing Jarkko Sakkinen
2025-01-23 21:31   ` Jarkko Sakkinen
2025-01-24 12:58   ` Nikolai Kondrashov
2025-01-24 16:32     ` Jarkko Sakkinen
2025-01-24 17:04       ` Nikolai Kondrashov
2025-01-24 17:15       ` Mark Brown
2025-01-24 17:34       ` Laurent Pinchart
2025-01-24  5:11 ` Leonardo Brás
2025-01-24  8:12   ` Laurent Pinchart
2025-01-24 12:16     ` Jarkko Sakkinen
2025-01-24 13:00       ` Nikolai Kondrashov
2025-01-24 14:26         ` Nicolas Dufresne
2025-01-24 15:29           ` Mauro Carvalho Chehab
2025-01-24 19:49             ` Helen Mae Koike Fornazier
2025-01-24 19:59               ` Bird, Tim
2025-01-27  6:39               ` Mauro Carvalho Chehab
2025-01-24 16:36         ` Jarkko Sakkinen
2025-01-24 12:52     ` Mauro Carvalho Chehab
2025-01-24 13:00       ` Laurent Pinchart
2025-01-24 15:45         ` Nicolas Dufresne
2025-01-24 21:12           ` Leonardo Brás [this message]
2025-01-27  6:07             ` Laurent Pinchart
2025-01-27  7:07               ` Mauro Carvalho Chehab
2025-01-27 14:43               ` Nicolas Dufresne
2025-01-27 16:23                 ` Laurent Pinchart
2025-01-24 20:50       ` Leonardo Brás
2025-01-27  7:32     ` Vignesh Raman
2025-01-27 19:05       ` Leonardo Brás
2025-01-29  9:32         ` Vignesh Raman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd37528d1c704951cb86a751a5c81e4c76962f51.camel@gmail.com \
    --to=leobras.c@gmail.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=Tim.Bird@sony.com \
    --cc=airlied@gmail.com \
    --cc=broonie@kernel.org \
    --cc=cocci@inria.fr \
    --cc=daniels@collabora.com \
    --cc=dave.pigott@collabora.com \
    --cc=davidgow@google.com \
    --cc=denys.f@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck@google.com \
    --cc=hamohammed.sa@gmail.com \
    --cc=jarkko@kernel.org \
    --cc=kernel@collabora.com \
    --cc=kernelci@lists.linux.dev \
    --cc=kunit-dev@googlegroups.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linuxtv-ci@linuxtv.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=melissa.srw@gmail.com \
    --cc=michel.daenzer@mailbox.org \
    --cc=mripard@kernel.org \
    --cc=nfraprado@collabora.com \
    --cc=nicolas.dufresne@collabora.com \
    --cc=pawiecz@collabora.com \
    --cc=rdunlap@infradead.org \
    --cc=sakari.ailus@iki.fi \
    --cc=shreeya.patel@collabora.com \
    --cc=simona@ffwll.ch \
    --cc=tales.aparecida@gmail.com \
    --cc=torvalds@linuxfoundation.org \
    --cc=vignesh.raman@collabora.com \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox