workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Sasha Levin <sashal@kernel.org>, dan.j.williams@intel.com
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
	Kees Cook <kees@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Miguel Ojeda <ojeda@kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	SeongJae Park <sj@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Simon Glass <simon.glass@canonical.com>,
	NeilBrown <neilb@ownmail.net>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Theodore Ts'o <tytso@mit.edu>, Jonathan Corbet <corbet@lwn.net>,
	Vlastimil Babka <vbabka@suse.cz>,
	workflows@vger.kernel.org,  ksummit@lists.linux.dev
Subject: Re: [PATCH] [v5] Documentation: Provide guidelines for tool-generated content
Date: Tue, 13 Jan 2026 14:33:17 -0500	[thread overview]
Message-ID: <bccb32aa305a1bba9502348bafede6d145381605.camel@HansenPartnership.com> (raw)
In-Reply-To: <aWaSQsl8h2wnBjzj@laps>

On Tue, 2026-01-13 at 13:43 -0500, Sasha Levin wrote:
> On Tue, Jan 13, 2026 at 10:20:44AM -0800,
> dan.j.williams@intel.com wrote:
[...]
> > So a simple rule of "generally you should be able to demonstrate
> > the ability to substantively review a contribution of similar
> > complexity before expecting the kernel community to engage in
> > earnest" mitigates the asymmetric threat of AI contributions *and*
> > contributors that have not built-up enough trust capital with their
> > upstream maintainer.
> 
> Looking at recent history (v6.12..v6.18) we had 1902 authors (a third
> of overall contributors) who contributed a single commit. Out of
> those 1902, only 177 have a Reviewed-by tag pointing to them.
> 
> With a rule like the above, 1700+ contributors would have not been
> able to send their patch in.

It's not just that.  Even today Reviewed-by: doesn't always mean the
subject of the tag actually understood it.  We do see a lot of patches
(particularly drivers from companies) that come to the lists  with
fully formed reviewed-by tags and no backing record.  Trying to
institute a reviewed-by requirement would drastically exacerbate this
and, even worse, produce a large uptick in pseudo reviews from people
trying to get the tag to submit.

Speaking as a drive by committer with quite a body of work, the worst
projects to come to are those with artificial worthiness metrics (like
n reviews or stars or github badges or whatever).  Even if you can be
bothered to get over the hump, whatever you did is usually irrelevant
to the patch you want to submit.

The best indication that a committer understood what they were touching
should be in the change log.  If they understand the system under
patch, they should be able to explain clearly why the patch is needed
and what its effects are.

Regards,

James


  parent reply	other threads:[~2026-01-13 19:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13  0:06 Dave Hansen
2026-01-13  5:30 ` Dan Carpenter
2026-01-13  9:28   ` Lorenzo Stoakes
2026-01-13 18:20   ` Dave Hansen
2026-01-13 18:20   ` dan.j.williams
2026-01-13 18:43     ` Sasha Levin
2026-01-13 18:50       ` dan.j.williams
2026-01-13 21:03         ` Alexei Starovoitov
2026-01-13 19:33       ` James Bottomley [this message]
2026-01-13 22:44       ` Steven Rostedt
2026-01-13  9:09 ` Lorenzo Stoakes
2026-01-13 10:36 ` Lee Jones
2026-01-13 18:05   ` Dave Hansen
2026-01-13 18:55     ` Geert Uytterhoeven
2026-01-15 15:04     ` Lee Jones
2026-01-13 19:22 ` Jonathan Corbet
2026-01-19 19:57   ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bccb32aa305a1bba9502348bafede6d145381605.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=corbet@lwn.net \
    --cc=dan.carpenter@linaro.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kees@kernel.org \
    --cc=ksummit@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mcgrof@kernel.org \
    --cc=neilb@ownmail.net \
    --cc=ojeda@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sashal@kernel.org \
    --cc=shuah@kernel.org \
    --cc=simon.glass@canonical.com \
    --cc=sj@kernel.org \
    --cc=tytso@mit.edu \
    --cc=vbabka@suse.cz \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox