From: Joe Perches <joe@perches.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Andy Whitcroft <apw@canonical.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: allow correctly handle full files on stdin
Date: Thu, 26 Mar 2026 01:46:49 -0700 [thread overview]
Message-ID: <bb47800754aa3279e88c9d88c380bcfe6263fb2d.camel@perches.com> (raw)
In-Reply-To: <acTPXMJfkHLeItrK@google.com>
On Wed, 2026-03-25 at 23:20 -0700, Dmitry Torokhov wrote:
> checkpatch does not handle full files well when they are passed on
> stdin, because it does not know how to treat the text, and whether it is
> a C file, or a DTS file, or something else, and so it assumes that when
> it works with stdin it should be a unified diff. For full files it
> expects to have a file name as an argument and read the contents from
> disk. Unfortunately this does not well when trying to use checkpatch as
> an online linter and feed it contents of an editor buffer that have not
> made it to the disk yet.
Why is this useful?
Why not save the buffer and then feed the file?
next prev parent reply other threads:[~2026-03-26 8:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 6:20 Dmitry Torokhov
2026-03-26 8:46 ` Joe Perches [this message]
2026-03-26 14:53 ` Dmitry Torokhov
2026-03-26 21:36 ` Joe Perches
2026-03-26 21:42 ` Dmitry Torokhov
2026-03-26 22:56 ` Joe Perches
2026-03-26 23:04 ` Dmitry Torokhov
2026-03-26 23:10 ` Joe Perches
2026-03-26 23:19 ` Dmitry Torokhov
2026-03-26 23:27 ` Joe Perches
2026-03-26 23:19 ` Joe Perches
2026-03-30 9:40 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb47800754aa3279e88c9d88c380bcfe6263fb2d.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox