From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AYpWgT9A" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF71DD3 for ; Wed, 6 Dec 2023 08:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701881867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oFeuJtK+zmdF2DRGAJQr++0Z9wdgk0HTu1uHhXoKQ9I=; b=AYpWgT9APhYbcdvUtZ2PO+nt5uloYTncpsnQa77VsJTYiNE8gBgi8HaSNaLx2YVeNLmvwk ROSHw0b7DCjnOyatdemUIOOAotR++VTOYSxCDS0vjv6bu1j2de34rkSrH6aLYpbaX/KzbZ 48vRqntzg7rx1pBV5cY5deUNIb2qmno= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-392-zgxqtKM1PHi-MVXz3Buzsw-1; Wed, 06 Dec 2023 11:57:45 -0500 X-MC-Unique: zgxqtKM1PHi-MVXz3Buzsw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-33353f98b7bso7355f8f.0 for ; Wed, 06 Dec 2023 08:57:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701881864; x=1702486664; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oFeuJtK+zmdF2DRGAJQr++0Z9wdgk0HTu1uHhXoKQ9I=; b=cS6F/qscvtyVhiH2JAcwRmLeW5+en7rkVokCbDItLvgIILZVTgMCnluUe+XoyNBZRC BW/CTgjMy40kkO6jU3zIwYcBYlh2IxlP1wSd2uZxsC06l5AFhK3RaFbnc97rnl11iUcw wLAc+sKSLrMxgg+vtThyva4v4z8GkoHiFp93IrkwmZQ7CcLWZ/0M6XI+Nn/5Tv05xL8D SGIuo59KBfNwd7/w1ub9UAO86KcE3a6iCqwyAJWtvnNSae3zI8zXTdUfatLHB601aiSB wgHDlFxWZ1/ZzgyqZ7u/HUhtoQsmhSlP8jyWXMCMSav2YXoqmtlTlWccTfcPSaFQUMW0 vemA== X-Gm-Message-State: AOJu0Yzu6BNePJ+WMAfzXJaDhspoHLw+lIqOKAgwEl9ahFZCE1mpyKCq 0SwUDjNsR7GP0597hpwrbgOTLvCzKi8RO+ZZ++7E5xlYa3wBhB4UWrIbp7epczliuAAAG/5YpnU WkQgy55YxaOqtSd/5EVtd X-Received: by 2002:a5d:56cf:0:b0:333:1adc:a37b with SMTP id m15-20020a5d56cf000000b003331adca37bmr630982wrw.5.1701881864144; Wed, 06 Dec 2023 08:57:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IEP4MRv6FtBdsWsfM6nYWwuBr+Be/E9MbySQYUrXe/MmZeAqmbZdu0rtf327EL+KMbRwVwS1w== X-Received: by 2002:a5d:56cf:0:b0:333:1adc:a37b with SMTP id m15-20020a5d56cf000000b003331adca37bmr630971wrw.5.1701881863851; Wed, 06 Dec 2023 08:57:43 -0800 (PST) Received: from [192.168.0.118] (88-113-27-52.elisa-laajakaista.fi. [88.113.27.52]) by smtp.gmail.com with ESMTPSA id g17-20020adfa491000000b003333541a5bdsm119315wrb.80.2023.12.06.08.57.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Dec 2023 08:57:43 -0800 (PST) Message-ID: Date: Wed, 6 Dec 2023 18:57:41 +0200 Precedence: bulk X-Mailing-List: workflows@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 02/10] MAINTAINERS: Introduce V: entry for tests Content-Language: en-US To: Joe Perches , David Gow Cc: workflows@vger.kernel.org, Jonathan Corbet , Andy Whitcroft , Theodore Ts'o , Steven Rostedt , Mark Brown , Shuah Khan , "Darrick J . Wong" , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, Veronika Kabatova , CKI , kernelci@lists.linux.dev References: <20231115175146.9848-1-Nikolai.Kondrashov@redhat.com> <20231205184503.79769-1-Nikolai.Kondrashov@redhat.com> <20231205184503.79769-3-Nikolai.Kondrashov@redhat.com> <9b45b0ebce3457c22aa456779aa1a5244b8ef6ad.camel@perches.com> From: Nikolai Kondrashov In-Reply-To: <9b45b0ebce3457c22aa456779aa1a5244b8ef6ad.camel@perches.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/6/23 18:38, Joe Perches wrote: > On Wed, 2023-12-06 at 18:23 +0200, Nikolai Kondrashov wrote: >> On 12/6/23 10:12, David Gow wrote: >>> I'm pretty happy with this personally, though I definitely think we >>> need the support for tests which aren't just executable scripts (e.g. >>> the docs in patch 6). >>> >>> The get_maintailer.pl bits, and hence the requirement to not include >>> '@', feel a little bit 'off': I'd rather get_maintainer.pl kept emails >>> and tests separate by some other means (either having --test _only_ >>> print tests, not emails at all, or by giving them a prefix like >>> 'TEST:' or something). But that is diverging more from the existing >>> behaviour of get_maintainer.pl, so I could go either way. >>> >>> Otherwise, this looks pretty good. I'll give it a proper test tomorrow >>> alongside the other patches. >> >> Thanks for the review, David! >> >> Yeah, I don't like the '@' bit myself, but it seems to be the path of least >> resistance right now (not necessarily the best one, of course). >> >> I'm up for adding an option to get_maintainer.pl that disables email output, >> if people like that, though. > > That already exists though I don't understand the > specific requirement here > > --nom --nol --nor > > from > $ ./scripts/get_maintainer.pl --help > [] > --m => include maintainer(s) if any > --r => include reviewer(s) if any > --n => include name 'Full Name ' > --l => include list(s) if any > [] > Most options have both positive and negative forms. > The negative forms for -- are --no and --no-. > Thanks, Joe! Yeah, I already explored that way, but it seems to be explicitly forbidden: $ scripts/get_maintainer.pl --nom --nol --nor 0001-dt-bindings-mailbox-convert-bcm2835-mbox-bindings-to.patch scripts/get_maintainer.pl: Please select at least 1 email option So, I assumed there is a reason and an intention behind this behavior and went the other way. Nick