workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Dr. David Alan Gilbert" <linux@treblig.org>,
	Greg KH <greg@kroah.com>, Sasha Levin <sashal@kernel.org>,
	corbet@lwn.net, linux-doc@vger.kernel.org,
	workflows@vger.kernel.org, josh@joshtriplett.org,
	kees@kernel.org, konstantin@linuxfoundation.org,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 0/4] Add agent coding assistant configuration to Linux kernel
Date: Wed, 30 Jul 2025 18:33:33 +0100	[thread overview]
Message-ID: <b13949aa-a845-4935-b9f6-0cefaf31e12b@lucifer.local> (raw)
In-Reply-To: <20250730132054.1e710372@gandalf.local.home>

On Wed, Jul 30, 2025 at 01:20:54PM -0400, Steven Rostedt wrote:
> On Wed, 30 Jul 2025 18:10:51 +0100
> Lorenzo Stoakes <lorenzo.stoakes@oracle.com> wrote:
>
>
> > > > I guess a statement in submitting-patches.rst would suffice, or should it
> > > > be a separate standalone document?
> > >
> > > If it's separate I think it needs to have a link from submitting-patches.rst
> > > to get people to read it.
> >
> > Absolutely agree.
>
> Sorry for cropping your response about submitting patches, but honestly, I
> think it may get more visibility there than in a separate doc. That's
> because submitting-patches is one of the most popular documents kernel devs
> reference to people submitting patches!

No worries! :)

Yeah to be clear - I think this should be a link, very heavily highlighted. Or
we could summarise (using AI? Kidding ;) what the document states there, with a
link for details.

>
> Of course, adding a link as suggested above may fix that too.
>
> >
> > >
> > > To summarise some other things that came up between the threads:
> > >   a) I think there should be a standard syntax for stating it is
> > >      AI written; I'd suggested using a new tag, but others were
> > >      arguing on the side of reusing existing tags, which seems OK
> > >      if it is done in a standard way and doesn't confuse existing tools.
> >
> > Yes.
> >
> > >
> > >   b) There's a whole spectrum of:
> > >       i) AI wrote the whole patch based on a vague requirement
> > >      ii) AI is in the editor and tab completes stuff
> > >     iii) AI suggests fixes/changes
> > >     which do you care about?
> >
> > I think any AI involvment that results in _changes to the code_ should
> > require the tag.
>
> I disagree with this. As I reply, I don't think if you have AI finishing
> your for loops and such requires disclosure. As I believe that may soon be
> the norm of most folks and then we may get AI storms.

This is actually a very good point.

This is going to be tricky, because hallucination is such a serious
concern, and even this kind of autocomplete would make me want to have a
closer look.

>
> And then, if you have people saying "I don't want any AI patches", does
> that mean those that use AI for templates and such will now be forbidden
> from submitting to those subsystems?

I think that's something we can potentially get more fine-grained on in
future.

>
> I would say if AI creates any algorithm for you then it must be disclosed.

I think what consitutes an 'algorithm' is very nebulous and you're likely
to get people messing around on the definition of this.

I think rather we could have an 'unless' list like:

Unless:

- It's whitespace only,
- You used autocomplete features for for loops etc.

AND you have checked that no hallucination has occurred.

The perennial problem with LLMs is that they can hallucinate in _very_
subtle ways that can be hard for humans to pick up on.

But we also have to be practical so I agree, we might end up with the tags
being noise if we don't make sensible exceptions (whether we like it or
not).

>
> >
> > >
> > >   c) But then once you get stuff suggesting fixes/changes people were
> > >     wondering if you should specify other non-AI tools as well.
> > >     That might help reviewers who get bombed by a million patches
> > >     from some conventional tool.
>
> I should add that non-AI tools should always come with a disclaimer that
> they were used. For the most part, most submissions that use non-AI tooling
> has done this. I just don't think we ever made any formal policy about it.

Yeah I've noticed this too, would be nice to standardise though.

Cheers, Lorenzo

  reply	other threads:[~2025-07-30 17:33 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-27 19:57 Sasha Levin
2025-07-27 19:57 ` [PATCH 1/4] agents: add unified agent coding assistant configuration Sasha Levin
2025-07-28  2:37   ` Kees Cook
2025-07-28  4:43     ` Sasha Levin
2025-07-28  5:16       ` Kees Cook
2025-07-28  5:39         ` Sasha Levin
2025-07-30 22:06   ` Kevin Hilman
2025-07-30 23:47     ` Sasha Levin
2025-08-01 20:53     ` Rob Herring
2025-08-08 18:07       ` Kevin Hilman
2025-07-27 19:58 ` [PATCH 2/4] agents: add core development references Sasha Levin
2025-07-28  2:39   ` Kees Cook
2025-07-28  5:00     ` Sasha Levin
2025-07-28  5:10       ` Kees Cook
2025-07-28  5:59         ` Sasha Levin
2025-07-28  6:18           ` Kees Cook
2025-07-28 12:35             ` Sasha Levin
2025-07-30 16:25             ` Sasha Levin
2025-07-30 17:35               ` Al Viro
2025-07-30 18:29                 ` Sasha Levin
2025-07-30 18:18               ` Matthew Wilcox
2025-07-30 18:41                 ` Sasha Levin
2025-07-28  4:24   ` Greg KH
2025-07-28  4:52     ` Sasha Levin
2025-07-28  5:02       ` Kees Cook
2025-07-27 19:58 ` [PATCH 3/4] agents: add coding style documentation and rules Sasha Levin
2025-07-28  2:40   ` Kees Cook
2025-07-28  5:10     ` Sasha Levin
2025-07-28  5:21       ` Kees Cook
2025-07-28  6:03         ` Sasha Levin
2025-07-30  9:31           ` Krzysztof Kozlowski
2025-07-30 14:48             ` Jakub Kicinski
2025-07-30 15:10             ` Steven Rostedt
2025-07-27 19:58 ` [PATCH 4/4] agents: add legal requirements and agent attribution guidelines Sasha Levin
2025-07-28  2:43   ` Kees Cook
2025-08-05 22:08   ` Jeff Johnson
2025-08-05 23:11     ` Laurent Pinchart
2025-08-05 23:33       ` Sasha Levin
2025-08-06 14:12   ` Konstantin Ryabitsev
2025-08-06 21:53     ` Sasha Levin
2025-07-28  7:58 ` [PATCH 0/4] Add agent coding assistant configuration to Linux kernel Vlastimil Babka
2025-07-28  9:27   ` David Hildenbrand
2025-07-28 10:37     ` Greg KH
2025-07-28 10:47       ` David Hildenbrand
2025-07-28 13:05         ` Sasha Levin
2025-08-04  9:23           ` Michal Hocko
2025-08-04  9:41             ` Michal Hocko
2025-08-04 13:25             ` Sasha Levin
2025-08-04 22:03               ` Jiri Kosina
2025-08-04 22:14                 ` Steven Rostedt
2025-08-04 22:30                   ` Jiri Kosina
2025-08-04 22:53                   ` dan.j.williams
2025-08-04 23:30                     ` Sasha Levin
2025-08-04 23:39                       ` Laurent Pinchart
2025-08-05 13:29                         ` Steven Rostedt
2025-07-28 11:57   ` Sasha Levin
2025-07-28  8:42 ` Lorenzo Stoakes
2025-07-28 10:35   ` Greg KH
2025-07-28 10:52     ` Lorenzo Stoakes
2025-07-28 12:45       ` Sasha Levin
2025-07-28 13:13         ` Lorenzo Stoakes
2025-07-28 13:23           ` Sasha Levin
2025-07-28 13:28             ` Lorenzo Stoakes
2025-07-30 15:27       ` Steven Rostedt
2025-07-30 15:34         ` Lorenzo Stoakes
2025-07-30 16:18           ` Steven Rostedt
2025-07-30 16:33             ` Mauro Carvalho Chehab
2025-07-30 16:36             ` Sasha Levin
2025-07-30 16:59               ` Lorenzo Stoakes
2025-07-30 17:12                 ` Sasha Levin
2025-07-30 17:23                   ` Lorenzo Stoakes
2025-07-30 17:32                     ` Steven Rostedt
2025-07-30 18:03                       ` Sasha Levin
2025-07-30 18:18                         ` Lorenzo Stoakes
2025-07-30 18:04                       ` Lorenzo Stoakes
2025-07-30 19:16                         ` Mark Brown
2025-07-30 17:25                   ` Steven Rostedt
2025-07-30 17:34                 ` Mark Brown
2025-07-30 17:36                 ` Kees Cook
2025-08-04 10:20                 ` Jiri Kosina
2025-07-30 17:05               ` Steven Rostedt
2025-07-30 17:46                 ` Sasha Levin
2025-07-30 17:59                   ` Al Viro
2025-07-30 18:10                     ` Sasha Levin
2025-07-30 18:24                       ` Lorenzo Stoakes
2025-07-30 18:59                         ` Sasha Levin
2025-07-30 19:10                     ` Theodore Ts'o
2025-07-30 19:40                       ` Steven Rostedt
2025-07-30 19:51                       ` Al Viro
2025-07-30 19:27                   ` Steven Rostedt
2025-07-31  0:02                   ` Mauro Carvalho Chehab
2025-07-30 16:40             ` Dr. David Alan Gilbert
2025-07-30 17:10               ` Lorenzo Stoakes
2025-07-30 17:20                 ` Steven Rostedt
2025-07-30 17:33                   ` Lorenzo Stoakes [this message]
2025-07-30 17:12               ` Steven Rostedt
2025-07-30 17:39                 ` Dr. David Alan Gilbert
2025-07-30 17:51               ` Kees Cook
2025-07-30 16:58             ` Lorenzo Stoakes
2025-07-28 10:56     ` Laurent Pinchart
2025-08-12 18:13 ` Nicolas Frattaroli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b13949aa-a845-4935-b9f6-0cefaf31e12b@lucifer.local \
    --to=lorenzo.stoakes@oracle.com \
    --cc=corbet@lwn.net \
    --cc=greg@kroah.com \
    --cc=josh@joshtriplett.org \
    --cc=kees@kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=rostedt@goodmis.org \
    --cc=sashal@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox