workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] doc: development-process: add notice on testing
@ 2026-01-22 11:15 Dmitry Antipov
  2026-01-22 11:56 ` Andy Shevchenko
  2026-01-22 18:28 ` Randy Dunlap
  0 siblings, 2 replies; 7+ messages in thread
From: Dmitry Antipov @ 2026-01-22 11:15 UTC (permalink / raw)
  To: Andy Shevchenko, Jonathan Corbet; +Cc: workflows, linux-doc, Dmitry Antipov

Add testing notice to "Before creating patches" section.

Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
 Documentation/process/5.Posting.rst | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/process/5.Posting.rst b/Documentation/process/5.Posting.rst
index 9999bcbdccc9..0271a4dc525e 100644
--- a/Documentation/process/5.Posting.rst
+++ b/Documentation/process/5.Posting.rst
@@ -40,7 +40,12 @@ sending patches to the development community.  These include:
  - Test the code to the extent that you can.  Make use of the kernel's
    debugging tools, ensure that the kernel will build with all reasonable
    combinations of configuration options, use cross-compilers to build for
-   different architectures, etc.
+   different architectures, etc. Add tests, likely using an existing
+   testing frameworks like KUnit, and include them as a separate member
+   of your series (see the next section on what about the series is).
+   Note that this may be mandatory when affecting some subsystems. For
+   example, library functions (resides under lib/) are extensively used
+   almost everywhere and expected to be tested appropriately.
 
  - Make sure your code is compliant with the kernel coding style
    guidelines.
-- 
2.52.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] doc: development-process: add notice on testing
  2026-01-22 11:15 [PATCH] doc: development-process: add notice on testing Dmitry Antipov
@ 2026-01-22 11:56 ` Andy Shevchenko
  2026-01-22 18:28 ` Randy Dunlap
  1 sibling, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2026-01-22 11:56 UTC (permalink / raw)
  To: Dmitry Antipov; +Cc: Jonathan Corbet, workflows, linux-doc

On Thu, Jan 22, 2026 at 02:15:25PM +0300, Dmitry Antipov wrote:
> Add testing notice to "Before creating patches" section.

Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com>

Thanks!

I may confirm that lib/ is indeed a hotspot for treewide users and breaking
anything in lib/ almost always break at least a couple of users sometimes in
unexpected places. That's why the test cases are mandatory for a new feature
that will be reside in lib/.

> --- a/Documentation/process/5.Posting.rst
> +++ b/Documentation/process/5.Posting.rst

>   - Test the code to the extent that you can.  Make use of the kernel's
>     debugging tools, ensure that the kernel will build with all reasonable
>     combinations of configuration options, use cross-compilers to build for
> -   different architectures, etc.
> +   different architectures, etc. Add tests, likely using an existing
> +   testing frameworks like KUnit, and include them as a separate member
> +   of your series (see the next section on what about the series is).
> +   Note that this may be mandatory when affecting some subsystems. For
> +   example, library functions (resides under lib/) are extensively used
> +   almost everywhere and expected to be tested appropriately.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] doc: development-process: add notice on testing
  2026-01-22 11:15 [PATCH] doc: development-process: add notice on testing Dmitry Antipov
  2026-01-22 11:56 ` Andy Shevchenko
@ 2026-01-22 18:28 ` Randy Dunlap
  2026-01-23  7:15   ` [PATCH v2] " Dmitry Antipov
  1 sibling, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2026-01-22 18:28 UTC (permalink / raw)
  To: Dmitry Antipov, Andy Shevchenko, Jonathan Corbet; +Cc: workflows, linux-doc

Hi,

On 1/22/26 3:15 AM, Dmitry Antipov wrote:
> Add testing notice to "Before creating patches" section.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
>  Documentation/process/5.Posting.rst | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/process/5.Posting.rst b/Documentation/process/5.Posting.rst
> index 9999bcbdccc9..0271a4dc525e 100644
> --- a/Documentation/process/5.Posting.rst
> +++ b/Documentation/process/5.Posting.rst
> @@ -40,7 +40,12 @@ sending patches to the development community.  These include:
>   - Test the code to the extent that you can.  Make use of the kernel's
>     debugging tools, ensure that the kernel will build with all reasonable
>     combinations of configuration options, use cross-compilers to build for
> -   different architectures, etc.
> +   different architectures, etc. Add tests, likely using an existing
> +   testing frameworks like KUnit, and include them as a separate member

              framework

> +   of your series (see the next section on what about the series is).

                     (see the next section for more about patch series).

> +   Note that this may be mandatory when affecting some subsystems. For
> +   example, library functions (resides under lib/) are extensively used
> +   almost everywhere and expected to be tested appropriately.
>  
>   - Make sure your code is compliant with the kernel coding style
>     guidelines.

-- 
~Randy


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2] doc: development-process: add notice on testing
  2026-01-22 18:28 ` Randy Dunlap
@ 2026-01-23  7:15   ` Dmitry Antipov
  2026-01-23  7:19     ` Randy Dunlap
  2026-02-02 17:02     ` Jonathan Corbet
  0 siblings, 2 replies; 7+ messages in thread
From: Dmitry Antipov @ 2026-01-23  7:15 UTC (permalink / raw)
  To: Andy Shevchenko, Jonathan Corbet, Randy Dunlap
  Cc: workflows, linux-doc, Dmitry Antipov

Add testing notice to "Before creating patches" section.

Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
v2: adjust spelling and wording according to Randy
---
 Documentation/process/5.Posting.rst | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/process/5.Posting.rst b/Documentation/process/5.Posting.rst
index 9999bcbdccc9..07d7dbed13ec 100644
--- a/Documentation/process/5.Posting.rst
+++ b/Documentation/process/5.Posting.rst
@@ -40,7 +40,12 @@ sending patches to the development community.  These include:
  - Test the code to the extent that you can.  Make use of the kernel's
    debugging tools, ensure that the kernel will build with all reasonable
    combinations of configuration options, use cross-compilers to build for
-   different architectures, etc.
+   different architectures, etc. Add tests, likely using an existing
+   testing framework like KUnit, and include them as a separate member
+   of your series (see the next section for more about patch series).
+   Note that this may be mandatory when affecting some subsystems. For
+   example, library functions (resides under lib/) are extensively used
+   almost everywhere and expected to be tested appropriately.
 
  - Make sure your code is compliant with the kernel coding style
    guidelines.
-- 
2.52.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] doc: development-process: add notice on testing
  2026-01-23  7:15   ` [PATCH v2] " Dmitry Antipov
@ 2026-01-23  7:19     ` Randy Dunlap
  2026-01-23 10:50       ` Andy Shevchenko
  2026-02-02 17:02     ` Jonathan Corbet
  1 sibling, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2026-01-23  7:19 UTC (permalink / raw)
  To: Dmitry Antipov, Andy Shevchenko, Jonathan Corbet; +Cc: workflows, linux-doc



On 1/22/26 11:15 PM, Dmitry Antipov wrote:
> Add testing notice to "Before creating patches" section.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Andy also Acked it. I think you could/should include
his Ack here as well.

Thanks.

> ---
> v2: adjust spelling and wording according to Randy
> ---
>  Documentation/process/5.Posting.rst | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/process/5.Posting.rst b/Documentation/process/5.Posting.rst
> index 9999bcbdccc9..07d7dbed13ec 100644
> --- a/Documentation/process/5.Posting.rst
> +++ b/Documentation/process/5.Posting.rst
> @@ -40,7 +40,12 @@ sending patches to the development community.  These include:
>   - Test the code to the extent that you can.  Make use of the kernel's
>     debugging tools, ensure that the kernel will build with all reasonable
>     combinations of configuration options, use cross-compilers to build for
> -   different architectures, etc.
> +   different architectures, etc. Add tests, likely using an existing
> +   testing framework like KUnit, and include them as a separate member
> +   of your series (see the next section for more about patch series).
> +   Note that this may be mandatory when affecting some subsystems. For
> +   example, library functions (resides under lib/) are extensively used
> +   almost everywhere and expected to be tested appropriately.
>  
>   - Make sure your code is compliant with the kernel coding style
>     guidelines.

-- 
~Randy

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] doc: development-process: add notice on testing
  2026-01-23  7:19     ` Randy Dunlap
@ 2026-01-23 10:50       ` Andy Shevchenko
  0 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2026-01-23 10:50 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Dmitry Antipov, Jonathan Corbet, workflows, linux-doc

On Thu, Jan 22, 2026 at 11:19:48PM -0800, Randy Dunlap wrote:
> On 1/22/26 11:15 PM, Dmitry Antipov wrote:
> > Add testing notice to "Before creating patches" section.
> > 
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Andy also Acked it. I think you could/should include

s/could// --> should

> his Ack here as well.

Yes. Carrying on the given tags is the author's responsibility.
Otherwise, you should explain clearly why the given tag is not
taking into account.

For this time I do it myself again, but next time don't forget doing that,
please.

Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] doc: development-process: add notice on testing
  2026-01-23  7:15   ` [PATCH v2] " Dmitry Antipov
  2026-01-23  7:19     ` Randy Dunlap
@ 2026-02-02 17:02     ` Jonathan Corbet
  1 sibling, 0 replies; 7+ messages in thread
From: Jonathan Corbet @ 2026-02-02 17:02 UTC (permalink / raw)
  To: Dmitry Antipov, Andy Shevchenko, Randy Dunlap
  Cc: workflows, linux-doc, Dmitry Antipov

Dmitry Antipov <dmantipov@yandex.ru> writes:

> Add testing notice to "Before creating patches" section.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
> v2: adjust spelling and wording according to Randy
> ---
>  Documentation/process/5.Posting.rst | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-02-02 17:02 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-22 11:15 [PATCH] doc: development-process: add notice on testing Dmitry Antipov
2026-01-22 11:56 ` Andy Shevchenko
2026-01-22 18:28 ` Randy Dunlap
2026-01-23  7:15   ` [PATCH v2] " Dmitry Antipov
2026-01-23  7:19     ` Randy Dunlap
2026-01-23 10:50       ` Andy Shevchenko
2026-02-02 17:02     ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox