From: Nicolas Schier <nsc@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: "Guillaume Tucker" <gtucker@gtucker.io>,
"Onur Özkan" <work@onurozkan.dev>,
"Miguel Ojeda" <ojeda@kernel.org>,
"David Gow" <davidgow@google.com>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kbuild@vger.kernel.org,
automated-testing@lists.yoctoproject.org,
workflows@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v4 1/2] scripts: add tool to run containerized builds
Date: Thu, 22 Jan 2026 20:57:39 +0100 [thread overview]
Message-ID: <aXKBM9mmf3VPUgyO@levanger> (raw)
In-Reply-To: <20260122184939.GA3461196@ax162>
On Thu, Jan 22, 2026 at 11:49:39AM -0700, Nathan Chancellor wrote:
> On Thu, Jan 22, 2026 at 03:59:54PM +0100, Guillaume Tucker wrote:
> > --- a/scripts/container
> > +++ b/scripts/container
> > @@ -120,7 +120,7 @@ class Runtimes:
> > if not runtime.is_present():
> > raise ValueError(f"runtime not found: {name}")
> > return runtime
> > - raise ValueError(f"unknown runtime: {runtime}")
> > + raise ValueError(f"unknown runtime: {name}")
> >
> > @classmethod
> > def find(cls):
> >
> >
> > Nathan, would you be OK with folding this in or should I send a v5?
>
> I can fold that in, thanks.
>
> I will carry forward Nicolas's ack and testing tags from v3, as this
> revision is not substantially different from what he looked at and
> tested.
thanks!
Kind regards,
Nicolas
next prev parent reply other threads:[~2026-01-22 19:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 14:06 [PATCH v4 0/2] scripts: introduce " Guillaume Tucker
2026-01-22 14:06 ` [PATCH v4 1/2] scripts: add tool to run " Guillaume Tucker
2026-01-22 14:29 ` Onur Özkan
2026-01-22 14:59 ` Guillaume Tucker
2026-01-22 16:39 ` Onur Özkan
2026-01-22 18:49 ` Nathan Chancellor
2026-01-22 19:57 ` Nicolas Schier [this message]
2026-01-22 14:07 ` [PATCH v4 2/2] Documentation: dev-tools: add container.rst page Guillaume Tucker
2026-01-22 14:22 ` Onur Özkan
2026-01-30 0:10 ` [PATCH v4 0/2] scripts: introduce containerized builds Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXKBM9mmf3VPUgyO@levanger \
--to=nsc@kernel.org \
--cc=arnd@arndb.de \
--cc=automated-testing@lists.yoctoproject.org \
--cc=davidgow@google.com \
--cc=gtucker@gtucker.io \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=work@onurozkan.dev \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox