workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Jonathan Corbet <corbet@lwn.net>,
	workflows@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] doc: development-process: add notice on testing
Date: Thu, 22 Jan 2026 13:56:23 +0200	[thread overview]
Message-ID: <aXIQZ0cI_4GF5d_t@smile.fi.intel.com> (raw)
In-Reply-To: <20260122111525.1112145-1-dmantipov@yandex.ru>

On Thu, Jan 22, 2026 at 02:15:25PM +0300, Dmitry Antipov wrote:
> Add testing notice to "Before creating patches" section.

Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com>

Thanks!

I may confirm that lib/ is indeed a hotspot for treewide users and breaking
anything in lib/ almost always break at least a couple of users sometimes in
unexpected places. That's why the test cases are mandatory for a new feature
that will be reside in lib/.

> --- a/Documentation/process/5.Posting.rst
> +++ b/Documentation/process/5.Posting.rst

>   - Test the code to the extent that you can.  Make use of the kernel's
>     debugging tools, ensure that the kernel will build with all reasonable
>     combinations of configuration options, use cross-compilers to build for
> -   different architectures, etc.
> +   different architectures, etc. Add tests, likely using an existing
> +   testing frameworks like KUnit, and include them as a separate member
> +   of your series (see the next section on what about the series is).
> +   Note that this may be mandatory when affecting some subsystems. For
> +   example, library functions (resides under lib/) are extensively used
> +   almost everywhere and expected to be tested appropriately.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-01-22 11:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22 11:15 Dmitry Antipov
2026-01-22 11:56 ` Andy Shevchenko [this message]
2026-01-22 18:28 ` Randy Dunlap
2026-01-23  7:15   ` [PATCH v2] " Dmitry Antipov
2026-01-23  7:19     ` Randy Dunlap
2026-01-23 10:50       ` Andy Shevchenko
2026-02-02 17:02     ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXIQZ0cI_4GF5d_t@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=corbet@lwn.net \
    --cc=dmantipov@yandex.ru \
    --cc=linux-doc@vger.kernel.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox