From: Ryota Sakamoto <sakamo.ryota@gmail.com>
To: David Gow <davidgow@google.com>
Cc: Brendan Higgins <brendan.higgins@linux.dev>,
Rae Moar <raemoar63@gmail.com>, Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, workflows@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] kunit: add bash completion
Date: Sat, 17 Jan 2026 01:58:53 +0900 [thread overview]
Message-ID: <aWptnVymdfj3-t2l@fedora> (raw)
In-Reply-To: <CABVgOS=Yn3K+Xzq_3tb0LCrX2eJjU5AG38uMwHaa21nXfxsjEQ@mail.gmail.com>
Hi David,
Thank you for the review.
On Fri, Jan 16, 2026 at 05:30:22PM +0800, David Gow wrote:
> Two small suggestions:
> - Could we add './tools/testing/kunit/kunit.py' to the list of
> commands? That's what's recommended in lots of documentation, emails,
> etc.
Sure, I will add the relative path of the script explicitly.
> - It'd be great to rebase this on top of kselftest/kunit -- there's a
> conflict with your previous patch.
I will rebase the patch on top of kselftest/kunit to resolve the conflict.
Regards,
Ryota Sakamoto
next prev parent reply other threads:[~2026-01-16 16:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 14:53 Ryota Sakamoto
2026-01-16 9:30 ` David Gow
2026-01-16 16:58 ` Ryota Sakamoto [this message]
2026-01-16 10:10 ` Jani Nikula
2026-01-16 17:16 ` Ryota Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWptnVymdfj3-t2l@fedora \
--to=sakamo.ryota@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=raemoar63@gmail.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox