From: Dan Carpenter <dan.carpenter@linaro.org>
To: Ally Heev <allyheev@gmail.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Joe Perches <joe@perches.com>, Jonathan Corbet <corbet@lwn.net>,
Andy Whitcroft <apw@canonical.com>,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
David Hunter <david.hunter.linux@gmail.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-pm <linux-pm@vger.kernel.org>,
dan.j.williams@intel.com
Subject: Re: [PATCH v2 2/2] add check for pointers with __free attribute initialized to NULL
Date: Fri, 24 Oct 2025 21:08:27 +0300 [thread overview]
Message-ID: <aPvAm1E7CvQfOIuS@stanley.mountain> (raw)
In-Reply-To: <20251024-aheev-checkpatch-uninitialized-free-v2-2-16c0900e8130@gmail.com>
On Fri, Oct 24, 2025 at 10:59:16PM +0530, Ally Heev wrote:
> pointers with __free attribute initialized to NULL
> pose potential cleanup issues [1] when a function uses
> interdependent variables with cleanup attributes
>
> Link: https://docs.kernel.org/core-api/cleanup.html [1]
> Link: https://lore.kernel.org/all/68f7b830ec21a_10e910070@dwillia2-mobl4.notmuch/
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Ally Heev <allyheev@gmail.com>
> ---
I don't think this patch is a good idea... There are two issues to
consider 1) The absolute number over warnings. 500+ is too high.
2) The ratio of bugs to false positives and we don't have any data on
that but I bet it's low. It needs to be at least 5%. For anything
lower than that, you're better off just reviewing code at random
instead of looking through warnings.
regards,
dan carpenter
next prev parent reply other threads:[~2025-10-24 18:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 17:29 [PATCH v2 0/2] checkpatch: add checks incorrectly initialized pointers with __free attr Ally Heev
2025-10-24 17:29 ` [PATCH v2 1/2] checkpatch: add uninitialized pointer with __free attribute check Ally Heev
2025-10-24 18:14 ` Joe Perches
2025-10-25 3:37 ` ally heev
2025-10-24 17:29 ` [PATCH v2 2/2] add check for pointers with __free attribute initialized to NULL Ally Heev
2025-10-24 18:01 ` Joe Perches
2025-10-24 18:14 ` dan.j.williams
2025-10-24 18:23 ` Joe Perches
2025-10-24 18:37 ` dan.j.williams
2025-10-25 6:17 ` ally heev
2025-10-24 18:08 ` Dan Carpenter [this message]
2025-10-25 6:23 ` ally heev
2025-10-27 5:27 ` Dan Carpenter
2025-10-27 8:34 ` ally heev
2025-10-25 6:29 ` ally heev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPvAm1E7CvQfOIuS@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=allyheev@gmail.com \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=david.hunter.linux@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vireshk@kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox