From: Dan Carpenter <dan.carpenter@linaro.org>
To: dan.j.williams@intel.com
Cc: Ally Heev <allyheev@gmail.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Joe Perches <joe@perches.com>, Jonathan Corbet <corbet@lwn.net>,
Andy Whitcroft <apw@canonical.com>,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
David Hunter <david.hunter.linux@gmail.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] checkpatch: add uninitialized pointer with __free attribute check
Date: Thu, 23 Oct 2025 16:44:54 +0300 [thread overview]
Message-ID: <aPoxVqxevopRpPu1@stanley.mountain> (raw)
In-Reply-To: <68f7b830ec21a_10e910070@dwillia2-mobl4.notmuch>
On Tue, Oct 21, 2025 at 09:43:28AM -0700, dan.j.williams@intel.com wrote:
> I would go futher and suggest that the pattern of:
>
> type foo __free(free_foo) = NULL;
>
> ...be made into a warning because that easily leads to situations where
> declaration order is out of sync with allocation order. I.e. can be made
> technically correct, but at a level of cleverness that undermines the
> benefit.
To be honest, I'm not sure what you're saying here...
I have written code like this. There are 515 places which use this
format. I think it would be a controversial change.
$ git grep __free | grep "= NULL" | wc -l
515
regards,
dan carpenter
next prev parent reply other threads:[~2025-10-23 13:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 11:30 Ally Heev
2025-10-21 16:43 ` dan.j.williams
2025-10-23 10:31 ` ally heev
2025-10-23 11:08 ` ally heev
2025-10-23 14:01 ` Dan Carpenter
2025-10-23 13:44 ` Dan Carpenter [this message]
2025-10-21 17:06 ` Joe Perches
2025-10-21 17:56 ` dan.j.williams
2025-10-22 10:20 ` Viresh Kumar
2025-10-23 15:14 ` ally heev
2025-10-22 7:25 ` Dan Carpenter
2025-10-23 10:41 ` ally heev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPoxVqxevopRpPu1@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=allyheev@gmail.com \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=david.hunter.linux@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox