From: Andrew Lunn <andrew@lunn.ch>
To: Simon Horman <horms@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Alexandre Ferrieux <alexandre.ferrieux@gmail.com>,
netdev@vger.kernel.org, workflows@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net] docs: netdev: Document guidance on inline functions
Date: Mon, 3 Feb 2025 16:10:24 +0100 [thread overview]
Message-ID: <a2ae1cda-8210-4e6c-86ea-0ee864e13b23@lunn.ch> (raw)
In-Reply-To: <20250203-inline-funk-v1-1-2f48418e5874@kernel.org>
> Conversely, spelling and grammar fixes are not discouraged.
>
> +Inline functions
> +----------------
> +
> +The use of static inline functions in .c file is strongly discouraged
I don't think 'static' is relevant here. They probably are static, if
they are inline, and to avoid warnings about missing declarations. But
we just prefer not to have any sort of inline functions without good
justifications within a .c file.
A nit pick, so:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2025-02-03 15:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 13:59 Simon Horman
2025-02-03 15:00 ` Jonathan Corbet
2025-02-03 19:50 ` Mauro Carvalho Chehab
2025-02-03 19:53 ` Mauro Carvalho Chehab
2025-02-04 11:55 ` Simon Horman
2025-02-04 11:54 ` Simon Horman
2025-02-04 13:25 ` Andrew Lunn
2025-02-04 20:07 ` Simon Horman
2025-02-04 22:46 ` David Laight
2025-02-03 15:10 ` Andrew Lunn [this message]
2025-02-04 9:35 ` Simon Horman
2025-02-03 18:51 ` Randy Dunlap
2025-02-04 11:56 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2ae1cda-8210-4e6c-86ea-0ee864e13b23@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.ferrieux@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox