[PATCH] Sounds better

[PATCH] Sounds better

[attreyee-muk]

Respected Maintainers, 

I have made a small change in the submitting-patches.rst document. I was
reading the submitting-patches.rst file as I needed to understand
certain things for submitting patches. That is when I found this. 
It might not be a very sigificant change, but I think it just improves a
bit of a readability and I feel that "Don't get discouraged, or become impatient"
sounds better.

Hence, sending this patch. Requesting the maintains to have a look at
it. 

Thank You
Attreyee Mukehrjee 

Signed-off-by: Attreyee Mukherjee <tintinm2017@gmail.com>
---
 Documentation/process/submitting-patches.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
index 86d346bcb8ef..f524e63fb429 100644
--- a/Documentation/process/submitting-patches.rst
+++ b/Documentation/process/submitting-patches.rst
@@ -360,7 +360,7 @@ space. For more details see: http://daringfireball.net/2007/07/on_top ::
 
 .. _resend_reminders:
 
-Don't get discouraged - or impatient
+Don't get discouraged, or become impatient. 
 ------------------------------------
 
 After you have submitted your change, be patient and wait.  Reviewers are
-- 
2.34.1

Re: [PATCH] Sounds better

[Greg KH]

On Sun, Dec 03, 2023 at 07:00:18PM +0530, attreyee-muk wrote:
> Respected Maintainers, 
> 
> I have made a small change in the submitting-patches.rst document. I was
> reading the submitting-patches.rst file as I needed to understand
> certain things for submitting patches. That is when I found this. 
> It might not be a very sigificant change, but I think it just improves a
> bit of a readability and I feel that "Don't get discouraged, or become impatient"
> sounds better.
> 
> Hence, sending this patch. Requesting the maintains to have a look at
> it. 
> 
> Thank You
> Attreyee Mukehrjee 
> 
> Signed-off-by: Attreyee Mukherjee <tintinm2017@gmail.com>
> ---
>  Documentation/process/submitting-patches.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index 86d346bcb8ef..f524e63fb429 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -360,7 +360,7 @@ space. For more details see: http://daringfireball.net/2007/07/on_top ::
>  
>  .. _resend_reminders:
>  
> -Don't get discouraged - or impatient
> +Don't get discouraged, or become impatient. 
>  ------------------------------------
>  
>  After you have submitted your change, be patient and wait.  Reviewers are
> -- 
> 2.34.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch contains warnings and/or errors noticed by the
  scripts/checkpatch.pl tool.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what a proper
  Subject: line should look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] Sounds better

[Matthew Wilcox]

On Sun, Dec 03, 2023 at 07:00:18PM +0530, attreyee-muk wrote:
> Hence, sending this patch. Requesting the maintains to have a look at
> it. 

In addition to Greg's comment, after you have made changes to an rst
file, you have to try building the documents again (eg "make htmldocs").
I can see you've introduced a syntax error in this document.

Also, titles do not have a full stop at the end.