From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F6BBC61D90 for ; Tue, 21 Nov 2023 20:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229495AbjKUUs4 (ORCPT ); Tue, 21 Nov 2023 15:48:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbjKUUsz (ORCPT ); Tue, 21 Nov 2023 15:48:55 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 002D818C for ; Tue, 21 Nov 2023 12:48:51 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06810C433C8; Tue, 21 Nov 2023 20:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700599731; bh=KolmBwKpbH8naVtlkDeppnK3S5S+HMNbhSd3gc0CZxA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dKhUW0WCGHF12g7ooSZO9omLXTl4ZDn7ynQ20GnZgxM7ibLgdypYYdQ6so4kas9ni yByBTagw90rO8Wjft/2KURnmg82qBdlqGi0Xe3BDWWmUML2qm/sCllHaRKZCFj1KT5 avxMFmTwveLnrhmGz6KEPfgG9eWLXeNscGBwBVB8yo3xyddcQ8IpHNj0voNyzqbLeS waDhkDNt1ZmZ2ev9BeBmZ+Cp7gzf+BtufTaPQS1AGtnUHQFE+I82Au1TmsI/rXEeiW 69fitct9TaAJxSKlfQ3cfQlqdVdgOAgi05b5b7P4Ujxhf65MwbGHnxdNqe5f7K9OIu 2XwC5s1/gZyiQ== Date: Tue, 21 Nov 2023 20:48:48 +0000 From: Mark Brown To: David Gow Cc: Nikolai Kondrashov , workflows@vger.kernel.org, Joe Perches , Andy Whitcroft , Theodore Ts'o , Steven Rostedt , Shuah Khan , "Darrick J . Wong" , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, Veronika Kabatova , CKI , kernelci@lists.linux.dev Subject: Re: [PATCH 1/3] MAINTAINERS: Introduce V: field for required tests Message-ID: References: <20231115175146.9848-1-Nikolai.Kondrashov@redhat.com> <20231115175146.9848-2-Nikolai.Kondrashov@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+Qm4wxwj82KSPBf4" Content-Disposition: inline In-Reply-To: X-Cookie: Slow day. Practice crawling. Precedence: bulk List-ID: X-Mailing-List: workflows@vger.kernel.org --+Qm4wxwj82KSPBf4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 21, 2023 at 06:36:10PM +0800, David Gow wrote: > The other question is how to handle outdated results when a new patch > revision is sent out. Personally, I think this is something we can > solve similarly to 'Reviewed-by', depending on the extent of the > changes and cost of the tests. I suspect for most automated tests, > this would mean never carrying the 'Tested-with' tag over, but if > testing it involved manually building and running kernels against 50 > different hardware setups, I could imagine it making sense to not > re-do this if a new revision just changed a doc typo. If a URL is used > here, it could contain version info, too. One thing with Reviewed-by that's a bit different to testing is that Reviewed-by is generally invalidated by doing a change to the specific patch that needs at least a commit --amend. > Personally, I'd like to require that all patches have a 'Tested-with' > field, even if there's not a corresponding 'V' MAINTAINERS entry, as > people should at least think of how something's tested, even if > there's not a formal 'test suite' for it. Though that seems a > longer-term goal A requirement feels like it'd be pretty painful for my workflow, or at least result in me adding the thing in hope of what I'm actually going to do rather than as a result of the testing - all my CI stuff (including what I do for outgoing patches) is keyed off the git commits being tested so updating the commits to reflect testing would have unfortunate side effects. > The questions I think we need to answer to get this in are: > 1. Do we want to split this up (and potentially land it > piece-by-piece), or is it more valuable to have a stricter, more > complete system from the get-go? I think splitting things makes sense. --+Qm4wxwj82KSPBf4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVdF60ACgkQJNaLcl1U h9A5vAf/f7C2XrRwjIRIADD8Ve0hYKnWBqwkrLTphkTj23ZtQSNnLIITZ05iaoQw 71Tv3qjAA6hNllYEMhokmzVR3tnWSwIrjrl4kgejoIl0xxkYvfwovMneEy0zvwHW Qlwfz4MoIXXJxOrbMCfD7RVXYWhu/XYzheIKMul6/KbJskCdg9Zr1qC2boS6F09i mu6jEGy3PP8/iRBd4l8cgotkPjia61cLiN55iI8YHw6FA3+t3MhSVTpCT6djwWFe 0h19srptjeRH41akN5l7j6rgBSjlSjlluk3cip7pC+31FtUFy3pW2gg12GPE5POr uVWCogn0zxnbnN0INipYeYnMZD6KEQ== =x8lK -----END PGP SIGNATURE----- --+Qm4wxwj82KSPBf4--