From: Matthew Wilcox <willy@infradead.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Giulio Benetti <giulio.benetti@benettiengineering.com>,
Jonathan Corbet <corbet@lwn.net>,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] docs: submitting-patches: Add Sponsored-by tag to give credits to who sponsored the patch
Date: Mon, 21 Aug 2023 13:57:12 +0100 [thread overview]
Message-ID: <ZONfKKwFaDQpuZ9w@casper.infradead.org> (raw)
In-Reply-To: <87o7j07frk.fsf@intel.com>
On Mon, Aug 21, 2023 at 03:15:43PM +0300, Jani Nikula wrote:
> On Mon, 21 Aug 2023, Matthew Wilcox <willy@infradead.org> wrote:
> > On Mon, Aug 21, 2023 at 11:29:27AM +0300, Jani Nikula wrote:
> >> On Fri, 18 Aug 2023, Matthew Wilcox <willy@infradead.org> wrote:
> >> > but you might have (eg)
> >> >
> >> > Laurent Pinchard (Coca-Cola) <laurent.pinchart@ideasonboard.com>
> >> >
> >> > and then when working for another sponsor:
> >> >
> >> > Laurent Pinchard (Ford) <laurent.pinchart@ideasonboard.com>
> >>
> >> Just an observation, git shortlog -s/-se groups/distinguishes,
> >> respectively, the author and sponsor in Laurent's approach. Not so with
> >> Matthew's approach.
> >
> > Hm?
> >
> > $ git shortlog -s next-20230817..
> > 1 Matthew Wilcox (Novartis)
> > 25 Matthew Wilcox (Oracle)
> >
> > $ git shortlog -se next-20230817..
> > 1 Matthew Wilcox (Novartis) <willy@infradead.org>
> > 25 Matthew Wilcox (Oracle) <willy@infradead.org>
>
> $ git shortlog v6.4.. -s --author="Laurent Pinchart"
> 12 Laurent Pinchart
>
> $ git shortlog v6.4.. -se --author="Laurent Pinchart"
> 2 Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> 10 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I must not be understanding your point correctly.
$ git shortlog v6.4.. -s --author="Matthew Wilcox"
7 Matthew Wilcox
1 Matthew Wilcox (Novartis)
123 Matthew Wilcox (Oracle)
That seems to me like it successfully distinguishes my fake commit on
behalf of Novartis (who I haven't actually worked for since 1997) from
my real commits on behalf of Oracle. It also shows a few places where
my commits weren't attributed to Oracle (I think this happens when I
send patches using mutt instead of git-send-email)
next prev parent reply other threads:[~2023-08-21 12:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 22:09 [RFC PATCH 0/1] Attempt to add Sponsored-by tag Giulio Benetti
2023-08-17 22:09 ` [RFC PATCH 1/1] docs: submitting-patches: Add Sponsored-by tag to give credits to who sponsored the patch Giulio Benetti
2023-08-17 23:23 ` Laurent Pinchart
2023-08-18 0:21 ` Matthew Wilcox
2023-08-19 20:44 ` Giulio Benetti
2023-08-21 8:29 ` Jani Nikula
2023-08-21 12:07 ` Matthew Wilcox
2023-08-21 12:15 ` Jani Nikula
2023-08-21 12:57 ` Matthew Wilcox [this message]
2023-08-21 14:38 ` Jani Nikula
2023-08-23 23:29 ` Giulio Benetti
2023-08-19 20:39 ` Giulio Benetti
2023-08-21 7:40 ` Geert Uytterhoeven
2023-08-21 9:27 ` Toke Høiland-Jørgensen
2023-08-23 23:21 ` Giulio Benetti
2023-08-21 14:57 ` Jakub Kicinski
2023-08-23 23:24 ` Giulio Benetti
2023-08-23 23:19 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZONfKKwFaDQpuZ9w@casper.infradead.org \
--to=willy@infradead.org \
--cc=corbet@lwn.net \
--cc=giulio.benetti@benettiengineering.com \
--cc=jani.nikula@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox