From: Petr Mladek <pmladek@suse.com>
To: Siddharth Menon <simeddon@gmail.com>
Cc: shuah@kernel.org, corbet@lwn.net, mbenes@suse.cz,
linux-kselftest@vger.kernel.org, workflows@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/3] docs/kselftests: Explain the usage of TEST_CONFIG_DEPS
Date: Tue, 10 Dec 2024 15:30:33 +0100 [thread overview]
Message-ID: <Z1hQiQM5FbSVpiEy@pathway.suse.cz> (raw)
In-Reply-To: <20241205114757.5916-2-simeddon@gmail.com>
On Thu 2024-12-05 17:17:55, Siddharth Menon wrote:
> Update documentation to explain the TEST_CONFIG_DEPS flag in lib.mk.
> TEST_CONFIG_DEPS is used to validate the presence of required config flags
> specified in the selftest makefile before compiling or running a test.
>
> Signed-off-by: Siddharth Menon <simeddon@gmail.com>
> ---
> Documentation/dev-tools/kselftest.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index fdb1df86783a..e816b282363f 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -301,6 +301,9 @@ Contributing new tests (details)
>
> e.g: tools/testing/selftests/android/config
>
> + * Use TEST_CONFIG_DEPS to specify required config options to be enabled
> + before a test is allowed to run or compile.
> +
> * Create a .gitignore file inside test directory and add all generated objects
> in it.
It might be a matter of taste. It is a chicken & egg problem. I
personally find it weird to document something which does not exist yet.
Please, either update the documentation together with the code or
later :-)
Best Regards,
Petr
PS: I haven't got this mail. I have got only 2nd and 3rd patch.
I prefer to see the entire patchset. I suggest to always
send all patches to the same list of people and mailing lists.
prev parent reply other threads:[~2024-12-10 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 11:47 [PATCH 0/3] kselftest framework to introduce TEST_CONFIG_DEPS Siddharth Menon
2024-12-05 11:47 ` [PATCH 1/3] docs/kselftests: Explain the usage of TEST_CONFIG_DEPS Siddharth Menon
2024-12-10 14:30 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1hQiQM5FbSVpiEy@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=shuah@kernel.org \
--cc=simeddon@gmail.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox