From: Matthew Wilcox <willy@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Geert Uytterhoeven" <geert+renesas@glider.be>,
"Dwaipayan Ray" <dwaipayanray1@gmail.com>,
"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
"Joe Perches" <joe@perches.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Thorsten Leemhuis" <linux@leemhuis.info>,
"Andy Whitcroft" <apw@canonical.com>,
"Niklas Söderlund" <niklas.soderlund@corigine.com>,
"Simon Horman" <horms@kernel.org>,
"Conor Dooley" <conor@kernel.org>,
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Increase minimum git commit ID abbreviation to 16 characters
Date: Sat, 14 Dec 2024 16:03:21 +0000 [thread overview]
Message-ID: <Z12sScjRHpB1d0nO@casper.infradead.org> (raw)
In-Reply-To: <CAHk-=wiwAz3UgPOWK3RdGXDnTRHcwVbxpuxCQt_0SoAJC-oGXQ@mail.gmail.com>
On Thu, Dec 05, 2024 at 11:19:18AM -0800, Linus Torvalds wrote:
> Why do I care? Because long git commit IDs are actually detrimental to
> legibility. I try to make commit messages legible, and that very much
> is the *point* of the short format. It's for people, not machinery.
>
> Yes, the basic git machinery doesn't do object type disambiguation
> (and if you do "git show", you can give it blob IDs etc, so git itself
> may not know about the proper type to use disambiguate at all). And
> git also doesn't know about the whole "we also put the first line of
> the commit message" thing.
>
> But honestly, I'm claiming that something like
>
> Fixes: 48bcda684823 ("tracing: Remove definition of trace_*_rcuidle()")
I have wondered about using a different encoding for the sha1.
Classic Ascii85 encoding is no good; it uses characters like '"\<
which interact poorly with every shell. RFC1924 is somewhat better,
but still uses characters that interact poorly with shell.
Base36 (ie 0-9a-z) would take 10 characters to represent as many bits
as 12 characters in base16. Base62 (0-9a-zA-Z) gives us 8 characters
to represent _almost_ 48 bits. We could do Base64 (RFC 4648) which
uses + and /, and is common enough. Good enough to be worth the
additional complexity?
next prev parent reply other threads:[~2024-12-14 16:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 18:16 [PATCH v2 0/2] Align and increase git commit ID abbreviation guidelines and checks Geert Uytterhoeven
2024-12-05 18:16 ` [PATCH v2 1/2] Align " Geert Uytterhoeven
2024-12-30 18:43 ` Jonathan Corbet
2024-12-05 18:16 ` [PATCH v2 2/2] Increase minimum git commit ID abbreviation to 16 characters Geert Uytterhoeven
2024-12-05 19:19 ` Linus Torvalds
2024-12-13 19:41 ` Geert Uytterhoeven
2024-12-14 16:03 ` Matthew Wilcox [this message]
2024-12-14 16:31 ` Linus Torvalds
2024-12-18 23:36 ` [RFC] git-disambiguate: disambiguate shorthand git ids Sasha Levin
2024-12-19 1:41 ` Kees Cook
2024-12-19 20:35 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z12sScjRHpB1d0nO@casper.infradead.org \
--to=willy@infradead.org \
--cc=apw@canonical.com \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gitster@pobox.com \
--cc=horms@kernel.org \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=lukas.bulwahn@gmail.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=niklas.soderlund@corigine.com \
--cc=torvalds@linux-foundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox