Re: Monitoring the status of your own patches on patchwork?

[Simon Glass <sjg@chromium.org>]

Hi,

On Sat, 11 Dec 2021 at 12:06, Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>
> Hi everyone!
>
> I was wondering if anyone had any nifty tricks or utilities to help
> monitor the status of your own patch submissions on a patchwork
> instance? Things like getting a notification when a patch changes status
> or when one of the automated checks on that particular patchwork
> instance fails for a patch you submitted?
>
> I can just filter the patchwork web interface to my name, of course, but
> I would like something that can be automated so I can make the stuff I
> care about show up in my inbox :)

I'll just mention 'patman status' here, which collects tags from
patchwork so you can send them with the next version. It also shows
you code-review snippets on the cmdline which I find much faster to
process, particularly for large patches. See below, although it's a
bit hard to read without the colours that patman uses.

I would like something that can track all the series and tell me what
is outstanding. At the moment I keep a manual list but often forget
things.

$ patman status
  1 efi: Rename UCLASS_EFI and IF_TYPE_EFI
  + Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
  2 efi: Add EFI uclass for media
  + Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
  3 efi: Add a media/block driver for EFI block device
  + Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
  4 efi: Locate all block devices in the app
  5 efi: serial: Support arrow keys
[...]
3 new responses available in patchwork (use -d to write them to a new branch)

$ patman status -C
  1 efi: Rename UCLASS_EFI and IF_TYPE_EFI
  + Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Review: Heinrich Schuchardt <xypron.glpk@gmx.de>
    > File: include/dm/uclass-id.h
    > Line: 48 / 48: enum uclass_id {
    >    UCLASS_DMA, /* Direct Memory Access */
    >    UCLASS_DSA, /* Distributed (Ethernet) Switch Architecture */
    >    UCLASS_ECDSA, /* Elliptic curve cryptographic device */
    > - UCLASS_EFI, /* EFI managed devices */
    > + UCLASS_EFI_LOADER, /* Devices managed by EFI_LOADER */
    "managed by EFI_LOADER" does not catch it. I will change this to
    "devices created by UEFI applications and drivers" when merging.

  2 efi: Add EFI uclass for media
  + Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Review: Heinrich Schuchardt <xypron.glpk@gmx.de>
    > At present UCLASS_EFI is used to represent an EFI filesystem among other
    %s/UCLASS_EFI/UCLASS_EFI_LOADER/

    > pretty vague. The only driver that uses this uclass is in fact not a real
    > U-Boot driver, since its operations do not include a struct udevice.
    >
    > Rather than mess with this, create a new UCLASS_EFI_MEDIA uclass to handle
    > EFI media such as disks. Make this the uclass to use for EFI media so that
    The new uclass is for devices provided by an UEFI implementation loading
    U-Boot as an EFI application.

    > it can be used with 'part list', for example.
    >
    > The existing implementation using UCLASS_EFI remains as is, for
    %s/UCLASS_EFI/UCLASS_EFI_LOADER/
    The existing uclass is for devices created by UEFI applications loaded
    by U-Boot.

    > File: include/dm/uclass-id.h
    > Line: 49 / 49: enum uclass_id {
    > +++ b/include/dm/uclass-id.h
    >    UCLASS_DSA, /* Distributed (Ethernet) Switch Architecture */
    >    UCLASS_ECDSA, /* Elliptic curve cryptographic device */
    >    UCLASS_EFI_LOADER, /* Devices managed by EFI_LOADER */
    > + UCLASS_EFI_MEDIA, /* EFI media (e.g. a disk) */
    %s/EFI media (e.g. a disk)/devices provided by UEFI firmware */
    With those changes:

  3 efi: Add a media/block driver for EFI block device
  + Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Regards,
Simon