From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Miguel Ojeda <ojeda@kernel.org>,
dan.j.williams@intel.com, corbet@lwn.net,
gregkh@linuxfoundation.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@roeck-us.net,
max.kellermann@ionos.com, workflows@vger.kernel.org
Subject: Re: [PATCH v3] Documentation/process/coding-style.rst: space around const
Date: Thu, 12 Oct 2023 18:53:37 +0200 [thread overview]
Message-ID: <CANiq72nr88=r-rackE7+DBAxg8VYy8LYO9D2h0vnxbAoSXFFSQ@mail.gmail.com> (raw)
In-Reply-To: <e212997cf8b05608718fb6ac1766c390255664ac.camel@perches.com>
On Thu, Oct 12, 2023 at 4:48 PM Joe Perches <joe@perches.com> wrote:
>
> Do older versions of clang-format ignore entries
> they don't understand?
Sadly, no, that is the reason we keep it at the minimum.
However, I just took a look again at it, and I see that such support
was added to LLVM 12, the `--Wno-error=unknown` flag in commit
f64903fd8176 ("Add -Wno-error=unknown flag to clang-format.").
So this means that the minimum is bumped to 12, we could in principle
use newer options.
I think the downsides are that users will need to pass the flag
(potentially in e.g. their IDE or similar) and that formatting could
be potentially chaotic depending on the options ignored. I guess
particular subsystems could agree on which version to use.
Cheers,
Miguel
prev parent reply other threads:[~2023-10-12 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 12:58 Max Kellermann
2023-10-10 19:24 ` Greg KH
2023-10-10 23:46 ` Guenter Roeck
2023-10-11 0:45 ` Joe Perches
2023-10-11 21:44 ` Dan Williams
2023-10-12 11:50 ` Miguel Ojeda
2023-10-12 14:48 ` Joe Perches
2023-10-12 16:53 ` Miguel Ojeda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72nr88=r-rackE7+DBAxg8VYy8LYO9D2h0vnxbAoSXFFSQ@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=max.kellermann@ionos.com \
--cc=ojeda@kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox