From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18C97C5AD4C for ; Thu, 16 Nov 2023 14:21:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234623AbjKPOVw convert rfc822-to-8bit (ORCPT ); Thu, 16 Nov 2023 09:21:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231205AbjKPOVv (ORCPT ); Thu, 16 Nov 2023 09:21:51 -0500 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B49011F; Thu, 16 Nov 2023 06:21:48 -0800 (PST) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-5b499b18b28so9628147b3.0; Thu, 16 Nov 2023 06:21:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700144507; x=1700749307; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aTx8TpUCHZnFxSy50UzWEJ/5KYXYD5wT5yrFARu50ps=; b=TuOp9BvBKdGANoYaWcadx8dEbcMXodYtEYQJWtx3dHAq0W1iqg1xt/V+hGkG8xvIBa IS6VxUFjLkM+6YX1pM8NsXVJjjwZ7TAzTffOYOL4c2yJh2qNqnEOGswXmtDkbRa7qNFq 4OMxdZGuxNuIUBIejViyhXBBfV2j7Sb3l6fsMCPsLrTig2fsCwoZUAZwhRm8CVAAniGA Ce9YDNkMiQlV5wylXKnmc0hvm4OAc9GZGdL0IFW2orMOfshkpvc6BQKwn2ka23UeAiiq qYHsKKPpifPwZFxHBvQiaACoWyYnWXXxawCwqXHVASYF4eOBLwNQacWIRyUwWBy7ubwf xfIw== X-Gm-Message-State: AOJu0Yy6wLCo1vp2ipKLwBftoprIsIRPd43mqb1BG1vw7gzPJ5lmP4mB SxVhIEjLbPKcbcOzW8HHadrDDHqjiaMF+g== X-Google-Smtp-Source: AGHT+IFk65NcNMuIuixJS9RaQDjqSP6f1Fe3B8zyx/qzZ08ocWCkSvOsok9Lt9o4P8u/GiMloNodUA== X-Received: by 2002:a81:5201:0:b0:5a7:ba09:e58b with SMTP id g1-20020a815201000000b005a7ba09e58bmr17376492ywb.14.1700144507230; Thu, 16 Nov 2023 06:21:47 -0800 (PST) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com. [209.85.219.173]) by smtp.gmail.com with ESMTPSA id f125-20020a0ddc83000000b005a7bbd713ddsm1000165ywe.108.2023.11.16.06.21.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Nov 2023 06:21:47 -0800 (PST) Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-da3b4b7c6bdso811723276.2; Thu, 16 Nov 2023 06:21:46 -0800 (PST) X-Received: by 2002:a25:d88a:0:b0:da0:3b47:bf0c with SMTP id p132-20020a25d88a000000b00da03b47bf0cmr17271398ybg.20.1700144505875; Thu, 16 Nov 2023 06:21:45 -0800 (PST) MIME-Version: 1.0 References: <20231115175146.9848-1-Nikolai.Kondrashov@redhat.com> <20231115175146.9848-2-Nikolai.Kondrashov@redhat.com> In-Reply-To: From: Geert Uytterhoeven Date: Thu, 16 Nov 2023 15:21:34 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] MAINTAINERS: Introduce V: field for required tests To: Bagas Sanjaya Cc: Nikolai Kondrashov , workflows@vger.kernel.org, Joe Perches , Andy Whitcroft , "Theodore Ts'o" , David Gow , Steven Rostedt , Mark Brown , Shuah Khan , "Darrick J . Wong" , Charles Han , Greg Kroah-Hartman , Linux Kernel Unit Tests , Linux Kernel Self Tests , Veronika Kabatova , CKI , kernelci@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: workflows@vger.kernel.org Hi Bagas, On Thu, Nov 16, 2023 at 2:20 PM Bagas Sanjaya wrote: > On Wed, Nov 15, 2023 at 07:43:49PM +0200, Nikolai Kondrashov wrote: > > Make scripts/checkpatch.pl ensure any added V: fields reference > > documented test suites only, and output a warning if a change to a > > subsystem doesn't certify the required test suites were executed, > > if any. > > > > If the test suite description includes a "Command", then checkpatch.pl > > will output it as the one executing the suite. The command should run > > with only the kernel tree and the regular developer environment set up. > > But, at the same time, could simply output instructions for installing > > any extra dependencies (or pull some automatically). The idea is to > > get the developer into feedback loop quicker and easier, so they have > > something to run and iterate on, even if it involves installing some > > more stuff first. Therefore it's a good idea to add such wrappers to the > > kernel tree proper and refer to them from the tests.rst. > > Does it also apply to trivial patches (e.g. spelling or checkpatch fixes > as seen on drivers/staging/)? After having seen the introduction of too many build failures, I'm inclined to ask for an even stronger proof of testing for "trivial" fixes for drivers/staging... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds