workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: workflows@vger.kernel.org
Subject: Re: RFC: using supersedes: trailer to indicate patch/series revision flow
Date: Fri, 8 Nov 2019 10:46:05 +0100	[thread overview]
Message-ID: <CAMuHMdX58ztXbvSLOaLkRG6UBqhcEU1gfz_LFeM6fX5B5diF6w@mail.gmail.com> (raw)
In-Reply-To: <20191107204349.hqpefgp7cowj6hof@chatter.i7.local>

Hi Konstantin,

On Thu, Nov 7, 2019 at 9:44 PM Konstantin Ryabitsev
<konstantin@linuxfoundation.org> wrote:
> The only mechanism we currently have for patch/series versioning is
> subject suffixes. I think it would be useful to have a way to more
> explicitly mark that a series obsoletes a previous version, and I
> propose this is done with a `supersedes:` trailer at the end of the
> cover letter or in the first patch of the series:

In theory, this sounds like a good idea to me.
Whether it's practical to implement it, is to be seen...

> Questions:
>
> 1. Should this be exposed via git-format-patch flags, or just used by
>     specialized tooling?

While I switched to always applying bundles from patchwork to have the
Link: added automatically, I'm not aware of a simple way to add a
superseded header automatically.

> 2. Should supersedes: link to the previous version of the patch, or the
>     first ever version of the patch? I am leaning towards the latter,
>     even though in this case the message-id largely becomes identical in
>     usage to Gerrit's Change-Id.

The previous version, as that's the one being superseded, and doing it
this way allows to iterate backwards through history.
The first ever version has been superseded already by the previous
version (if any).

> 3. Should the supersedes trailer have:
>     a. message-id without brackets
>     b. message-id with brackets
>     c. https://lore.kernel.org/r/message-id
>     My preference is b, to match with The Message-Id header usage.

I think c makes most sense, as it allows to follow the Link: in a commit, and
iterate backwards using the same method.
Else we have to convert manually from message-id to lore link.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply	other threads:[~2019-11-08  9:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 20:43 Konstantin Ryabitsev
2019-11-07 23:45 ` Rafael J. Wysocki
2019-11-08  8:30   ` Han-Wen Nienhuys
2019-11-08  9:59     ` Geert Uytterhoeven
2019-11-08 10:48       ` Laurent Pinchart
2019-11-08 11:00       ` Rafael J. Wysocki
2019-11-08  0:09 ` Andrew Donnellan
2019-11-08  9:19 ` Vegard Nossum
2019-11-08  9:46 ` Geert Uytterhoeven [this message]
2019-11-14  6:29 ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdX58ztXbvSLOaLkRG6UBqhcEU1gfz_LFeM6fX5B5diF6w@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox