From: Nick Desaulniers <ndesaulniers@google.com>
To: Justin Stitt <justinstitt@google.com>
Cc: Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Nathan Chancellor <nathan@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
geert@linux-m68k.org, gregkh@linuxfoundation.org,
workflows@vger.kernel.org, mario.limonciello@amd.com
Subject: Re: [PATCH 0/3] get_maintainer: add patch-only keyword matching
Date: Wed, 27 Sep 2023 08:24:58 -0700 [thread overview]
Message-ID: <CAKwvOdn4wwaBYzddLuXunjvCyH7HU8Brds-ZCYzsSxsAg4275Q@mail.gmail.com> (raw)
In-Reply-To: <20230927-get_maintainer_add_d-v1-0-28c207229e72@google.com>
On Tue, Sep 26, 2023 at 8:19 PM Justin Stitt <justinstitt@google.com> wrote:
>
> This series aims to add "D:" which behaves exactly the same as "K:" but
> works only on patch files.
>
> The goal of this is to reduce noise when folks use get_maintainer on
> tree files as opposed to patches. This use case should be steered away
> from [1] but "D:" should help maintainers reduce noise in their inboxes
> regardless, especially when matching omnipresent keywords like [2]. In
> the event of [2] Kees would be to/cc'd from folks running get_maintainer
> on _any_ file containing "__counted_by". The number of these files is
> rising and I fear for his inbox as his goal, as I understand it, is to
> simply monitor the introduction of new __counted_by annotations to
> ensure accurate semantics.
Something like this (whether this series or a different approach)
would be helpful to me as well; we use K: to get cc'ed on patches
mentioning clang or llvm, but our ML also then ends up getting cc'ed
on every follow up patch to most files.
This is causing excessive posts on our ML. As a result, it's a
struggle to get folks to cc themselves to the ML, which puts the code
review burden on fewer people.
Whether it's a new D: or refinement to the behavior of K:, I applaud
the effort. Hopefully we can find an approach that works for
everyone.
And may God have mercy on your soul for having to touch that much perl. :-P
>
> See [3/3] for an illustrative example.
>
> This series also includes a formatting pass over get_maintainer because
> I personally found it difficult to parse with the human eye.
>
> [1]: https://lore.kernel.org/all/20230726151515.1650519-1-kuba@kernel.org/
> [2]: https://lore.kernel.org/all/20230925172037.work.853-kees@kernel.org/
>
> Signed-off-by: Justin Stitt <justinstitt@google.com>
> ---
> Justin Stitt (3):
> MAINTAINERS: add documentation for D:
> get_maintainer: run perltidy
> get_maintainer: add patch-only pattern matching type
>
> MAINTAINERS | 3 +
> scripts/get_maintainer.pl | 3334 +++++++++++++++++++++++----------------------
> 2 files changed, 1718 insertions(+), 1619 deletions(-)
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
> change-id: 20230926-get_maintainer_add_d-07424a814e72
>
> Best regards,
> --
> Justin Stitt <justinstitt@google.com>
>
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2023-09-27 15:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 3:19 Justin Stitt
2023-09-27 3:19 ` [PATCH 1/3] MAINTAINERS: add documentation for D: Justin Stitt
2023-09-27 3:27 ` Joe Perches
2023-09-27 3:30 ` Justin Stitt
2023-09-27 16:06 ` Kees Cook
2023-09-27 3:19 ` [PATCH 3/3] get_maintainer: add patch-only pattern matching type Justin Stitt
2023-09-27 6:14 ` Greg KH
2023-09-27 6:46 ` Justin Stitt
2023-09-27 8:21 ` Greg KH
2023-09-27 16:15 ` Kees Cook
2023-09-27 19:33 ` Joe Perches
2023-09-27 19:00 ` Joe Perches
[not found] ` <20230927-get_maintainer_add_d-v1-2-28c207229e72@google.com>
2023-09-27 3:26 ` [PATCH 2/3] get_maintainer: run perltidy Joe Perches
2023-09-27 15:24 ` Nick Desaulniers [this message]
2023-09-27 16:01 ` [PATCH 0/3] get_maintainer: add patch-only keyword matching Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdn4wwaBYzddLuXunjvCyH7HU8Brds-ZCYzsSxsAg4275Q@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=justinstitt@google.com \
--cc=keescook@chromium.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=nathan@kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox