From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEA361A705B for ; Thu, 3 Oct 2024 16:11:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727971909; cv=none; b=laOk4fKLwQjyZO9eSqr03TozpjnDxLS/0LImZSa3i1yGmLbGrwHf0sOiorLNbe5PxO9CWZVSq2goSLPTnfXne4naPWj13aTIGmGOw1jLAavYWj+m/m1C+9ji4zAfEotTf92ofYdArw2pKAAaNMmmCcSQKLdjBqGfJXGw/VQFYK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727971909; c=relaxed/simple; bh=KAJhNktsKQBL31h4FFeDeoZJgORcWmVqd2YZcjRTjio=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=MEAPy+CPA+DtsWBIbhDokFLn3LCygPvz/1hCkol3LK1o/ZRgq52r82nONtKdMGdzTBxg+rnXATDF5bLxIiz5OWi8WDGta/TQwySCfEuQsQXdagh98YuE16EssbZGml+PKetzffQrzm2Ie22in0qBsM2Q+ddzlEYDAtVn8tSNCu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=htZCYnHn; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="htZCYnHn" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-42cbe624c59so10192215e9.3 for ; Thu, 03 Oct 2024 09:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727971906; x=1728576706; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z8M94Szf86aflf7GYtGP4IFREoq5t6mzeSASTe2kb0E=; b=htZCYnHnXDGWCP+6zbxUw779bJe8vH6gOTcHBU0FS6B+yhLxoYKbh3SeI9QwfA95m7 OUUCpDRNaFtGYJMc84CNmcWcJNAJc/2pnjuJkMQy1CbQJbZVmfsl9/udA67Zkr33hyMV YKJtPC0B25j8jGWbG5CZy1BRX9K4QgmsZ0fZ0/PUX/wBVk+12sHBFBI+mMCdnWM2A/xB M4D995eTb2Op1U6It1TzoW4+rp9IkCmpbZMGxDK1CICnRODHIhNEHZJGj7Z7UFMssR1s rqfaObnFpqU9kAN5Uxw0VzHDv5ddSv4E3HJR0/I62I0XkCHnUfnG3tTcQmeas7S1199s SxQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727971906; x=1728576706; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z8M94Szf86aflf7GYtGP4IFREoq5t6mzeSASTe2kb0E=; b=b3HaDXl6mhwbZO92l3fQglgVlU+uiLb/fzwtQ5nToaTdNDoUXf65yBYzDE2bUhDUgB UBOu73OW2tLuOIg4DDTDDte7Rt2iuIlbcm5UY+Lx1qxr/bEBJOz3XXnjkbhFiA7E3EIM Im0Q0i672QBf2kkW5a0w6clE3eM0DLgWI0PlneDBkp9GheiJhmnmbgVvyOjIR2NEkLDh GRMXOVImw1nAI2TgCjkcHt33yV1w8WpfmQXG+Dd9GYO2cCadqXQEYjsDF7QVQe6jUhGj wqC2nSQKbRyiaD36KwvJgriHRSpBJy0Ma7hCGUTQtY+/DYjQiYe+0D+IIklTI5JFbFRC Tyzg== X-Forwarded-Encrypted: i=1; AJvYcCW4D84wfFnhPDv5BD5s5tjAuBUxDSBSiSPtSGVwJX6oK0mXsKgJUM47b/bl7YOJAaUr4Q9AWCjoLqY=@vger.kernel.org X-Gm-Message-State: AOJu0YziOngSsjwl8/Bqy3vgTVGoCDq8xVF/2yAqDqfksfuRa0eIssAb znLpnlryxQV2Bm0OhIQFk+LZHJBUp8YvAGTGuN4dCyo6c3ycgJD4ltP2YLd6Onnpv6Y9indspA2 8qiJjZ4/hWwzjkfeXQVtWoNCJDiGKb72suXQ3 X-Google-Smtp-Source: AGHT+IGsVwokVwDnq0q9EW2iHbb+PYH+PmCbmotDyShkoPWSykbINIhoAZtW8xfR6197nX/vMfmDWCNcz9sMeU0B/yE= X-Received: by 2002:a05:6000:4009:b0:37c:c605:218b with SMTP id ffacd0b85a97d-37cfb9c8d6cmr4943794f8f.35.1727971905843; Thu, 03 Oct 2024 09:11:45 -0700 (PDT) Precedence: bulk X-Mailing-List: workflows@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241002233409.2857999-1-xur@google.com> <20241002233409.2857999-2-xur@google.com> <20241003154143.GW5594@noisy.programming.kicks-ass.net> <20241003160309.GY5594@noisy.programming.kicks-ass.net> In-Reply-To: <20241003160309.GY5594@noisy.programming.kicks-ass.net> From: Nick Desaulniers Date: Thu, 3 Oct 2024 09:11:34 -0700 Message-ID: Subject: Re: [PATCH v2 1/6] Add AutoFDO support for Clang build To: Peter Zijlstra , Jonathan Corbet Cc: Rong Xu , Han Shen , Sriraman Tallam , David Li , Krzysztof Pszeniczny , Alice Ryhl , Andrew Morton , Arnd Bergmann , Bill Wendling , Borislav Petkov , Breno Leitao , Brian Gerst , Dave Hansen , Heiko Carstens , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Josh Poimboeuf , Juergen Gross , Justin Stitt , Kees Cook , linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Masahiro Yamada , "Mike Rapoport (IBM)" , Nathan Chancellor , Nicolas Schier , "Paul E. McKenney" , Samuel Holland , Thomas Gleixner , Wei Yang , workflows@vger.kernel.org, x86@kernel.org, "Xin Li (Intel)" , Stephane Eranian Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Oct 3, 2024 at 9:03=E2=80=AFAM Peter Zijlstra wrote: > > On Thu, Oct 03, 2024 at 08:51:51AM -0700, Nick Desaulniers wrote: > > On Thu, Oct 3, 2024 at 8:42=E2=80=AFAM Peter Zijlstra wrote: > > > > > > On Wed, Oct 02, 2024 at 04:34:00PM -0700, Rong Xu wrote: > > > > +6) Rebuild the kernel using the AutoFDO profile file with the same= config as step 1, > > > > + (Note CONFIG_AUTOFDO_CLANG needs to be enabled): > > > > + > > > > + .. code-block:: sh > > > > + > > > > + $ make LLVM=3D1 CLANG_AUTOFDO_PROFILE=3D > > > + > > > > > > > > > Can this be done without the endless ... code-block nonsense? > > > > Dunno, I think it looks pretty nice once rendered. Makes it > > It makes it absolute crap for all of us who 'render' text documents > using less or vi. "It hurts when I punch myself in the face." https://docs.kernel.org/ is where we point people to, and what we should be optimizing for (IMO). Jonathan, do we have a policy about using code-block consistently throughout the kernel docs or not? Otherwise, this complaint smells like "non-technical non-sense" to me. --=20 Thanks, ~Nick Desaulniers