workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Vlastimil Babka <vbabka@suse.cz>,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	 Jakub Kicinski <kuba@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	 "Rafael J. Wysocki" <rafael@kernel.org>,
	dan.j.williams@intel.com,
	 Caleb Sander Mateos <csander@purestorage.com>,
	io-uring <io-uring@vger.kernel.org>,
	 workflows@vger.kernel.org
Subject: Re: Link trailers revisited (was Re: [GIT PULL] io_uring fix for 6.17-rc5)
Date: Tue, 9 Sep 2025 17:30:38 +0200	[thread overview]
Message-ID: <CAJZ5v0g-T44CWLn5EXufpELOk30OsFJZUo9jipAhwPq1A=dJuQ@mail.gmail.com> (raw)
In-Reply-To: <be98399d-3886-496e-9cf4-5ec909124418@kernel.dk>

On Tue, Sep 9, 2025 at 4:50 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 9/9/25 8:48 AM, Vlastimil Babka wrote:
> > On 9/9/25 16:42, Konstantin Ryabitsev wrote:
> >> On Tue, Sep 09, 2025 at 08:35:18AM -0600, Jens Axboe wrote:
> >>>>> On a global scale, that's quite a number of saved mailing list archive searches.
> >>>>
> >>>> +1 FWIW. I also started slapping the links on all patches in a series,
> >>>> even if we apply with a merge commit. I don't know of a good way with
> >>>> git to "get to the first parent merge" so scanning the history to find
> >>>> the link in the cover letter was annoying me :(
> >>>
> >>> Like I've tried to argue, I find them useful too. But after this whole
> >>> mess of a thread, I killed -l from my scripts. I do think it's a mistake
> >>> and it seems like the only reason to remove them is that Linus expects
> >>> to find something at the end of the link rainbow and is often
> >>> disappointed, and that annoys him enough to rant about it.
> >>>
> >>> I know some folks downstream of me on the io_uring side find them useful
> >>> too, because they've asked me several times to please remember to ensure
> >>> my own self-applied patches have the link as well. For those, I tend to
> >>> pick or add them locally rather than use b4 for it, which is why they've
> >>> never had links.
> >>>
> >>> As far as I can tell, only two things have been established here:
> >>>
> >>> 1) Linus hates the Link tags, except if they have extra information
> >>> 2) Lots of other folks find them useful
> >>>
> >>> and hence we're at a solid deadlock here.
> >>
> >> I did suggest that provenance links use the patch.msgid.link subdomain. This
> >
> > Yes, and the PR that started this thread had a normal lore link. Would it
> > have been different with a patch.msgid.link as perhaps Linus would not try
> > opening it and become disappointed?
> > You did kinda ask that early in the thread but then the conversation went in
> > different directions.
>
> I think we all know the answer to that one - it would've been EXACTLY
> the same outcome. Not to put words in Linus' mouth, but it's not the
> name of the tag that he finds repulsive, it's the very fact that a link
> is there and it isn't useful _to him_.

Well, I think that the convention associated with patch.msgid.link is
clear, like for the "Fixes:" and "Cc: stable" tags.  Those tags are
also generally useful, but mostly in the post-development part of the
process, so to speak.

So, if there are no problems with adding "Fixes:" and "Cc: stable"
tags, why would there be a problem with patch.msgid.link?

  reply	other threads:[~2025-09-09 15:30 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <9ef87524-d15c-4b2c-9f86-00417dad9c48@kernel.dk>
     [not found] ` <CAHk-=wjamixjqNwrr4+UEAwitMOd6Y8-_9p4oUZdcjrv7fsayQ@mail.gmail.com>
     [not found]   ` <20250905-lovely-prehistoric-goldfish-04e1c3@lemur>
     [not found]     ` <CAHk-=wg30HTF+zWrh7xP1yFRsRQW-ptiJ+U4+ABHpJORQw=Mug@mail.gmail.com>
2025-09-05 19:33       ` Konstantin Ryabitsev
2025-09-05 20:09         ` Linus Torvalds
2025-09-05 20:47         ` Sasha Levin
2025-09-06 11:27         ` Greg KH
2025-09-06 11:27           ` Greg KH
2025-09-06 11:30             ` Greg KH
2025-09-06 13:51           ` Konstantin Ryabitsev
2025-09-06 15:31             ` Linus Torvalds
2025-09-06 18:50               ` Konstantin Ryabitsev
2025-09-06 19:19                 ` Linus Torvalds
2025-09-08  9:11                   ` Jani Nikula
2025-09-08 11:59                 ` Mark Brown
2025-09-08 20:11         ` dan.j.williams
2025-09-09 11:29           ` Mark Brown
2025-09-09 13:17           ` Rafael J. Wysocki
2025-09-09 14:18             ` Jakub Kicinski
2025-09-09 14:35               ` Jens Axboe
2025-09-09 14:42                 ` Konstantin Ryabitsev
2025-09-09 14:48                   ` Vlastimil Babka
2025-09-09 14:50                     ` Jens Axboe
2025-09-09 15:30                       ` Rafael J. Wysocki [this message]
2025-09-09 16:40                       ` Linus Torvalds
2025-09-09 17:08                         ` Mark Brown
2025-09-09 17:50                           ` Linus Torvalds
2025-09-09 17:58                             ` Linus Torvalds
2025-09-09 18:31                               ` Konstantin Ryabitsev
2025-09-09 19:36                                 ` dan.j.williams
2025-09-10  1:12                                 ` dan.j.williams
2025-09-10 12:19                                   ` Mark Brown
2025-09-09 17:25                         ` dan.j.williams
2025-09-09 17:56                           ` Alexei Starovoitov
2025-09-09 18:01                             ` Linus Torvalds
2025-09-09 18:13                               ` Alexei Starovoitov
2025-09-09 18:06                         ` Vlastimil Babka
2025-09-09 18:14                           ` Linus Torvalds
2025-09-09 18:22                             ` Vlastimil Babka
2025-09-09 21:05                               ` Mark Brown
2025-09-10  1:33                                 ` Konstantin Ryabitsev
2025-09-09 14:44                 ` Greg KH
2025-09-09 15:14                 ` Danilo Krummrich
2025-09-09 16:32         ` [RFC] b4 dig: Add AI-powered email relationship discovery command Sasha Levin
2025-09-09 17:22           ` Laurent Pinchart
2025-09-09 17:26             ` Jens Axboe
2025-09-09 18:54               ` Sasha Levin
2025-09-10 10:13                 ` Laurent Pinchart
2025-09-10 10:55                   ` Sasha Levin
2025-09-10 11:29                     ` Laurent Pinchart
2025-09-10 13:38             ` Konstantin Ryabitsev
2025-09-10 14:03               ` Andrew Dona-Couch
2025-09-11 14:48           ` Nicolas Frattaroli
2025-09-11 15:05             ` Sasha Levin
2025-09-11 19:13               ` Nicolas Frattaroli
2025-09-11 19:57                 ` Sasha Levin
2025-09-15 11:26                   ` Mark Brown
2025-09-15 11:48                     ` Sasha Levin
2025-09-15 12:03                       ` Mark Brown
2025-09-11 23:24           ` Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJZ5v0g-T44CWLn5EXufpELOk30OsFJZUo9jipAhwPq1A=dJuQ@mail.gmail.com' \
    --to=rafael@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=csander@purestorage.com \
    --cc=dan.j.williams@intel.com \
    --cc=io-uring@vger.kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vbabka@suse.cz \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox