From: Rong Xu <xur@google.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Han Shen <shenhan@google.com>, Jonathan Corbet <corbet@lwn.net>,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: dev-tools: Fix a typo in autofdo documentation
Date: Tue, 2 Sep 2025 09:50:05 -0700 [thread overview]
Message-ID: <CAF1bQ=TB6KMAkwXfEF=ZJvJZqV8B9kEw3jbVMG4gRoLOUjksiA@mail.gmail.com> (raw)
In-Reply-To: <d2a5b07e-2da1-47f0-b2cb-a4ffa12a99b0@oracle.com>
Thanks for the fix! I meant to include "/" in the original patch, but
I overlooked it.
Reviewed-by: Rong Xu <xur@google.com>
On Tue, Sep 2, 2025 at 6:03 AM Harshit Mogalapalli
<harshit.m.mogalapalli@oracle.com> wrote:
>
> Hi Geert,
>
> On 02/09/25 12:43, Geert Uytterhoeven wrote:
> > Hi Harshit,
> >
> > On Mon, 1 Sept 2025 at 17:57, Harshit Mogalapalli
> > <harshit.m.mogalapalli@oracle.com> wrote:
> >> Use cat /proc/cpuinfo as opposed cat proc/cpuinfo.
> >>
> >> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> >
> > Thanks for your patch!
> >
> >> --- a/Documentation/dev-tools/autofdo.rst
> >> +++ b/Documentation/dev-tools/autofdo.rst
> >> @@ -131,11 +131,11 @@ Here is an example workflow for AutoFDO kernel:
> >>
> >> For Zen3::
> >>
> >> - $ cat proc/cpuinfo | grep " brs"
> >> + $ cat /proc/cpuinfo | grep " brs"
> >>
> >> For Zen4::
> >>
> >> - $ cat proc/cpuinfo | grep amd_lbr_v2
> >> + $ cat /proc/cpuinfo | grep amd_lbr_v2
> >>
> >> The following command generated the perf data file::
> >>
> >
> > One might say the path depends on where the proc filesystem is mounted ;-)
> > However, all other documentation (except for two occurrences in
> > Documentation/networking/proc_net_tcp.rst, which you may want to fix,
> > too) assumes /proc, so it is better to be consistent.
> >
>
> Oh very good point, yes I did check other instances and thought we make
> it consistent.
>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
>
> Thanks a lot for the review.
>
>
> Regards,
> Harshit
>
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
>
prev parent reply other threads:[~2025-09-02 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 15:07 Harshit Mogalapalli
2025-08-31 15:12 ` Harshit Mogalapalli
2025-09-02 7:13 ` Geert Uytterhoeven
2025-09-02 13:02 ` Harshit Mogalapalli
2025-09-02 16:50 ` Rong Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF1bQ=TB6KMAkwXfEF=ZJvJZqV8B9kEw3jbVMG4gRoLOUjksiA@mail.gmail.com' \
--to=xur@google.com \
--cc=corbet@lwn.net \
--cc=geert@linux-m68k.org \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shenhan@google.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox