From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2AF11BC070 for ; Mon, 11 Nov 2024 22:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731364760; cv=none; b=JAknLET5mPYaJIjF6z2DpwsF7mCSwJFPpYYquiKxBvpqJJ6pxwgR8n4h4ujzivv0SAfZvbokB1qlzlFxqnU6BP8fuBH+l8Dym0EKW61lodDA0b41AwQ71gaRRa2avvjPjKtiMUR9KsAGTDG299nA1hkTsH15oC8d4s+G1H8R5aQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731364760; c=relaxed/simple; bh=eB8Ofe1WFjYWH1BdIe5Spco+AoLzN0kxnSrTkBUA88Q=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=onomI+JHiE+H8omtZYRu1BWjGw6ngCDN6jvXUx6ysFr2l3SqCOu2oilUKirW/Ik896BHskAhiKtvB3YpbAcn1k3Tka51gMwrHiYnQIoU/7TpMTVrMYk8pZO+twtg8L/LNnQCffYT1tRnn1vC9PniRAZFanwsD9PSBihF35cW/Es= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ElFowb/N; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ElFowb/N" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4608dddaa35so101491cf.0 for ; Mon, 11 Nov 2024 14:39:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1731364757; x=1731969557; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/2kkJJPrMSags8YoRSR8VcHdm0Q+fmhGso6Vl4PBlQI=; b=ElFowb/NgPe/jS82S+DSq04OF/+AhB0hsJ/zYlYGqqxuiTV0mtgCTfcFjXsisOwPTb z5UqXl0EhddAMJJU09DTyNsIZCyeO0kfCMfMEBbzw2b+n62Icfb60Y/gV/NMrhgeEIv4 Vzv170Dx0lZ3hiIV9K+krTcJuiqVwQljZLGH4fl/mwjr69IFueFBP/UwYv0bAndhnFwm K2XOo4U9BUlm2ASBmnNOpbX0cC/LJsWBKHSdTwF6hOI/QO7jUEcnjA5vXhZp1I01hy9D gigDm9ZJUNwI80TY0Qp8HHa44x3i6v+4koyBcMPdDL6BL6aIFaaYoKaQstnikXYcF9y/ C7mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731364757; x=1731969557; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/2kkJJPrMSags8YoRSR8VcHdm0Q+fmhGso6Vl4PBlQI=; b=Fi9eoGxgKLhJ1hnqj5YL7WiRcSqvMHFXPxCCpdovrFNilMoss/MMHHtuAW9ErqQJS0 Ya+7kzBsznxR4Ki+kXhjfhDrkdrmwjpHX/FSiQ/cOwYPtd+Dm5pPizM3nkJDCtYx485S 9W+t3iwvtZm1Tlq12P0Z9/9WGq+fB+TtY0vacrllDRpnQl+RiOXSZ7hgzIuWkJQWFpTc /CQRdNuKxdmNKl573yE8sVmUdqvaUUfU9HvtXAq1GMBdNBGfw2L+FsQtoisrRzzg/1+U vVpWyP1tiEYBLdYE9wV9dV+dbOANbO9oO35vXE5f9uFtdBvcWXJ+k91vC9cUe48W8KLD yKaQ== X-Forwarded-Encrypted: i=1; AJvYcCWNEoB+863O/adyd47ddwWik1SVH4pVxSoUzgHZnAvj+jW9lEzuhtagU3kfwmGYr6IPH2aG4baEI8c=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4NpGiX82ssy+O2f/K7BBmv1BoCJejAgiYV4X+E3Jw1c4otri0 qH0phi3567zr7mlGEiEjXNvTRpGJnpQZTMNrnxDNXAWmo89DIJpBMPcrlNBDtIvGvQ8h+di14Dk OvfQJebh/gJNdIf8tng22UtZVaR4SBnrVWGyU X-Gm-Gg: ASbGncuUQ297Q2yEEhifKVIK2xyUD26CgrXwAoli55hv6vmNGM0gaC8oUfaQe24TISF CV8JfSEiauOeBfMopvrJNdXwgpTd6KqSvI7J6TFPN0ykrUoASV9zvncAnMWuDww== X-Google-Smtp-Source: AGHT+IGWz5fxnaCrLCNd/OH6jFNg44ylUdGuht8uH/3QX9IXKi/RoL7fie/C49RsOcadfvZfnBz8SZRoCkm3npHj8KM= X-Received: by 2002:a05:622a:190a:b0:462:c96a:bb30 with SMTP id d75a77b69052e-4633ef60502mr1176031cf.2.1731364757391; Mon, 11 Nov 2024 14:39:17 -0800 (PST) Precedence: bulk X-Mailing-List: workflows@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241026051410.2819338-1-xur@google.com> <20241026051410.2819338-4-xur@google.com> <44193ca7-9d31-4b58-99cc-3300a6ad5289@gmail.com> In-Reply-To: From: Rong Xu Date: Mon, 11 Nov 2024 14:39:05 -0800 Message-ID: Subject: Re: [PATCH v6 3/7] Adjust symbol ordering in text output section To: Klara Modin Cc: Alice Ryhl , Andrew Morton , Arnd Bergmann , Bill Wendling , Borislav Petkov , Breno Leitao , Brian Gerst , Dave Hansen , David Li , Han Shen , Heiko Carstens , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Jonathan Corbet , Josh Poimboeuf , Juergen Gross , Justin Stitt , Kees Cook , Masahiro Yamada , "Mike Rapoport (IBM)" , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , "Paul E. McKenney" , Peter Zijlstra , Sami Tolvanen , Thomas Gleixner , Wei Yang , workflows@vger.kernel.org, Miguel Ojeda , Maksim Panchenko , "David S. Miller" , Andreas Larsson , Yonghong Song , Yabin Cui , Krzysztof Pszeniczny , Sriraman Tallam , Stephane Eranian , x86@kernel.org, linux-arch@vger.kernel.org, sparclinux@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable In the new System.map, we have: ffffffff81112400 T _stext This looks wrong. It should point to the beginning of the text, like ffffffff81100400 T _stext I'll do some debugging on this. -Rong On Mon, Nov 11, 2024 at 1:32=E2=80=AFPM Klara Modin = wrote: > > On 2024-11-11 21:43, Rong Xu wrote: > > Thanks for reporting this issue! > > > > I'm assuming your kernel build enables dead code elimination and > > uses the --ffunction-sections compiler flag. Without this patch, all > > the functions > > -- I think there are only .text.unlikely.* and .text.* are grouped > > together in the > > final vmlinux. This patch modifies the linker script to place > > .text.unlikely.* functions > > before .text.* functions. I've examined arch/mips/kernel/vmlinux.lds.= S, and > > haven't found any obvious issue. > > > > Can you send me the following? > > (1) the kernel build command > > (2) System.map without the patch > > (3) System.map with the patch > > > > Best regards, > > > > -Rong > > > I don't set -ffunction-sections explicitly but it seems to be used when > I look at the .cmd files. The build command is nothing fancy, I just set > ARCH=3Dmips CROSS_COMPILE=3Dmips64-unknown-linux-gnuabin32- and build wit= h > make -j24. > > I've attached the System.map, built on next-20241111 as well as it with > this series reverted. > > Regards, > Klara Modin