From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19C061CACEF for ; Wed, 23 Oct 2024 16:23:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729700611; cv=none; b=UW4Fl3vPeKihZH8qX2TCeSY3Sew2Lc3HK8ouRg70lFiHxtu4H+pswK9YJI+tmYJM/sDbp4sD5r9Dt5bIY0Dj4u85wmVsrXN6DdWImDDrQDuguEpwEeb/dbi3Wlc4Fhh2sP9kFaQT9uzyscM6Z+UfAsU17u5Z0CIQ06dCk7S+kpY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729700611; c=relaxed/simple; bh=+F9vNJ1/djrWjsipasBD8bhmQbboSFemBhQbuVC0gTg=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=mhdTf1vVHOzSAd4v3RimLEyCeWBvYAoZzfjrlh8awwu2VQsNUy1VeW0jLSu4/9lEMAh/UP1naHO50slDUpQY+mty/IyoSmWzm6KeDnB7hgfEG8v9QdVHYtBar6sqd2XZlAau7TsrxWDFq8K6Tjgv4/hSOghQLSOSWaN9UKfVa5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=FKtQ4dhe; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FKtQ4dhe" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-460a8d1a9b7so276151cf.1 for ; Wed, 23 Oct 2024 09:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729700609; x=1730305409; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=o9BznJlsEbHz6OZfmqFHe4r9gEp0tOVcj12rfA//KDE=; b=FKtQ4dheu9v73f/dgGQZvoEqZdIsRfdeC+1RPyNegiA88oR3l8LZdegLlKC5MaE7xg 8a7VsjyzPwAyr/sjEVWRwQn8XblEHSBagI7Kr2Q0cmv8wKGOKdlQQsMeNAiv1ejI6vIV sU6nNUDiSWbT8NrXkoPCzD72A/cbJMY6MtEnObQOzC72ftkviUMVFjscqHEsUlQWHL/n X0p428EAnK5e8StpDo/Q4Nqa2KerCqH0O3rUDnuwbncolgIVEqarhyZP0bMqVNiMdpcO BUMaPOUQdyXLfF9PPAomzPpj2Yw0YWMRunfHUJpwaPjVmuEk2FAsDQ1f2RGj92ag+QJX 9gpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729700609; x=1730305409; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o9BznJlsEbHz6OZfmqFHe4r9gEp0tOVcj12rfA//KDE=; b=TCVnepxQN3w/9BjO2GWxQX9fg4KbwvyYWxJZer/R3V9SRgNQLaTLJPb9LAxdPKT2X4 +igUbtogvDegzNQ9cdLs/DHlfSHLHC22Uo8z8kJZY5rZBt9hvH2Js5Iq7HIv6lcEXdtb 38UWGqh5MOUIcLH7hJ76yK+G2gXg0XgrzztPYLe0iZMUuqxue1ZbYbJki8q9PZnE5jea Nv0PD2Kd4fv+iYDH9WPfm/hvYAv187exFVNDEKH1rl60L3UbqHkbj07L8IVBjAjvTK7X jii8q1xHUi+SsfmXX2nCsrk/jkMZW6zGdhm1uz2kWURYfyRA6JW6IAn+nUTe3UlfMkC3 PpUg== X-Forwarded-Encrypted: i=1; AJvYcCXE5JeMhRq36nYswJo2aw0h+ZlWiFxy7sODkQPSl/UhR3u5x3G521BHF0j7IV5d/E4tLRChNTqQkaM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1R2WjJcMyRKgu+preirBqwqiP4GwifmaIocZ6EkkoAlvtAndS utgYz0ufURIKrQS2Fvt1Q/GauUHRrICljC2RlqpN9TAry79vklR1Kt6EE9ypN/Mrfn32ytKF5sq 1SRnf9EaVY/1prRhpRCdWgYlkiGzI5a/BDCWk X-Google-Smtp-Source: AGHT+IG1FMKW9jEoP384sXUW7ke85OPpn1MSvATc3a4GObiTP9bSiG7WRlmZKZlcz1ig7syTvhf9DR79c1H5TXpjIHs= X-Received: by 2002:a05:622a:1347:b0:460:46a8:9e67 with SMTP id d75a77b69052e-46113afc61emr4399981cf.10.1729700608716; Wed, 23 Oct 2024 09:23:28 -0700 (PDT) Precedence: bulk X-Mailing-List: workflows@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241014213342.1480681-1-xur@google.com> <20241014213342.1480681-7-xur@google.com> In-Reply-To: From: Rong Xu Date: Wed, 23 Oct 2024 09:23:14 -0700 Message-ID: Subject: Re: [PATCH v4 6/6] Add Propeller configuration for kernel build. To: Masahiro Yamada Cc: Arnd Bergmann , Alice Ryhl , Andrew Morton , Bill Wendling , Borislav Petkov , Breno Leitao , Brian Gerst , Dave Hansen , David Li , Han Shen , Heiko Carstens , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Jonathan Corbet , Josh Poimboeuf , Juergen Gross , Justin Stitt , Kees Cook , Mike Rapoport , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , "Paul E. McKenney" , Peter Zijlstra , Sami Tolvanen , Thomas Gleixner , Wei Yang , workflows@vger.kernel.org, Miguel Ojeda , Maksim Panchenko , x86@kernel.org, Linux-Arch , linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Sriraman Tallam , Krzysztof Pszeniczny , Stephane Eranian Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable While Propeller often works best with AutoFDO (or the instrumentation based FDO), it's not required. One can use Propeller (or similar post-link-optimizer, like Bolt) on plain kernel builds. So I will remove "depends on AUTOFDO_CLANG". I will not use "imply" -- simpler is better here. -Rong On Wed, Oct 23, 2024 at 12:29=E2=80=AFAM Masahiro Yamada wrote: > > On Wed, Oct 23, 2024 at 4:25=E2=80=AFPM Arnd Bergmann wro= te: > > > > On Wed, Oct 23, 2024, at 07:06, Masahiro Yamada wrote: > > > On Tue, Oct 22, 2024 at 9:00=E2=80=AFAM Rong Xu wrot= e: > > > > > >> > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > >> > > + > > >> > > +Configure the kernel with:: > > >> > > + > > >> > > + CONFIG_AUTOFDO_CLANG=3Dy > > >> > > > >> > > > >> > This is automatically met due to "depends on AUTOFDO_CLANG". > > >> > > >> Agreed. But we will remove the dependency from PROPELlER_CLANG to AU= TOFDO_CLANG. > > >> So we will keep the part. > > > > > > > > > You can replace "depends on AUTOFDO_CLANG" with > > > "imply AUTOFDO_CLANG" if it is sensible. > > > > > > Up to you. > > > > I don't think we should ever encourage the use of 'imply' > > because it is almost always used incorrectly. > > If we are able to delete the 'imply' keyword, Kconfig would be a bit clea= ner. > > In most cases, it can be replaced with 'default'. > > > > -- > Best Regards > Masahiro Yamada