From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E4001C3040 for ; Fri, 4 Oct 2024 17:06:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728061607; cv=none; b=OfUrejGB5vw0jpLekk5E3hLZnS94U0QEFVVpDJKOeJRzcM4CSxV0UKus/2TZsJRmqTBUZOA1/K6m+DSbQ+1cnn2dS6+EUCG3O6tUrvZQcPc6PgFpONT/8wysIEHjvx5H5oYrffEggE9lWNKT3He6DaFZSeykjkq4ze+7UScGZoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728061607; c=relaxed/simple; bh=BjiMOaBbb0faHgkP9UM7KVpOSCigooWaCDDnmSzqOfs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=qNjLBkp1mE8+Fe3TfUdTKe9Rk6z/HJsCkNY43W7GBgAhnaq02SrVJB3m2ix/ZkSV5wOftTfhkf3mtjqi3jPPkydvnKjyHBHhlOn2kTm2jh30g/JKeLsTCCVSt66Jqo7/L/VbSqARgGVvvCbIUvY7FMWkKA8JwycL2ezi6fmNyJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gj5z4rIy; arc=none smtp.client-ip=209.85.166.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gj5z4rIy" Received: by mail-il1-f178.google.com with SMTP id e9e14a558f8ab-3a36ad4980bso9995ab.0 for ; Fri, 04 Oct 2024 10:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728061605; x=1728666405; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=H6cu0/usr2tJa4vPbaqm37ZxgrIgWX+DZr/8ABHb5Pg=; b=gj5z4rIyOyRyAXbqPZWbhSX2yvMCkAWjN3h4rPTxJruWjLP8LhuYwYC1mFdHWJBE81 vbNCpO8uIWyYg1B1mMPg7h5f8wXO6VvnpRAqUibA+9W8B0XyKDsMEABkgUBgLJ1QumVn Z7v2Dblc/iXgsAJNJr1LgR13J6lEJcbvj2OzgiBo24kbhJjTU+cYxTqN8s7zXbfq8sU/ /6QJduLy19AIFaWOZECTzfaanppfRJIou11SM39yq1EgZctZ+BUrFpQzVYAkgRZ/tPz6 MLs1lz4xh9I/X3G2RotLeMfiJTzgzhzUAUZErD8X0rP6FwU2a/1KjkgmpmhPEMcMaAw8 QJrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728061605; x=1728666405; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H6cu0/usr2tJa4vPbaqm37ZxgrIgWX+DZr/8ABHb5Pg=; b=cusmEw2mLagr5nl6aZkXGAOAdpQW2DCQYGXGLmn+nWAhv+Ijje8UROalpf2feLVAwu tAAYQ6uuCOgUlb5h6RtSRSgeQuId5q6/5rgEeFFNB3cPaFRfMqQ3CR2bjGOmMwjF8saP LAOZiVRyE7pNbM0+raXxcfWrVNQ2F70jp/+S7WV4D/OWByD58J638SNuHC3VkPMtDC93 k6TbsPieUm+mrCGb8yfvUu6W5uUinl6UjzJ3upXd0HvqdqIzaT95UjKG/FRGfqIpETNu GUwcECfJAiT1YeUr19TLlNXAabMF4wWsbYF/20BVIsf8zW5zYEF+VJqM/aShhFHLALfH Qnsw== X-Forwarded-Encrypted: i=1; AJvYcCX022OtduldO7KNrtpDvvZV4y0yQtW/k6DbsSsXWHzSB5sAbZe08sAC+XXAQdqkBfYAKOruFb4Q8kc=@vger.kernel.org X-Gm-Message-State: AOJu0YxJzfnJuoN3XQ8vSbfDt/ncrDniwkF3P86Mq9O9mq0KKKNNyimd V/mJVWvEDyLgZx5D4N9wWQetUaONu2ng755UyC7hAVeZmO8SXQLSyX2zueV1vsNKS6SAYVpG+kI NU6+j6ja1Wz0Ysw5Koefx30v8d0VIdelVo+Ds X-Google-Smtp-Source: AGHT+IErDf6Ln07o0AdPteE4Z2MSQLZR5z2/ayMLVov/t1OUkBR776jawppVTTQuFQ07+1/nFJ6gPgMV9aMQcWHF+14= X-Received: by 2002:a05:6e02:154f:b0:3a0:a3cd:f23d with SMTP id e9e14a558f8ab-3a3767de7e9mr3340835ab.5.1728061604302; Fri, 04 Oct 2024 10:06:44 -0700 (PDT) Precedence: bulk X-Mailing-List: workflows@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241002233409.2857999-1-xur@google.com> <20241002233409.2857999-2-xur@google.com> <20241003154143.GW5594@noisy.programming.kicks-ass.net> <20241003160309.GY5594@noisy.programming.kicks-ass.net> <20241003161257.GZ5594@noisy.programming.kicks-ass.net> In-Reply-To: From: Rong Xu Date: Fri, 4 Oct 2024 10:06:30 -0700 Message-ID: Subject: Re: [PATCH v2 1/6] Add AutoFDO support for Clang build To: Mike Rapoport Cc: Peter Zijlstra , Nick Desaulniers , Jonathan Corbet , Han Shen , Sriraman Tallam , David Li , Krzysztof Pszeniczny , Alice Ryhl , Andrew Morton , Arnd Bergmann , Bill Wendling , Borislav Petkov , Breno Leitao , Brian Gerst , Dave Hansen , Heiko Carstens , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Josh Poimboeuf , Juergen Gross , Justin Stitt , Kees Cook , linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Masahiro Yamada , Nathan Chancellor , Nicolas Schier , "Paul E. McKenney" , Samuel Holland , Thomas Gleixner , Wei Yang , workflows@vger.kernel.org, x86@kernel.org, "Xin Li (Intel)" , Stephane Eranian Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 4, 2024 at 9:38=E2=80=AFAM Mike Rapoport wrot= e: > > On Fri, Oct 04, 2024 at 09:28:36AM -0700, Rong Xu wrote: > > On Thu, Oct 3, 2024 at 11:09=E2=80=AFPM Mike Rapoport = wrote: > > > > > > On Thu, Oct 03, 2024 at 11:20:17AM -0700, Rong Xu wrote: > > > > Writing the doc with all these code-blocks was not fun either. > > > > We are happy to change if there is a better way for this. > > > > > > > > -Rong > > > > > > > > On Thu, Oct 3, 2024 at 9:13=E2=80=AFAM Peter Zijlstra wrote: > > > > > > > > > > On Thu, Oct 03, 2024 at 09:11:34AM -0700, Nick Desaulniers wrote: > > > > > > > > > > > > It makes it absolute crap for all of us who 'render' text doc= uments > > > > > > > using less or vi. > > > > > > > > > > > > "It hurts when I punch myself in the face." > > > > > > > > > > Weirdly enough I have a job that entails staring at text document= s in > > > > > text editors all day every day :-) sorry for thinking that's a sa= ne > > > > > thing to do. > > > > > > Something like this should do: > > > > > > > +- For enabling a single file (e.g. foo.o):: > > > > + > > > > + AUTOFDO_PROFILE_foo.o :=3D y > > > > Do you mean we don't use ".. code-block:: " here and just use indented > > text separated with blank lines? > > The double column (::) in the end of a paragraph means that the next para= graph > is a literal block: > > https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#l= iteral-blocks > > You'd loose the coloring, but other than that it won't be different from > the ".. code-block::" and easier to read in a text form. Sorry that I did not notice the (::) in your suggestion. This is great. I'll change the docs in this patch to use this method. -Rong > > > -Rong > > -- > Sincerely yours, > Mike.