From: Dmitry Vyukov <dvyukov@google.com>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Greg KH <gregkh@linuxfoundation.org>, Eric Wong <e@80x24.org>,
workflows@vger.kernel.org
Subject: Re: patch attachments still unwelcome?
Date: Mon, 4 Nov 2019 14:23:33 +0100 [thread overview]
Message-ID: <CACT4Y+atKXTqfjSCjzhf_P0MT+fQT-vP90nfct__BaiF2qiK0A@mail.gmail.com> (raw)
In-Reply-To: <20191104131310.GE28764@mit.edu>
On Mon, Nov 4, 2019 at 2:13 PM Theodore Y. Ts'o <tytso@mit.edu> wrote:
>
> On Fri, Nov 01, 2019 at 10:04:56AM +0100, Greg KH wrote:
> > > So the documentation in the kernel advising against sending
> > > patch attachments seems hypocritical. Changing the kernel docs
> > > allow patch attachments could be a good start to making life
> > > easier for contributors without SMTP or IMAP access.
> >
> > It's not hypocritical, as lots of email clients still get this wrong and
> > make responding to attachments almost impossible. Many do get it right,
> > but trying to document the differences here is quite difficult (I tried
> > once, gave up as it was a mess).
> >
> > > Are many MUAs still incapable of handling them?
> > > mutt shows text patches inline, at least.
> >
> > For most MUAs that send them, yes, but not for all. I know of at least
> > 2 that send text attachments in formats that mutt will not show it
> > inline, nor allow responding to them properly. MacOS Mail is one easy
> > example to point to as getting this totally wrong.
> >
> > So, if you know what you are doing, yes, this is fine, but it's still a
> > good idea to say "please do not do this" to make it easier for people
> > just starting out.
>
> Perhaps we should explicitly explain this and then include a white
> list of MUA's that can send text attachments safely/correctly? (e.g.,
> if you are using the following MUA's, using text attachments are OK;
> if you are using the following MUA's, it will definitely NOT work;
> with all others, proceed with caution.)
One thing that wasn't clear to me when I implemented syzbot is that
some people see attachments inline. syzbot included whole kernel
config and 1MB of logs as attachments, I assumed that other people see
them as, well, attachments. So that may be worth documenting as well.
Though, I did not know that document exists as well, so it would not
help me...
next prev parent reply other threads:[~2019-11-04 13:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 2:27 Eric Wong
2019-11-01 9:04 ` Greg KH
2019-11-04 13:13 ` Theodore Y. Ts'o
2019-11-04 13:23 ` Dmitry Vyukov [this message]
2019-11-04 14:49 ` Jani Nikula
2019-11-04 17:40 ` Geert Uytterhoeven
2019-11-05 10:46 ` Geert Uytterhoeven
2019-11-04 13:42 ` Greg KH
2019-11-04 13:42 ` Drew DeVault
2019-11-01 13:00 ` Konstantin Ryabitsev
2019-11-04 11:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACT4Y+atKXTqfjSCjzhf_P0MT+fQT-vP90nfct__BaiF2qiK0A@mail.gmail.com \
--to=dvyukov@google.com \
--cc=e@80x24.org \
--cc=gregkh@linuxfoundation.org \
--cc=tytso@mit.edu \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox