From: Dmitry Vyukov <dvyukov@google.com>
To: Barret Rhoden <brho@google.com>
Cc: workflows@vger.kernel.org
Subject: Re: Ideas from Jane Street's code review
Date: Mon, 30 Sep 2019 12:38:59 +0200 [thread overview]
Message-ID: <CACT4Y+ZtRL_4nfOTWH74ddv4UMiQc9v-o0C8D5s_PFsJT2VBeA@mail.gmail.com> (raw)
In-Reply-To: <c247f8eb-c324-30d3-b41d-02afe1dc829d@google.com>
On Thu, Sep 26, 2019 at 5:06 PM Barret Rhoden <brho@google.com> wrote:
>
> Hi -
>
> Jane Street did some interesting things with their code review and
> workflow, such as handling diffs-of-diffs and tracking what needs to be
> reviewed.
>
> Their ideas might be orthogonal to the whole "workflow that works for
> email / web / your-tool-here" discussion, but some of the underlying
> principles may inspire a good overall design:
>
> Tech talk:
> https://blog.janestreet.com/jane-street-tech-talk-how-jane-street-does-code-review/
>
> Links to their blogs:
> https://github.com/janestreet/iron
Interesting idea of editing, saving and committing comments along with
the code into review branches.
Added it to the list for completeness:
https://github.com/dvyukov/kit/blob/master/doc/references.md#iron
Thanks, Barret.
prev parent reply other threads:[~2019-09-30 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 15:06 Barret Rhoden
2019-09-30 10:38 ` Dmitry Vyukov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACT4Y+ZtRL_4nfOTWH74ddv4UMiQc9v-o0C8D5s_PFsJT2VBeA@mail.gmail.com \
--to=dvyukov@google.com \
--cc=brho@google.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox