From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
Jens Axboe <axboe@kernel.dk>, Vlastimil Babka <vbabka@suse.cz>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Jakub Kicinski <kuba@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Caleb Sander Mateos <csander@purestorage.com>,
io-uring <io-uring@vger.kernel.org>,
workflows@vger.kernel.org
Subject: Re: Link trailers revisited (was Re: [GIT PULL] io_uring fix for 6.17-rc5)
Date: Tue, 9 Sep 2025 11:13:31 -0700 [thread overview]
Message-ID: <CAADnVQKAR-MnALzJXdvdef4ftgMA1=Z_c4bnzep68yO20vLAow@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=winCxfCXfTgjfhdqkp2EXrx7fbrGookkHuAtT3Lp5xT1w@mail.gmail.com>
On Tue, Sep 9, 2025 at 11:01 AM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Tue, 9 Sept 2025 at 10:56, Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:
> >
> > It doesn't work reliably. Often enough maintainers massage the patch
> > a bit while applying to fix minor nits and patch-id will be different.
>
> Honestly, if you massage a patch you should probably mention it.
>
> THAT is the kind of thing where it actually makes sense to say
> "modified version of XYZ" and pointing to the original.
>
> Look, at that point it's actually *IMPORTANT* to explicitly state that
> you didn't actually apply the original patch.
and I did in the email reply (as you could see in the lore link).
That's what we always do.
Email is the way to communicate such changes.
Sometimes we rewrite the commit log too to reduce verbosity,
fix typos or whatever. Without direct email reply developers
don't notice that commit was tweaked.
The point is that 'git patch-id --stable' is not reliable.
next prev parent reply other threads:[~2025-09-09 18:13 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9ef87524-d15c-4b2c-9f86-00417dad9c48@kernel.dk>
[not found] ` <CAHk-=wjamixjqNwrr4+UEAwitMOd6Y8-_9p4oUZdcjrv7fsayQ@mail.gmail.com>
[not found] ` <20250905-lovely-prehistoric-goldfish-04e1c3@lemur>
[not found] ` <CAHk-=wg30HTF+zWrh7xP1yFRsRQW-ptiJ+U4+ABHpJORQw=Mug@mail.gmail.com>
2025-09-05 19:33 ` Konstantin Ryabitsev
2025-09-05 20:09 ` Linus Torvalds
2025-09-05 20:47 ` Sasha Levin
2025-09-06 11:27 ` Greg KH
2025-09-06 11:27 ` Greg KH
2025-09-06 11:30 ` Greg KH
2025-09-06 13:51 ` Konstantin Ryabitsev
2025-09-06 15:31 ` Linus Torvalds
2025-09-06 18:50 ` Konstantin Ryabitsev
2025-09-06 19:19 ` Linus Torvalds
2025-09-08 9:11 ` Jani Nikula
2025-09-08 11:59 ` Mark Brown
2025-09-08 20:11 ` dan.j.williams
2025-09-09 11:29 ` Mark Brown
2025-09-09 13:17 ` Rafael J. Wysocki
2025-09-09 14:18 ` Jakub Kicinski
2025-09-09 14:35 ` Jens Axboe
2025-09-09 14:42 ` Konstantin Ryabitsev
2025-09-09 14:48 ` Vlastimil Babka
2025-09-09 14:50 ` Jens Axboe
2025-09-09 15:30 ` Rafael J. Wysocki
2025-09-09 16:40 ` Linus Torvalds
2025-09-09 17:08 ` Mark Brown
2025-09-09 17:50 ` Linus Torvalds
2025-09-09 17:58 ` Linus Torvalds
2025-09-09 18:31 ` Konstantin Ryabitsev
2025-09-09 19:36 ` dan.j.williams
2025-09-10 1:12 ` dan.j.williams
2025-09-10 12:19 ` Mark Brown
2025-09-09 17:25 ` dan.j.williams
2025-09-09 17:56 ` Alexei Starovoitov
2025-09-09 18:01 ` Linus Torvalds
2025-09-09 18:13 ` Alexei Starovoitov [this message]
2025-09-09 18:06 ` Vlastimil Babka
2025-09-09 18:14 ` Linus Torvalds
2025-09-09 18:22 ` Vlastimil Babka
2025-09-09 21:05 ` Mark Brown
2025-09-10 1:33 ` Konstantin Ryabitsev
2025-09-09 14:44 ` Greg KH
2025-09-09 15:14 ` Danilo Krummrich
2025-09-09 16:32 ` [RFC] b4 dig: Add AI-powered email relationship discovery command Sasha Levin
2025-09-09 17:22 ` Laurent Pinchart
2025-09-09 17:26 ` Jens Axboe
2025-09-09 18:54 ` Sasha Levin
2025-09-10 10:13 ` Laurent Pinchart
2025-09-10 10:55 ` Sasha Levin
2025-09-10 11:29 ` Laurent Pinchart
2025-09-10 13:38 ` Konstantin Ryabitsev
2025-09-10 14:03 ` Andrew Dona-Couch
2025-09-11 14:48 ` Nicolas Frattaroli
2025-09-11 15:05 ` Sasha Levin
2025-09-11 19:13 ` Nicolas Frattaroli
2025-09-11 19:57 ` Sasha Levin
2025-09-15 11:26 ` Mark Brown
2025-09-15 11:48 ` Sasha Levin
2025-09-15 12:03 ` Mark Brown
2025-09-11 23:24 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADnVQKAR-MnALzJXdvdef4ftgMA1=Z_c4bnzep68yO20vLAow@mail.gmail.com' \
--to=alexei.starovoitov@gmail.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=dan.j.williams@intel.com \
--cc=io-uring@vger.kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=rafael@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox