From: Andrew Donnellan <ajd@linux.ibm.com>
To: workflows@vger.kernel.org
Subject: Re: RFC: using supersedes: trailer to indicate patch/series revision flow
Date: Fri, 8 Nov 2019 11:09:56 +1100 [thread overview]
Message-ID: <9c5dc531-5edf-cb9a-9ddd-0bb1572c9b21@linux.ibm.com> (raw)
In-Reply-To: <20191107204349.hqpefgp7cowj6hof@chatter.i7.local>
On 8/11/19 7:43 am, Konstantin Ryabitsev wrote:
> Questions:
>
> 1. Should this be exposed via git-format-patch flags, or just used by
> specialized tooling?
I guess we might want to expose it through git format-patch for the sake
of completeness? Though if people actually use it with git format-patch,
then the answer to Q2 is irrelevant because people will use it to link
to whatever the heck they feel like at the time...
Though what do you envision the user workflow actually looking like with
a specialised tool?
> 2. Should supersedes: link to the previous version of the patch, or the
> first ever version of the patch? I am leaning towards the latter,
> even though in this case the message-id largely becomes identical in
> usage to Gerrit's Change-Id.
If we link to the first version of the patch, we can't tell that V3
supersedes V2. Though if we link to only the previous version, we can't
tell that V3 supersedes V1 without looking at V2.
From a Patchwork perspective, if we were to use this to track patch
versions I think we could work with either, except for some corner cases
where mail is not received or received in the wrong order and there's
not enough subject metadata to work things out.
You could also include multiple trailers e.g. the first version and last
version, or all previous versions that are superseded, though that seems
a bit verbose.
> 3. Should the supersedes trailer have:
> a. message-id without brackets
> b. message-id with brackets
> c. https://lore.kernel.org/r/message-id
> My preference is b, to match with The Message-Id header usage.
A or B makes the most sense.
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2019-11-08 0:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 20:43 Konstantin Ryabitsev
2019-11-07 23:45 ` Rafael J. Wysocki
2019-11-08 8:30 ` Han-Wen Nienhuys
2019-11-08 9:59 ` Geert Uytterhoeven
2019-11-08 10:48 ` Laurent Pinchart
2019-11-08 11:00 ` Rafael J. Wysocki
2019-11-08 0:09 ` Andrew Donnellan [this message]
2019-11-08 9:19 ` Vegard Nossum
2019-11-08 9:46 ` Geert Uytterhoeven
2019-11-14 6:29 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c5dc531-5edf-cb9a-9ddd-0bb1572c9b21@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox