workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: James.Bottomley@hansenpartnership.com, akpm@linux-foundation.org,
	anton.ivanov@cambridgegreys.com, corbet@lwn.net,
	davem@davemloft.net, dmaengine@vger.kernel.org,
	ebiggers@kernel.org, edumazet@google.com, horms@kernel.org,
	jaegeuk@kernel.org, jarkko@kernel.org, jic23@kernel.org,
	johannes@sipsolutions.net, kernel@collabora.com,
	keyrings@vger.kernel.org, kuba@kernel.org, lars@metafoo.de,
	linux-doc@vger.kernel.org, linux-fscrypt@vger.kernel.org,
	linux-iio@vger.kernel.org, linux-integrity@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-mm@kvack.org, linux-sound@vger.kernel.org,
	linux-um@lists.infradead.org, maxime.chevallier@bootlin.com,
	mchehab@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com,
	perex@perex.cz, richard@nod.at, tiwai@suse.com, tytso@mit.edu,
	vkoul@kernel.org, workflows@vger.kernel.org, zohar@linux.ibm.com
Subject: Re: [PATCH] docs: Remove literal markup from Documentation/ paths
Date: Mon, 7 Apr 2025 10:03:26 -0400	[thread overview]
Message-ID: <9bc7b77b-73a7-4d6d-9187-ac452f8cad23@notapiano> (raw)
In-Reply-To: <811c4103-08b1-4288-9a15-bd9795bc59f4@gmail.com>

On Sat, Apr 05, 2025 at 10:17:16AM +0900, Akira Yokosawa wrote:
> Hi,
> 
> Nícolas F. R. A. Prado wrote:
> > Given that the automarkup Sphinx plugin cross-references
> > "Documentation/*.rst" strings in the text to the corresponding
> > documents, surrounding those strings with the literal markup (``) not
> > only adds unnecessary markup in the source files, but actually prevents
> > the automatic cross-referencing to happen (as it doesn't happen in
> > literal blocks).
> > 
> > Remove all the occurrences of the literal markup in
> > "Documentation/*.rst" paths, except when the actual source file is being
> > referred. Also change the surrounding text when needed so it reads well
> > both in the source and the web page (eg. 'see file Doc...' -> 'see
> > Doc...').
> > 
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > ---
[..]
> >  
> >  2) All new ``Kconfig`` options have help text.
> >  
> > @@ -47,7 +48,7 @@ Provide documentation
> >  2) All new ``/proc`` entries are documented under ``Documentation/``
> >  
> >  3) All new kernel boot parameters are documented in
> > -   ``Documentation/admin-guide/kernel-parameters.rst``.
> > +   Documentation/admin-guide/kernel-parameters.rst.
> 
> Hmm, this item is asking "Have you documented the new params in that
> particular file?", so I don't think this change should be made.

Right, that makes sense. I'll drop this and the below change for v2.

Thanks,
Nícolas

> 
> >  
> >  4) All new module parameters are documented with ``MODULE_PARM_DESC()``
> >  
> > @@ -58,7 +59,7 @@ Provide documentation
> >     linux-api@vger.kernel.org.
> >  
> >  6) If any ioctl's are added by the patch, then also update
> > -   ``Documentation/userspace-api/ioctl/ioctl-number.rst``.
> > +   Documentation/userspace-api/ioctl/ioctl-number.rst.
> 
> Ditto.
> 
>         Thanks, Akira
> 
> >  
> >  Check your code with tools
> >  ==========================
> 

  reply	other threads:[~2025-04-07 14:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04 15:37 Nícolas F. R. A. Prado
2025-04-04 17:20 ` Jonathan Cameron
2025-04-04 17:42   ` Jonathan Corbet
2025-04-05 15:31     ` Jonathan Cameron
2025-04-04 17:43 ` SeongJae Park
2025-04-05  1:17 ` Akira Yokosawa
2025-04-07 14:03   ` Nícolas F. R. A. Prado [this message]
2025-04-07  3:08 ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bc7b77b-73a7-4d6d-9187-ac452f8cad23@notapiano \
    --to=nfraprado@collabora.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=akiyks@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dmaengine@vger.kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=jarkko@kernel.org \
    --cc=jic23@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=kernel@collabora.com \
    --cc=keyrings@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mchehab@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=perex@perex.cz \
    --cc=richard@nod.at \
    --cc=tiwai@suse.com \
    --cc=tytso@mit.edu \
    --cc=vkoul@kernel.org \
    --cc=workflows@vger.kernel.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox