From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ABA919F42C for ; Thu, 1 May 2025 00:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746060021; cv=none; b=NXR7c0pRBKP0cGSeumPj57H1k0e0k3g/ul/FJVc5o8lw8PfFGW4CE9pCG8YfelDTcoVdQXrKL684OZFCdDSKFK/5AF3ld82an0P3n6dCaBGc/h+fBLFqQoa+M1qMFmSEThWefcfDPlhPqzfh4k75sX51GiaN1NS0NStzclAjPvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746060021; c=relaxed/simple; bh=552tRLcpTCtKGHW+KggBdoahEXInHzfBOErT/0f9miI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MJdQMvU+ylAK+OyxnnGF1g08tMh53sC6BpzYv41HDJ8SGApQzODNouqZnZz7msB7IY0hUB+7puf5R3vLWZrjEszR/Q8GP7G1zjap3Q7W3ZwakyZBq2YFX5yEQEhokw8Ho6bfrIIaS1rrlJYgsekKRwaNJ9nhOCD7cGwMEwPA408= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IchzMFys; arc=none smtp.client-ip=209.85.166.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IchzMFys" Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-861d7a09c88so12289839f.2 for ; Wed, 30 Apr 2025 17:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1746060016; x=1746664816; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=81Imi5jthw6ckQVVKqp6SOrhZOqAy++fKyUkHYMDBAM=; b=IchzMFyszbG/A9A5vnpws5289Upz7M2m+B/HnlR++20oh1bvghL48p30A+exeFm7kT Tb5Iqta9u8svgegF9sJLjGLfrHJ7YELMUIEv3UKdY54VCaaGqVZ6dINmGbeXgYAFs5EP +ExrYufMLuu2v3Osk6auJ+0S+ybzU98ydS42E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746060016; x=1746664816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=81Imi5jthw6ckQVVKqp6SOrhZOqAy++fKyUkHYMDBAM=; b=GIRA/cMkAK/470kGqGM2V6zAkjeCS326bW7D+CGhC0N/5VobPBhv3CPYidNtXNhdXo tnhjT4Sn7rE2fjIsqAhFJLoKIieVWk/5ReSyhJU+OgFd5T2ICsnfC5PHTHH/qDFkHa4g RHVsNBl0HX/6sUmtqyIk6L/Kf4ILEQENRr/JSnPMu2R3/7rD2papJxw/g/pMzCCbGweM AqIUV7fOlsgfuc7UBzSz1EoMYsBYvf3SOK2dWJUTMLL9/z9BvvuWZspxlsRt/gEEL9ub TEZFamdYV8dPCKnwWVY3jRNVVjbnjk8u+fN+/O4L5Y2tKDxVFfMP5OiPZ/7LEn67uVw4 AfiQ== X-Forwarded-Encrypted: i=1; AJvYcCVBitorGvkf0rPs1gcR1ZNyNe6Ndnh0/H3tZ74U+nn5zy33oqxGN/ovWGgvNFUEvoHYUgc5Cn9pEP4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzp1ayPXQhjtwTump1F9cXXC9baGjAo9nu3ZsHmWi1JVMDnEijm /8PMgzlFs0i9R4oD5h0cwRr0G6K2t7tWbDgYiYzL7Ve/JusLnuusSdr3UvAcOhc= X-Gm-Gg: ASbGncuBT1DFeJ2Gb3HqGM/Bpmh/9Q/IY/cYsxNgewTXF39D7BBDed/GSK2J3YWuLYW t8lPEpdM+oq+LtOffuZlp8IJAysQXgb7GsGK+mvr7v1fYnZfLj2G8yYKyWPko7PagVABU7vUfwA g5esUTAdJyHV/c2QOm+Yvo56O2T9UncSGqM6bej1zvoJv7lwBua2I8NIjGUIsGof7QB4hwQw0MP lwNVtz3H03dnbjbzQlvG2LVWpDd0y5wnQ7d6q1JLNLR8vbe0SnJSAV8BsU6C+nXVrW7X/fiXWZ+ OcGKBEV0Duvt3oQkrSDLEjYkC6R+2A7zrEO766PgwYM1E2VK5BODqmypYXFmEA== X-Google-Smtp-Source: AGHT+IEqgjRflu+1J1ow23/oxPjAJWAFmuKPdOwmbO4yPHSPfoz6dXuQvghS/4uINgdSWOrZCkv2pg== X-Received: by 2002:a05:6602:36ca:b0:861:1ba3:3e50 with SMTP id ca18e2360f4ac-864a2051d04mr182168439f.0.1746060016528; Wed, 30 Apr 2025 17:40:16 -0700 (PDT) Received: from [192.168.1.14] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f862e0fcbdsm995927173.5.2025.04.30.17.40.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Apr 2025 17:40:15 -0700 (PDT) Message-ID: <949a6ddc-4663-4b41-9f08-a3c0d07307af@linuxfoundation.org> Date: Wed, 30 Apr 2025 18:40:14 -0600 Precedence: bulk X-Mailing-List: workflows@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] kunit: add tips to clean source tree to build help message To: David Gow Cc: brendan.higgins@linux.dev, rmoar@google.com, corbet@lwn.net, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <4d1acc28-3645-461a-97e3-316563f468e0@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: <4d1acc28-3645-461a-97e3-316563f468e0@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/30/25 15:25, Shuah Khan wrote: > On 4/29/25 21:54, David Gow wrote: >> On Wed, 30 Apr 2025 at 06:27, Shuah Khan wrote: >>> >>> Add tips to clean source tree to build help message. When user run >>> kunit.py after building another kernel for ARCH=foo, it is necessary >>> to run 'make ARCH=foo mrproper' to remove all build artifacts generated >>> during the build. In such cases, kunit build could fail. >>> >>> Signed-off-by: Shuah Khan >>> --- >> >> Thanks for doing this. >> >> This looks good to me, save for the issue below. >> >> I do wonder whether there's a more general fix we can do in the >> makefiles, but I'm not sure how that'd have to work. Maybe by storing >> the architecture used somewhere and amending the error based on that, >> or hacking around the specific x86_64/UML incompatibilities. But let's >> go ahead with this fix regardless. > > I agree the right fix is to see if kunit.py can suggest the right arch > to clean. I will take a look at that. It is an easy change to the main Makefile. Will send the patch tomorrow. We won't need the documentation and help message changes with the main Makefile change. thanks, -- Shuah